Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp3520707pxf; Mon, 15 Mar 2021 11:23:22 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzHRJMw6v9ZU5u7lIkadNJYiPRgJxCBn/YYEyXgczp0ka/mU8R52B7xz8/NiAbm9cHUy1WF X-Received: by 2002:a17:906:2b9a:: with SMTP id m26mr24610189ejg.526.1615832602410; Mon, 15 Mar 2021 11:23:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1615832602; cv=none; d=google.com; s=arc-20160816; b=uMzLS21raKbt8i4Bvrwuc7XxU7VxLiyH1fsZBhxg1MkrZy7wSBfS8g/ok86StRcqYJ 68OzOpDL4NhffqDv4eN0gEG+MRA/bG+kZ/FZRdA1k7xH8kCU/Y+jC2IYb8XSWf8Ul4SH lyjNQBqvEbh7w3wwAYJwY5Q6THi6bictHhKcJrhgtoGoAjrUDKdpidDPCh0A7EbgkmHN GN/05P03vrWi9X6d9waIfCYfKZitI8TEwcteedwB7zJi+TZ6OtFbfltzmZ6ywphKhSF/ 8dw2DjkYu+vxOyFQUwfeyZDT7B7HMO4FFGUaH5BYxLg59ITmoKww5yVz8cnJwgtggmhQ jyhQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=HnPbfCyHb4Tc4iadKCinME7f9u8QEkkZRTJqacf/EAY=; b=j+Jkvdv91zrGZaf2EntFHcM/AIjFH7x/Loj5GtENBhc0ifeZWmOgfGHPq9XLStFzFY Sh99RbStC9cxAshVqpGOv5TZj0U4unAEtT3UjIShJKjYCoBKf7D3EpBPjBfO+bvIyVME 102PfvtuVm8S4c+Fk330InWgydvULLjuJKpMOUkQ9DfpXM7V9zqbM8WBrT6gNQhYE39u LJYdtOSMrDH0DsGVrEfwvwiQtZLM5zIYzUyyOKbMa3sYaKsKFXWAdX+4XBzcu5x0AbS2 21NpOXQczhAq1g56ZqvUYWsLvTVNY2TDzWVqV0DA+0w7bECHI5a7GR+N9ZxdmHQHgtFv KVaA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=iXbRZARc; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id z24si11255254ejx.462.2021.03.15.11.22.59; Mon, 15 Mar 2021 11:23:22 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=iXbRZARc; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238133AbhCOOWq (ORCPT + 99 others); Mon, 15 Mar 2021 10:22:46 -0400 Received: from mail.kernel.org ([198.145.29.99]:37500 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232917AbhCOOAK (ORCPT ); Mon, 15 Mar 2021 10:00:10 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 65DA564F38; Mon, 15 Mar 2021 13:59:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1615816795; bh=G54vohvt+g5VieYybML1LGzxlSiZ1Tb+gpNzAx1aXvg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=iXbRZARcCPM9aIFuskUmQfGN+dTqjysp32XiQ77Fx+YdrmMGlTQOZA4JiCDC+6iOj XcBAlQQs11vHLK1euAv7jCFAFuSAebre96aXrtDIVJnLmWBGlwit39r5vmw1Oz5vzE HLWCf4b93gJL2gUnvTgqQOBnJknQhqPZ3JBw3NZY= From: gregkh@linuxfoundation.org To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, "Steven J. Magnani" , Jan Kara , Sasha Levin Subject: [PATCH 5.11 129/306] udf: fix silent AED tagLocation corruption Date: Mon, 15 Mar 2021 14:53:12 +0100 Message-Id: <20210315135512.018201682@linuxfoundation.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210315135507.611436477@linuxfoundation.org> References: <20210315135507.611436477@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Greg Kroah-Hartman From: Steven J. Magnani [ Upstream commit 63c9e47a1642fc817654a1bc18a6ec4bbcc0f056 ] When extending a file, udf_do_extend_file() may enter following empty indirect extent. At the end of udf_do_extend_file() we revert prev_epos to point to the last written extent. However if we end up not adding any further extent in udf_do_extend_file(), the reverting points prev_epos into the header area of the AED and following updates of the extents (in udf_update_extents()) will corrupt the header. Make sure that we do not follow indirect extent if we are not going to add any more extents so that returning back to the last written extent works correctly. Link: https://lore.kernel.org/r/20210107234116.6190-2-magnani@ieee.org Signed-off-by: Steven J. Magnani Signed-off-by: Jan Kara Signed-off-by: Sasha Levin --- fs/udf/inode.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/fs/udf/inode.c b/fs/udf/inode.c index bb89c3e43212..0dd2f93ac048 100644 --- a/fs/udf/inode.c +++ b/fs/udf/inode.c @@ -544,11 +544,14 @@ static int udf_do_extend_file(struct inode *inode, udf_write_aext(inode, last_pos, &last_ext->extLocation, last_ext->extLength, 1); + /* - * We've rewritten the last extent but there may be empty - * indirect extent after it - enter it. + * We've rewritten the last extent. If we are going to add + * more extents, we may need to enter possible following + * empty indirect extent. */ - udf_next_aext(inode, last_pos, &tmploc, &tmplen, 0); + if (new_block_bytes || prealloc_len) + udf_next_aext(inode, last_pos, &tmploc, &tmplen, 0); } /* Managed to do everything necessary? */ -- 2.30.1