Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp3521267pxf; Mon, 15 Mar 2021 11:24:13 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwTijFY5zQGOj7f3Vr1YkMHEwOZX5BZbZI3i89P8JVSQNnMDrzULlk1KvqxgkODYm66vgr0 X-Received: by 2002:a17:907:7684:: with SMTP id jv4mr25768909ejc.231.1615832653777; Mon, 15 Mar 2021 11:24:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1615832653; cv=none; d=google.com; s=arc-20160816; b=MP+YwIe6MAo3VgybC2QVxETSHm6pejxAzzHuDW/BzFSexy3cctKPK4g0/1n0eGh+fb mwsSYrKudFmLLICVnW6QY9uYqS+VLfocQNkYsM1cJae3NogDKWnUJPm3DrmKd4rTbXa4 sf5E8EXgLO76RXUJmPbQqnp7yVB79MxCmokkH69m+oSmBDCrrUbbmaab0DsuSxUFF/r0 /qACn4nGtVEeAQOfC3ls65qqk4+X+QSXzGJcHFMV2DbFu2JpnoiVyYRIFbcbq5JPhhoy Lbj7SfN58Ir4vHrVeDX8f6FAbP+jh5oOihs7VIWvbe6YckzH3Omplh0539RTmCUHyPfY /IBQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=P7xkBkqK2748Gb3bt2mgmrqUCUxfW46WSYnyXba8DqU=; b=aXlp1ro38rfsjwz64V2wdd1bivWvKv2mlpVR2LmRSEVk8xNvMkktL7Bzo6HIHGGNRX +VnAvafUSjph8YWOpMDb5UROCimRBLxJmtbW1NGWBMui9De8WYdPX5j3dou0B8ra9UhB ER+k0P+RnWpANml+Qx8iOvEdwzdJG6G5FwYSoiK4TNvairNIlD8H0JlEFzPRGnZQAerb 0F9cpTKDPYwovSsqEXN5h6RPHMsZWhaSWoTvEDkrZS7LLE7LXVepT5Z5Yg4j1sdJ3u4a HBRPJ9t83rB/niQ9mnRPQCP9QeNoCsJ+L9v52GiXioZno4+pCS26Djs6MCljTqKcz4qM FeVw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=FXFAp21Z; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id zj12si11230954ejb.508.2021.03.15.11.23.51; Mon, 15 Mar 2021 11:24:13 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=FXFAp21Z; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233865AbhCOOVu (ORCPT + 99 others); Mon, 15 Mar 2021 10:21:50 -0400 Received: from mail.kernel.org ([198.145.29.99]:35186 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232894AbhCOOAG (ORCPT ); Mon, 15 Mar 2021 10:00:06 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 4250964F64; Mon, 15 Mar 2021 13:59:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1615816790; bh=c8KAdcG5B2JQKskhgtJjRsGY0l4cuauy7Qe4U1UDquQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=FXFAp21Z8K76fod3LEu7plseQBJ5BmxfjmFW6WoLERrzD0ao6DGErsKoQ86Oe5vGl 6Kt9DPTKPgC0UmybihPQZgyARn/qiKk4Y495NdeJOvwW8KWg1b+tymVV7LoBjxbdyp bFGj3BeEgNIZKUVVw2d42WpHsLYx5CUYD0aUD2nY= From: gregkh@linuxfoundation.org To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, John Crispin , Alexander Lobakin , Vladimir Oltean , Florian Fainelli , Jakub Kicinski , Sasha Levin Subject: [PATCH 5.10 116/290] net: dsa: tag_qca: let DSA core deal with TX reallocation Date: Mon, 15 Mar 2021 14:53:29 +0100 Message-Id: <20210315135545.841674579@linuxfoundation.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210315135541.921894249@linuxfoundation.org> References: <20210315135541.921894249@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Greg Kroah-Hartman From: Vladimir Oltean [ Upstream commit 9bbda29ae1044bc4c1c01a5b7c44688c4765785f ] Now that we have a central TX reallocation procedure that accounts for the tagger's needed headroom in a generic way, we can remove the skb_cow_head call. Cc: John Crispin Cc: Alexander Lobakin Signed-off-by: Vladimir Oltean Reviewed-by: Florian Fainelli Signed-off-by: Jakub Kicinski Signed-off-by: Sasha Levin --- net/dsa/tag_qca.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/net/dsa/tag_qca.c b/net/dsa/tag_qca.c index 1b9e8507112b..88181b52f480 100644 --- a/net/dsa/tag_qca.c +++ b/net/dsa/tag_qca.c @@ -34,9 +34,6 @@ static struct sk_buff *qca_tag_xmit(struct sk_buff *skb, struct net_device *dev) __be16 *phdr; u16 hdr; - if (skb_cow_head(skb, QCA_HDR_LEN) < 0) - return NULL; - skb_push(skb, QCA_HDR_LEN); memmove(skb->data, skb->data + QCA_HDR_LEN, 2 * ETH_ALEN); -- 2.30.1