Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp3521397pxf; Mon, 15 Mar 2021 11:24:26 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzpT7nAsUn+7/sM/GKrxL6R4lkeyc3fJYC4h1FmlfEvkAXD87oE+IyZa0t8qPJdNPq8nfI+ X-Received: by 2002:a17:906:f9cc:: with SMTP id lj12mr24658092ejb.544.1615832665886; Mon, 15 Mar 2021 11:24:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1615832665; cv=none; d=google.com; s=arc-20160816; b=WH9yxCg4LD3CvdpYbhNWIsOP58/6dOtoUUa0nnxwKlda8pDcU1r0/+hWPaNObY/uR7 W3vzlzghrBC6fFrO71VyOteFl7qb5Cn4ttan3xI3gJpoeunZaTUiWLWumkJY+rKSBNrW 2keIy6gAykMWc3bmlOp674/CjLoIFNMOQ4B21zV4/MoWdlbIUbUFdSuhgIX6H3BiSnp0 BGZtGYpOvF4H22XZkWPIprBenOYbjFKAUGD8bfXfpqwA7JPTBC7sxMcLhxeTtvR9iXr5 YgZKA6mJl/mKt/kc/vzMCjbO92smxnmuo/qke1TAPYZs5oLNgbJv1OGlmsJX/z2E6Ukv 5lSA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=QO4gmVjpenk94NyLHbwKn8zTVzqZLKfLVgxMWy8CVXE=; b=wJ8etvur4POcdvnXl4OQMzaDLd1fUd6n8hqRWe9jDDr7zfDV8428V1U6i1JGHil2Ey NIfeADTX+O8Jt2tQs8ZspvvYvFR9XaIyFm/mcN0RVte6Wwf9/TP5ILp6mwF0ZMGZIgWT hrkN+dvbMRfvji8XL2bh5zeliKTAMoCJJXuqw/AlR/P3/E8LoUbBhSCk7a+P2QR9rxJE 2I7Bi/NAIeOJSdQgcjIbz2TdCUYmHCtvaUAxRNJdM9tnEbe/ychx4XqsaiGadKCKispf lh8VTm8Y7lHPSJaHAI7RPKxLXoo8lzzUroJAlfmkWiblLrADcIhD8CPIAYuMIssuUsWn q3Ww== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=RLRGrGbk; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id g27si11658506ejc.32.2021.03.15.11.24.03; Mon, 15 Mar 2021 11:24:25 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=RLRGrGbk; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238247AbhCOOW6 (ORCPT + 99 others); Mon, 15 Mar 2021 10:22:58 -0400 Received: from mail.kernel.org ([198.145.29.99]:36622 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232937AbhCOOAM (ORCPT ); Mon, 15 Mar 2021 10:00:12 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id C7E9764EEE; Mon, 15 Mar 2021 13:59:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1615816800; bh=DLoX+Xgb55NQV1cGPzEsQ5WFk/evGIURthxR/iPGl6Y=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=RLRGrGbkQm9d8QpGKmZuOd2o1uCL78ejwhj4vxZjcYR1yKCI90HGt3rQoDJN3igio UJwrBScIAOtZa8xtUzmh/FntanpUVRrT1XJf3cj98lhCxGojh1gk1Vcd/5z3JYV4Pq Du/iEFB9Lfm8+c6V4u7MrcWiEHr+fU+F7O7fYee4= From: gregkh@linuxfoundation.org To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Florian Fainelli , Vladimir Oltean , Jakub Kicinski , Sasha Levin Subject: [PATCH 5.10 121/290] net: dsa: tag_brcm: let DSA core deal with TX reallocation Date: Mon, 15 Mar 2021 14:53:34 +0100 Message-Id: <20210315135546.009631211@linuxfoundation.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210315135541.921894249@linuxfoundation.org> References: <20210315135541.921894249@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Greg Kroah-Hartman From: Vladimir Oltean [ Upstream commit 2f0d030c5ffec6660f79a32b4f522155f75a9d71 ] Now that we have a central TX reallocation procedure that accounts for the tagger's needed headroom in a generic way, we can remove the skb_cow_head call. Cc: Florian Fainelli Signed-off-by: Vladimir Oltean Reviewed-by: Florian Fainelli Signed-off-by: Jakub Kicinski Signed-off-by: Sasha Levin --- net/dsa/tag_brcm.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/net/dsa/tag_brcm.c b/net/dsa/tag_brcm.c index ad72dff8d524..e934dace3922 100644 --- a/net/dsa/tag_brcm.c +++ b/net/dsa/tag_brcm.c @@ -66,9 +66,6 @@ static struct sk_buff *brcm_tag_xmit_ll(struct sk_buff *skb, u16 queue = skb_get_queue_mapping(skb); u8 *brcm_tag; - if (skb_cow_head(skb, BRCM_TAG_LEN) < 0) - return NULL; - /* The Ethernet switch we are interfaced with needs packets to be at * least 64 bytes (including FCS) otherwise they will be discarded when * they enter the switch port logic. When Broadcom tags are enabled, we -- 2.30.1