Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp3524982pxf; Mon, 15 Mar 2021 11:29:24 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxInB6dkvNO0+HEiRsHNSSxfgQvqSs/1D0gbC4q/jbMkMonR8kRQG1e+aKpkFEZee8NYjGg X-Received: by 2002:a17:906:b015:: with SMTP id v21mr24582379ejy.243.1615832964270; Mon, 15 Mar 2021 11:29:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1615832964; cv=none; d=google.com; s=arc-20160816; b=Aga87K50McdeD2WUsgO7x+eXfVUUczSNsQMco0RJV5HodOGvf5fABUQjQQiRUebbsl tuChdrYYoFPNxyLSwQ+ZlXylKKDstvzM1uvSWvbClIdPrhdg1e+i7IUfzGpq2q7TRdBO XkR8CRNuKZNr/v7oRNW00WfIjEcajg66dmMHyuoPSGfiiENgE7TNuufeuhAgPcAYdsMQ Qk/5zAgENVE75rXTKN/Xbq+vwBm73pJuuKmRKXv8+wX9oXgzSdijXPfMHa4oexJPbtsC PCJ8rCfn4g8mKqmZ65zeeDnyIWwcrGpPiBhSPQtmioy67NinJD3KNmhyntw12u0bvCda XzjA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=TboaE1msCrdkCczLlfxRTOTJE0hsdiHKBR2y4BclFiU=; b=Z16i1fdYTPJgZbH+1q9utS72VOMvQuwWxOcNhM+YeQJBgVBUrbcdAuJ5bq1aH4fV8p 83e6WANuEJMabCzJ5icg+idNs7ccWqbE2gZh9Z1FOkiRPDGN9urdLfv+X5B6EjBS/TdK RpoOGuW6xEWMPvOmOyqUX6JzswJL3EV8lrg45QdNX36VVCJ6J/qO7FRIcEE18QzRaYAk LWLUcqxiO0Lj9O6iyeU2yhkvAxpvr2boMf9Q2rdN6i8DpCFNK0qzltqZPUqBTK/zoaNN J4Tx5e6sYJ/D51sP/zj2mS1eEc3Wk7BRdU5ttLwABKNzSBHC+eUyTmRFcDg1HNtzcx+L LV+A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=qW82SmFG; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id ss17si11654538ejb.678.2021.03.15.11.28.58; Mon, 15 Mar 2021 11:29:24 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=qW82SmFG; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240109AbhCOOda (ORCPT + 99 others); Mon, 15 Mar 2021 10:33:30 -0400 Received: from mail.kernel.org ([198.145.29.99]:35446 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233278AbhCOOBV (ORCPT ); Mon, 15 Mar 2021 10:01:21 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id A978664F19; Mon, 15 Mar 2021 14:00:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1615816857; bh=0/7THb51rLr6O46ogVRC0HvZOZOkuhi8Nh008It35pg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=qW82SmFGQZawmw8m3eWVvdBD2isDLqp5g2kcUqRvWNAboLowRtJLd6sCMLBKONUIa sjKEN+rUdwWd+Ycw5jnfc4nmFv9Wk4C89By9pGNrjDW6nRAcwLvIM1tJjJmuKfUeaI zvR9sgi5bbjhowSpvStdPNzBanL/1DafFnHkID0g= From: gregkh@linuxfoundation.org To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Takashi Iwai , Abhishek Sahu Subject: [PATCH 5.11 165/306] ALSA: hda/hdmi: Cancel pending works before suspend Date: Mon, 15 Mar 2021 14:53:48 +0100 Message-Id: <20210315135513.213734968@linuxfoundation.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210315135507.611436477@linuxfoundation.org> References: <20210315135507.611436477@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Greg Kroah-Hartman From: Takashi Iwai commit eea46a0879bcca23e15071f9968c0f6e6596e470 upstream. The per_pin->work might be still floating at the suspend, and this may hit the access to the hardware at an unexpected timing. Cancel the work properly at the suspend callback for avoiding the buggy access. Note that the bug doesn't trigger easily in the recent kernels since the work is queued only when the repoll count is set, and usually it's only at the resume callback, but it's still possible to hit in theory. BugLink: https://bugzilla.suse.com/show_bug.cgi?id=1182377 Reported-and-tested-by: Abhishek Sahu Cc: Link: https://lore.kernel.org/r/20210310112809.9215-4-tiwai@suse.de Signed-off-by: Takashi Iwai Signed-off-by: Greg Kroah-Hartman --- sound/pci/hda/patch_hdmi.c | 13 +++++++++++++ 1 file changed, 13 insertions(+) --- a/sound/pci/hda/patch_hdmi.c +++ b/sound/pci/hda/patch_hdmi.c @@ -2472,6 +2472,18 @@ static void generic_hdmi_free(struct hda } #ifdef CONFIG_PM +static int generic_hdmi_suspend(struct hda_codec *codec) +{ + struct hdmi_spec *spec = codec->spec; + int pin_idx; + + for (pin_idx = 0; pin_idx < spec->num_pins; pin_idx++) { + struct hdmi_spec_per_pin *per_pin = get_pin(spec, pin_idx); + cancel_delayed_work_sync(&per_pin->work); + } + return 0; +} + static int generic_hdmi_resume(struct hda_codec *codec) { struct hdmi_spec *spec = codec->spec; @@ -2495,6 +2507,7 @@ static const struct hda_codec_ops generi .build_controls = generic_hdmi_build_controls, .unsol_event = hdmi_unsol_event, #ifdef CONFIG_PM + .suspend = generic_hdmi_suspend, .resume = generic_hdmi_resume, #endif };