Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp3526555pxf; Mon, 15 Mar 2021 11:31:30 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwcOdUSmesqVtThKTFjM3jdqQb9uuSHxgwWiZCzUzOZ7cJphbM9SvR7vL8CqOmRIuMELXpS X-Received: by 2002:a17:906:52d0:: with SMTP id w16mr25062500ejn.172.1615833090746; Mon, 15 Mar 2021 11:31:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1615833090; cv=none; d=google.com; s=arc-20160816; b=aRjV1T9dbX4tMj6SblgsloFSlrNI84c+Y3iYJJeegJIqEeuvQ3aoFQu2bkSx/KLSL3 s0Xu2la9yrgjs12PtL35M6joKxloIbjvgy4k/4JP6m6aQPVsSNQZSUEO9Oj25bKZDkD8 kwr+nseqKPjKKPBqs7IfnviceDQcunpTKBiUN6eDEJ1jgEI7zbG/A4d10xLzLr6MxgSP phaMD0dTxBGnw40yCEi8RGsuMRRNwzXCHC0ycdg3aAE3sZ+aUmG9Kl+aQ2P76innXcZq JeJOd8ezVDvA6AL0ERDqSZS99oVRJicRgFCXY3L4A0pDlEsR0GefC5yGfSl0G//hTx+y NG7w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=vxXEwDXoUaCTCh1JZEUg9AlGbzQgVGRxwIi6cmbAOpg=; b=auPvjQgGMQpsoHQSC091jVmzQPV6xeRoaoTcEBQc4HA/WGL0zVzCVmZEK0hZG2ukRU esB9kPe4rt7OrMbzWnWvV7wCoXRgns8hC1GKfMu2aDYhCf6CUZHHdz9Cnh5eLLC9vJzT 8VQ3rGYMSHCEzWp+tL4itp8fgOzorH4Ik87MbjGd5Wnjvty526DVSPwmK0PelfmVnwVh +9SZ4Pxa085Fcf0f2vwgTfpNQ3sXtg/h4k+QdHjXXRqdZslex0XWQ5TSbYsbtjgh4Cce 2Bt5ij7Em3ecBAdHE0ukRQtc0LCFtmdHFebxgmafydz104kvol4ITxu4lmIE8v97v8yb mcUw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=HzuYyCrV; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id m9si11748304ejj.339.2021.03.15.11.31.08; Mon, 15 Mar 2021 11:31:30 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=HzuYyCrV; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236361AbhCOOfM (ORCPT + 99 others); Mon, 15 Mar 2021 10:35:12 -0400 Received: from mail.kernel.org ([198.145.29.99]:36594 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233467AbhCOOBo (ORCPT ); Mon, 15 Mar 2021 10:01:44 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id BA04664F2E; Mon, 15 Mar 2021 14:01:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1615816896; bh=HB43tIWA/SDJJ+Ad8NreII/d3eY5xm7qwiFNHDfBMVA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=HzuYyCrVTcpmQWq/MlTp/m/p8NJtCifW29LgZe9zUzNGu4/apvBTrurMB6KfkHGYR +TNpQ9TQJ+CL5GWb5mYnZqnyJlXt1jR3dPHAI1SUdNTO4bbyBfHKdjh4RevWKX6K3P EFQjtdZ+Yc243CyNGCPdtwFIkfk2Oe4FdU5uuxeY= From: gregkh@linuxfoundation.org To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Takashi Iwai Subject: [PATCH 5.10 175/290] ALSA: hda: Drop the BATCH workaround for AMD controllers Date: Mon, 15 Mar 2021 14:54:28 +0100 Message-Id: <20210315135547.824783899@linuxfoundation.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210315135541.921894249@linuxfoundation.org> References: <20210315135541.921894249@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Greg Kroah-Hartman From: Takashi Iwai commit 28e96c1693ec1cdc963807611f8b5ad400431e82 upstream. The commit c02f77d32d2c ("ALSA: hda - Workaround for crackled sound on AMD controller (1022:1457)") introduced a few workarounds for the recent AMD HD-audio controller, and one of them is the forced BATCH PCM mode so that PulseAudio avoids the timer-based scheduling. This was thought to cover for some badly working applications, but this actually worsens for more others. In total, this wasn't a good idea to enforce it. This is a partial revert of the commit above for dropping the PCM BATCH enforcement part to recover from the regression again. Fixes: c02f77d32d2c ("ALSA: hda - Workaround for crackled sound on AMD controller (1022:1457)") BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=195303 Cc: Link: https://lore.kernel.org/r/20210308160726.22930-1-tiwai@suse.de Signed-off-by: Takashi Iwai Signed-off-by: Greg Kroah-Hartman --- sound/pci/hda/hda_controller.c | 7 ------- 1 file changed, 7 deletions(-) --- a/sound/pci/hda/hda_controller.c +++ b/sound/pci/hda/hda_controller.c @@ -609,13 +609,6 @@ static int azx_pcm_open(struct snd_pcm_s 20, 178000000); - /* by some reason, the playback stream stalls on PulseAudio with - * tsched=1 when a capture stream triggers. Until we figure out the - * real cause, disable tsched mode by telling the PCM info flag. - */ - if (chip->driver_caps & AZX_DCAPS_AMD_WORKAROUND) - runtime->hw.info |= SNDRV_PCM_INFO_BATCH; - if (chip->align_buffer_size) /* constrain buffer sizes to be multiple of 128 bytes. This is more efficient in terms of memory