Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp3528189pxf; Mon, 15 Mar 2021 11:33:39 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxT5fXIeNw+a5BUaT3P1UZKfHthatnFFHCSAEIctIheznIe02y6PTwqRdSkhqEXQeyjXk04 X-Received: by 2002:a05:6402:1545:: with SMTP id p5mr31291538edx.155.1615833218868; Mon, 15 Mar 2021 11:33:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1615833218; cv=none; d=google.com; s=arc-20160816; b=rd23ZXaVkpRD6RTluLakSDYHO5usrKCKc6VnhYZnkr2dNTpGUPWXEjNZTmuH07EG/J Qm4owf1BHCweHVz4cdVrkByzOHZydm1GRXo/wBYVOmI6BSU4e1q+gnac8eSb5zRIe4xo AyGvYTXA66Em/djx5+DTunvciBu/J0BnPVdK29eY4Wp3IjpBHHU7E1QnKp2Rvw00dFVv 7MV+H1wmHDL6lsg8hvpbctP1LSwMRt/TqlIWK1qyk0qejfSkcJMIMSw7KIpn1249It0a 9ozyfcS2jH51w0jYvDbb3qsHU2y6jXbbMrwfxnhxilnN+ju3VyxPh9UVW5MxJm1qJfzv Djtg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=9ZtAPpFsewyCSvUB7ez6V/1FWLvYhhJ7/bI2EbMps8M=; b=qC8Ir9NM3XwWIZJs6PjkLupIpro9VefsodN3guDRIFc0vV8YhsmYS6sHhHeFDmekyh dGTTyYcz/v3Gvc6PbrqyXBCI6O4Kid17tYApvTpODT/6YcE3fa0DpURdGoHZm9EFh8SL mNp/8tGcaTaliWTXDZ4gKn/fyDl2dyTxDr2xpXq/QbvZWjWqYIcqavU1HSk0iUehsec6 ouJfuCcs3k2DEgYBg5IjpZwz59mgAeK6hoewNkXp7Ar7CFJdxtcyR7GpFrZUXyMoxlcT z2jo6cWmMEAg+jTNDV/HGBG0R2VF4TKwKfChBUi8IVU6H4W76JHyJ4Jg9PFnXEc6xWet 4r6Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=slNT9Cmw; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id t12si11250025ejc.21.2021.03.15.11.33.16; Mon, 15 Mar 2021 11:33:38 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=slNT9Cmw; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238685AbhCOOmr (ORCPT + 99 others); Mon, 15 Mar 2021 10:42:47 -0400 Received: from mail.kernel.org ([198.145.29.99]:49638 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234357AbhCOODQ (ORCPT ); Mon, 15 Mar 2021 10:03:16 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 5091164E83; Mon, 15 Mar 2021 14:03:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1615816996; bh=jXmsmJ53SzD4UnqQjC8pqBIu+n78DV1VH/uxOqQKBCI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=slNT9CmwrnqQt6xfrXY1qYQxGkJfoZ2LBhkqZ8BH+zG5QXbsXKOZOHvbUOkEshcM1 zgdOTcFqt4yJ4u71NYpJlDRwsNPjVak2wsBFw3Y6OLfD9XWFAHXhL8j266F2UFV0M5 pe8QlI5Sh883wGlL2iCk4iKBaKhA0TpySQLE0f8s= From: gregkh@linuxfoundation.org To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Ian Abbott Subject: [PATCH 5.10 237/290] staging: comedi: dmm32at: Fix endian problem for AI command data Date: Mon, 15 Mar 2021 14:55:30 +0100 Message-Id: <20210315135549.991767452@linuxfoundation.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210315135541.921894249@linuxfoundation.org> References: <20210315135541.921894249@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Greg Kroah-Hartman From: Ian Abbott commit 54999c0d94b3c26625f896f8e3460bc029821578 upstream. The analog input subdevice supports Comedi asynchronous commands that use Comedi's 16-bit sample format. However, the call to `comedi_buf_write_samples()` is passing the address of a 32-bit integer variable. On bigendian machines, this will copy 2 bytes from the wrong end of the 32-bit value. Fix it by changing the type of the variable holding the sample value to `unsigned short`. [Note: the bug was introduced in commit 1700529b24cc ("staging: comedi: dmm32at: use comedi_buf_write_samples()") but the patch applies better to the later (but in the same kernel release) commit 0c0eadadcbe6e ("staging: comedi: dmm32at: introduce dmm32_ai_get_sample()").] Fixes: 0c0eadadcbe6e ("staging: comedi: dmm32at: introduce dmm32_ai_get_sample()") Cc: # 3.19+ Signed-off-by: Ian Abbott Link: https://lore.kernel.org/r/20210223143055.257402-7-abbotti@mev.co.uk Signed-off-by: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/dmm32at.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/staging/comedi/drivers/dmm32at.c +++ b/drivers/staging/comedi/drivers/dmm32at.c @@ -404,7 +404,7 @@ static irqreturn_t dmm32at_isr(int irq, { struct comedi_device *dev = d; unsigned char intstat; - unsigned int val; + unsigned short val; int i; if (!dev->attached) {