Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp3528482pxf; Mon, 15 Mar 2021 11:34:03 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzDwHXimV5+jtmG+bCvfeU4VWY4x3LsALM8vgZOEzTmpelhYqhMYPOH0yEszWjHrYYydq1i X-Received: by 2002:a17:906:14d0:: with SMTP id y16mr25699521ejc.242.1615833243750; Mon, 15 Mar 2021 11:34:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1615833243; cv=none; d=google.com; s=arc-20160816; b=Q2tJD10YAu3FFSm6doucJY5lkHsJ7kMxtriwl7AOVDy/LCs4F1mAPYE72h0YeaIjzB dA8I1kOrZytA8J2NvTwFaIDlpKCwx3Z6NtEKralLfwBnLYO+zM9BCy/XmOMvBoNLcWRl 0LAcM1rPLQoizNFTI92hvfGkAoD1o3OZ9U/n9QlX6OnL8JdtJaRJk+d415zQBmNUDCLY FjLq8mGreWutBpItv5VgpVZ+4HUFvKfdEq4Mj4BIvsgtP03hKueneGxD7myzABWGSru9 o6JWk773lscvrfSaw39/yZlKriNmC4zc78RQX904PgacAjYIEt30s+MVwr91hZicREHH 6uqg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=veUwSKQig/42ACsYOwjnWkJqe6dN/mXPx9o4GnyK0bQ=; b=vWbxemDKxV1ZDXGftb1zOSBp7Q9WiP6CwswoBVWzQrc944iiHlPF/Lu+wdHIFb+bUG mTWuUxBrxFmZW0/LdoN4LZVUBDCUIntaNH9DUoEtRlmGm2zzqcpJmf76eO7fLSL6ycN/ i+Z35o0FCXq5gmZ7tc+NiPoYjky3meZ2Dze4E6YoF6mA9TmJm0EISapCzpFThQy2jAsO 5DdZzdD+iNmtbGcJcbVrlRkU7PFJsYhHkB9SdN+skwpO6r57DRRaOb6tszvPJad2fvL7 721W+dzbpHw6tIRxLgRgaozCfbavYoEibxouYNvw34H6uk2RFNokekxFQBcNy4shqnfO ZDtA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b="ZKxo5B/F"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id n20si11457528ejx.104.2021.03.15.11.33.40; Mon, 15 Mar 2021 11:34:03 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b="ZKxo5B/F"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238947AbhCOOp3 (ORCPT + 99 others); Mon, 15 Mar 2021 10:45:29 -0400 Received: from mail.kernel.org ([198.145.29.99]:52034 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234549AbhCOOET (ORCPT ); Mon, 15 Mar 2021 10:04:19 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 24884600EF; Mon, 15 Mar 2021 14:04:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1615817058; bh=t6RUt6HUzB0MgaDyS9B4bHBo4NehUJSKVH0UAGG2iL0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ZKxo5B/F5K3/SzSq8/w6sguyzgHibHV3EAPjaf0CzfW6hjICxtBM9dEhoGPLHG67h GFnFbFPWsKxHjtSCT2ReABpNOhYoGTtASKQDIOLZn4+omiUb459jeUspb16Vttspis L98dmdYcA1SafiBpKSM23/C/ATSXvN8ppWBiPtgU= From: gregkh@linuxfoundation.org To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Geert Uytterhoeven , kernel test robot , Christophe Leroy , Michael Ellerman Subject: [PATCH 5.10 267/290] powerpc: Fix missing declaration of [en/dis]able_kernel_vsx() Date: Mon, 15 Mar 2021 14:56:00 +0100 Message-Id: <20210315135551.044220754@linuxfoundation.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210315135541.921894249@linuxfoundation.org> References: <20210315135541.921894249@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Greg Kroah-Hartman From: Christophe Leroy commit bd73758803c2eedc037c2268b65a19542a832594 upstream. Add stub instances of enable_kernel_vsx() and disable_kernel_vsx() when CONFIG_VSX is not set, to avoid following build failure. CC [M] drivers/gpu/drm/amd/amdgpu/../display/dc/calcs/dcn_calcs.o In file included from ./drivers/gpu/drm/amd/amdgpu/../display/dc/dm_services_types.h:29, from ./drivers/gpu/drm/amd/amdgpu/../display/dc/dm_services.h:37, from drivers/gpu/drm/amd/amdgpu/../display/dc/calcs/dcn_calcs.c:27: drivers/gpu/drm/amd/amdgpu/../display/dc/calcs/dcn_calcs.c: In function 'dcn_bw_apply_registry_override': ./drivers/gpu/drm/amd/amdgpu/../display/dc/os_types.h:64:3: error: implicit declaration of function 'enable_kernel_vsx'; did you mean 'enable_kernel_fp'? [-Werror=implicit-function-declaration] 64 | enable_kernel_vsx(); \ | ^~~~~~~~~~~~~~~~~ drivers/gpu/drm/amd/amdgpu/../display/dc/calcs/dcn_calcs.c:640:2: note: in expansion of macro 'DC_FP_START' 640 | DC_FP_START(); | ^~~~~~~~~~~ ./drivers/gpu/drm/amd/amdgpu/../display/dc/os_types.h:75:3: error: implicit declaration of function 'disable_kernel_vsx'; did you mean 'disable_kernel_fp'? [-Werror=implicit-function-declaration] 75 | disable_kernel_vsx(); \ | ^~~~~~~~~~~~~~~~~~ drivers/gpu/drm/amd/amdgpu/../display/dc/calcs/dcn_calcs.c:676:2: note: in expansion of macro 'DC_FP_END' 676 | DC_FP_END(); | ^~~~~~~~~ cc1: some warnings being treated as errors make[5]: *** [drivers/gpu/drm/amd/amdgpu/../display/dc/calcs/dcn_calcs.o] Error 1 This works because the caller is checking if VSX is available using cpu_has_feature(): #define DC_FP_START() { \ if (cpu_has_feature(CPU_FTR_VSX_COMP)) { \ preempt_disable(); \ enable_kernel_vsx(); \ } else if (cpu_has_feature(CPU_FTR_ALTIVEC_COMP)) { \ preempt_disable(); \ enable_kernel_altivec(); \ } else if (!cpu_has_feature(CPU_FTR_FPU_UNAVAILABLE)) { \ preempt_disable(); \ enable_kernel_fp(); \ } \ When CONFIG_VSX is not selected, cpu_has_feature(CPU_FTR_VSX_COMP) constant folds to 'false' so the call to enable_kernel_vsx() is discarded and the build succeeds. Fixes: 16a9dea110a6 ("amdgpu: Enable initial DCN support on POWER") Cc: stable@vger.kernel.org # v5.6+ Reported-by: Geert Uytterhoeven Reported-by: kernel test robot Signed-off-by: Christophe Leroy [mpe: Incorporate some discussion comments into the change log] Signed-off-by: Michael Ellerman Link: https://lore.kernel.org/r/8d7d285a027e9d21f5ff7f850fa71a2655b0c4af.1615279170.git.christophe.leroy@csgroup.eu Signed-off-by: Greg Kroah-Hartman --- arch/powerpc/include/asm/switch_to.h | 10 ++++++++++ 1 file changed, 10 insertions(+) --- a/arch/powerpc/include/asm/switch_to.h +++ b/arch/powerpc/include/asm/switch_to.h @@ -71,6 +71,16 @@ static inline void disable_kernel_vsx(vo { msr_check_and_clear(MSR_FP|MSR_VEC|MSR_VSX); } +#else +static inline void enable_kernel_vsx(void) +{ + BUILD_BUG(); +} + +static inline void disable_kernel_vsx(void) +{ + BUILD_BUG(); +} #endif #ifdef CONFIG_SPE