Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030530AbWJDNob (ORCPT ); Wed, 4 Oct 2006 09:44:31 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1030572AbWJDNob (ORCPT ); Wed, 4 Oct 2006 09:44:31 -0400 Received: from mail.sf-mail.de ([62.27.20.61]:11416 "EHLO mail.sf-mail.de") by vger.kernel.org with ESMTP id S1030530AbWJDNo3 (ORCPT ); Wed, 4 Oct 2006 09:44:29 -0400 From: Rolf Eike Beer To: Jiri Slaby Subject: Re: [PATCH 3/4] Char: mxser_new, pci_request_region for pci regions Date: Wed, 4 Oct 2006 15:45:16 +0200 User-Agent: KMail/1.9.4 Cc: Andrew Morton , linux-kernel@vger.kernel.org, support@moxa.com.tw References: <83721356982173@wsc.cz> In-Reply-To: <83721356982173@wsc.cz> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart20363266.XNW9DM1qbH"; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-Transfer-Encoding: 7bit Message-Id: <200610041545.22173.eike-kernel@sf-tec.de> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2889 Lines: 85 --nextPart20363266.XNW9DM1qbH Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline Jiri Slaby wrote: > mxser_new, pci_request_region for pci regions > > Use pci_request_region instead of standard request_region for pci device > regions. More checking, simplier use. > > Signed-off-by: Jiri Slaby > > --- > commit 1a717bdb06cef859dfbd426f46ea24a9c740e5c5 > tree 85460f01008e9fa2edea675a73b394c48139df4a > parent d4f99406c592fb7ce2a65645d7c1f98ebe599238 > author Jiri Slaby Sat, 30 Sep 2006 01:20:12 +0200 > committer Jiri Slaby Sat, 30 Sep 2006 01:20:12 > +0200 > > drivers/char/mxser_new.c | 10 ++++------ > 1 files changed, 4 insertions(+), 6 deletions(-) > > diff --git a/drivers/char/mxser_new.c b/drivers/char/mxser_new.c > index dfef9ce..c566cd0 100644 > --- a/drivers/char/mxser_new.c > +++ b/drivers/char/mxser_new.c > @@ -526,8 +526,8 @@ static void __exit mxser_module_exit(voi > pdev =3D mxser_boards[i].pdev; > free_irq(mxser_boards[i].irq, &mxser_boards[i]); > if (pdev !=3D NULL) { /* PCI */ > - release_region(pci_resource_start(pdev, 2), pci_resource_len(pdev, > 2)); - release_region(pci_resource_start(pdev, 3), > pci_resource_len(pdev, 3)); + pci_release_region(pdev, 2); > + pci_release_region(pdev, 3); > pci_dev_put(pdev); > } else { > release_region(mxser_boards[i].ports[0].ioaddr, 8 * > mxser_boards[i].nports); > @@ -627,16 +627,14 @@ static int __init=20 > mxser_get_PCI_conf(int > brd->board_type =3D board_type; > brd->nports =3D mxser_numports[board_type - 1]; > ioaddress =3D pci_resource_start(pdev, 2); > - request_region(pci_resource_start(pdev, 2), pci_resource_len(pdev, 2), > - "mxser(IO)"); > + pci_request_region(pdev, 2, "mxser(IO)"); > > for (i =3D 0; i < brd->nports; i++) > brd->ports[i].ioaddr =3D ioaddress + 8 * i; > > /* vector */ > ioaddress =3D pci_resource_start(pdev, 3); > - request_region(pci_resource_start(pdev, 3), pci_resource_len(pdev, 3), > - "mxser(vector)"); > + pci_request_region(pdev, 3, "mxser(vector)"); > brd->vector =3D ioaddress; > > /* irq */ Correct me if I'm wrong, but that use of ioaddress looks totally wrong to m= e.=20 Isn't there a pci_iomap() or something missing? Eike --nextPart20363266.XNW9DM1qbH Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.2 (GNU/Linux) iD8DBQBFI7ryXKSJPmm5/E4RAn8nAKCC1EoxZ5CLew8lhjK7g9rsJCKyDgCfVl7m lKe50nMtlzlb8Fa/P2ZMsIs= =VVIr -----END PGP SIGNATURE----- --nextPart20363266.XNW9DM1qbH-- - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/