Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp3532435pxf; Mon, 15 Mar 2021 11:39:44 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwS2VGYmhYFbYVNr14uhYfF3ayZkx8ipPg7/FqPYaBpKPtsUlxMb2nPsaGaoPlU3qWCovu4 X-Received: by 2002:a17:906:e2d4:: with SMTP id gr20mr25780553ejb.432.1615833584033; Mon, 15 Mar 2021 11:39:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1615833584; cv=none; d=google.com; s=arc-20160816; b=V6mqczJTcrkd0BXBc+1BDzyZi9a2+2egmbuB/9jvNPfABNoEZS/vc0MmApP72fUYS2 kz2BmVtwn7iYR1QQKWcr6KCahrPdtH1b3/re7mmOnhyQIv7A7oqH6YLrYUYBUCK9QWUx hsMQS4OZxeCT9omTGURH/q32ZDxqO+cJ04QSRmzYNJbTOA0SthpfVwB7igEBL++LJERM 7cx5AFziMir2J0TuMBXBn1YOdH6wxPVWAu69ZNbviaKHD6A8IFkUik83N48BzteC4dOI 5ySycaWIvfZoU4uH64fq5PeAruMkIrp42rUpnSyKz11ir2/HfD46nS0Y03e8qDnrmZrP EobQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:user-agent:references:in-reply-to :subject:cc:to:from:date:content-transfer-encoding:mime-version :dkim-signature; bh=WvXuiNr6/ZH9LeLj3FbJ4cXG+gnUdCJXUawyo6mrnF8=; b=EXKL/4EP8wEwI/nqPn0M+kWeEkhl5U0FNcbyV/iyarcKcMpG5VJ+U3BYWPF1yRAenk GcQ+12XF/m+2kgFz5lMhV/UARL98uAEhm0uzlKEsdZr0UbO1u10InwbXIDifweJ6Gx85 S4+n9UeytuU9WwQzqjL/5XrpWybHU4KP3BlPFq4Yf0J8LVZecoMPHSPRpgZ0YXjhUQzx tPbk6wSSLGo3pW+jfmGbkONM7YF/a6h9uo/y03jYvwILP6PeOjAFUZlShPNTrLXoXOFy 8r8xkUqAWO2nIqVBBANstxHqBuojPjsf5xkLVWTDXMc8CDrxsfkjqPTExXOoZP6dMQX9 sWYA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@walle.cc header.s=mail2016061301 header.b=FDedj9di; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id u5si11592402ejt.35.2021.03.15.11.39.22; Mon, 15 Mar 2021 11:39:44 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@walle.cc header.s=mail2016061301 header.b=FDedj9di; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235692AbhCORNk (ORCPT + 99 others); Mon, 15 Mar 2021 13:13:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59006 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235658AbhCORNW (ORCPT ); Mon, 15 Mar 2021 13:13:22 -0400 Received: from ssl.serverraum.org (ssl.serverraum.org [IPv6:2a01:4f8:151:8464::1:2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3A6E0C06174A; Mon, 15 Mar 2021 10:13:22 -0700 (PDT) Received: from ssl.serverraum.org (web.serverraum.org [172.16.0.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ssl.serverraum.org (Postfix) with ESMTPSA id 343E022234; Mon, 15 Mar 2021 18:13:20 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=walle.cc; s=mail2016061301; t=1615828400; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WvXuiNr6/ZH9LeLj3FbJ4cXG+gnUdCJXUawyo6mrnF8=; b=FDedj9diIvD/llhNi5mdiIowvQEiqOlJyODlAvBfiNTOJY4AtjHMVm5PejQE7LXWxdaQ1w +qgXPv1Yllm/Mktd2tWNeVVy42rVvx8kreG52pzZq4uWZZ4u+bY2ol8GegZmiE28BlTzMd PWmUz3fRLEO4VhGrks7HEgmxtsyOnoU= MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Mon, 15 Mar 2021 18:13:20 +0100 From: Michael Walle To: Sameer Pujar Cc: Mark Brown , alsa-devel@alsa-project.org, devicetree@vger.kernel.org, jonathanh@nvidia.com, kuninori.morimoto.gx@renesas.com, linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org, robh@kernel.org, sharadg@nvidia.com, thierry.reding@gmail.com Subject: Re: [PATCH 1/3] ASoC: simple-card-utils: Fix device module clock In-Reply-To: <3b3c5aea-60bc-d7bd-9ae6-5e890782b2e8@nvidia.com> References: <20210311161558.GG4962@sirena.org.uk> <20210312113544.GB5348@sirena.org.uk> <6ed28bb5330879b1919aced5174f319f@walle.cc> <20210312120456.GD5348@sirena.org.uk> <684332700f8be9f77348a510eb6eba22@walle.cc> <20210312134642.GF5348@sirena.org.uk> <8cdf1cfa971945792b509a687a4de735@walle.cc> <6af6439c-bdb8-cd0f-635d-069040ba5b65@nvidia.com> <20210315153925.GC4595@sirena.org.uk> <3b3c5aea-60bc-d7bd-9ae6-5e890782b2e8@nvidia.com> User-Agent: Roundcube Webmail/1.4.11 Message-ID: <67ca8858be63a07e3549f73afcc08437@walle.cc> X-Sender: michael@walle.cc Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am 2021-03-15 18:10, schrieb Sameer Pujar: >>> Yes this is a problem, unfortunately I missed checking some of the >>> simple-card examples. I wonder we should be specifically looking for >>> "mclk" >>> clock here. >> That would definitely help mitigate the problem but I really think >> it's >> cleaner and safer to just push this down to set_sysclk(). > > Understand now. I will push patches based on this. Thanks for the > details. Please keep me on CC, I'm not subscribed to the sound/alsa mailinglist. Thanks, -michael