Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 15 Mar 2021 18:23:59 +0100
From:   Jiri Olsa <jolsa@redhat.com>
To:     "Denys Zagorui -X (dzagorui - GLOBALLOGIC INC at Cisco)" 
        <dzagorui@cisco.com>
Cc:     "peterz@infradead.org" <peterz@infradead.org>,
        "mingo@redhat.com" <mingo@redhat.com>,
        "acme@kernel.org" <acme@kernel.org>,
        "mark.rutland@arm.com" <mark.rutland@arm.com>,
        "alexander.shishkin@linux.intel.com" 
        <alexander.shishkin@linux.intel.com>,
        "namhyung@kernel.org" <namhyung@kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] perf: build reproducibility improvements
Message-ID: <YE+YL4Rzsj77TJmS@krava>
References: <20210312151700.79714-1-dzagorui@cisco.com>
 <YE9TAY05BtXbuHxq@krava>
 <BY5PR11MB40246F1699546B84817D826AD96C9@BY5PR11MB4024.namprd11.prod.outlook.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <BY5PR11MB40246F1699546B84817D826AD96C9@BY5PR11MB4024.namprd11.prod.outlook.com>
Precedence: bulk

On Mon, Mar 15, 2021 at 04:45:55PM +0000, Denys Zagorui -X (dzagorui - GLOBALLOGIC INC at Cisco) wrote:
> > Makefile.config:1026: No openjdk development package found, please install JDK package, e.g. openjdk-8-jdk, java-1.8.0-openjdk-devel
> > cp: '/home/jolsa/kernel/linux-perf/tools/perf/Documentation/tips.txt' and 'Documentation/tips.txt' are the same file
> >  BISON    util/parse-events-bison.c
> > bison: unrecognized option '--file-prefix-map=='
> 
> I thought that this flag was added in v3.6.3 because in git history next tag after corresponding bison patch was v3.6.3. But this is not true.
> 
> > hum, do we actualy want this? I think we want the exact path
> > we used for compilation, no? what's the benefit?
> ...
> > same here, we want to be sure to use the python path
> > from the exact build laction no?
> 
> This patch makes perf build more deterministic. This means that if we build perf on two different
> build machines from exactly the same sources we will have absolutely identical binaries. To achieve
> this absolute paths should not be stored in resulting binary. That is why i tried to determine those paths
> in runtime instead of storing them in binary compile time.
> There is ongoing project
> https://reproducible-builds.org/reports/2021-02/ project
> Kernel already achieved this
> https://www.kernel.org/doc/html/latest/kbuild/reproducible-builds.html

ok, haven't heard about this

> 
> This patch doesn't make perf 100% reproducible. There is one more known issue with pmu event ordering
> https://bugzilla.opensuse.org/show_bug.cgi?id=1180882

nice, the reason of pmu events is in random fashion,
so the resulting binary differs.. perhaps we could
use scandir with sort instead

jirka