Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210312154357.1561730-1-sebastian.reichel@collabora.com> <20210312154357.1561730-9-sebastian.reichel@collabora.com>
In-Reply-To: <20210312154357.1561730-9-sebastian.reichel@collabora.com>
From:   Rob Herring <robh+dt@kernel.org>
Date:   Mon, 15 Mar 2021 12:24:09 -0600
Message-ID: <CAL_Jsq+i=sB7nDzBeF3nRa8FuM_8v=P2SMXQ5XNmuP3b615CKg@mail.gmail.com>
Subject: Re: [PATCH 08/38] dt-bindings: power: supply: bq24735: Convert to DT
 schema format
To:     Sebastian Reichel <sebastian.reichel@collabora.com>
Cc:     Sebastian Reichel <sre@kernel.org>,
        "open list:THERMAL" <linux-pm@vger.kernel.org>,
        devicetree@vger.kernel.org,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Collabora Kernel ML <kernel@collabora.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Fri, Mar 12, 2021 at 8:44 AM Sebastian Reichel
<sebastian.reichel@collabora.com> wrote:
>
> Convert the binding to DT schema format.
>
> Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
> ---
>  .../bindings/power/supply/bq24735.yaml        | 88 +++++++++++++++++++
>  .../bindings/power/supply/ti,bq24735.txt      | 39 --------
>  2 files changed, 88 insertions(+), 39 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/power/supply/bq24735.yaml
>  delete mode 100644 Documentation/devicetree/bindings/power/supply/ti,bq24735.txt
>
> diff --git a/Documentation/devicetree/bindings/power/supply/bq24735.yaml b/Documentation/devicetree/bindings/power/supply/bq24735.yaml
> new file mode 100644
> index 000000000000..8a3a31ada128
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/power/supply/bq24735.yaml
> @@ -0,0 +1,88 @@
> +# SPDX-License-Identifier: GPL-2.0
> +# Copyright (C) 2021 Sebastian Reichel
> +%YAML 1.2
> +---
> +$id: "http://devicetree.org/schemas/power/supply/bq24735.yaml#"
> +$schema: "http://devicetree.org/meta-schemas/core.yaml#"
> +
> +title: Binding for TI BQ24735 Li-Ion Battery Charger
> +
> +maintainers:
> +  - Sebastian Reichel <sre@kernel.org>
> +
> +allOf:
> +  - $ref: power-supply.yaml#
> +
> +properties:
> +  compatible:
> +    const: ti,bq24735
> +
> +  reg:
> +    maxItems: 1
> +
> +  interrupts:
> +    description: AC adapter plug event interrupt
> +    maxItems: 1
> +
> +  ti,ac-detect-gpios:
> +    maxItems: 1
> +    description: |
> +      This GPIO is optionally used to read the AC adapter status. This is a Host GPIO
> +      that is configured as an input and connected to the ACOK pin on the bq24735.
> +      Note: for backwards compatibility reasons, the GPIO must be active on AC adapter
> +      absence despite ACOK being active (high) on AC adapter presence.
> +
> +  ti,charge-current:
> +    $ref: /schemas/types.yaml#/definitions/uint32
> +    description: |
> +      Used to control and set the charging current.
> +      This value must be between 128mA and 8.128A with a 64mA step resolution.
> +      The POR value is 0x0000h. This number is in mA (e.g. 8192).
> +      See spec for more information about the ChargeCurrent (0x14h) register.
> +
> +  ti,charge-voltage:
> +    $ref: /schemas/types.yaml#/definitions/uint32
> +    description: |
> +      Used to control and set the charging voltage.
> +      This value must be between 1.024V and 19.2V with a 16mV step resolution.
> +      The POR value is 0x0000h. This number is in mV (e.g. 19200).
> +      See spec for more information about the ChargeVoltage (0x15h) register.
> +
> +  ti,input-current:
> +    $ref: /schemas/types.yaml#/definitions/uint32
> +    description: |
> +      Used to control and set the charger input current.
> +      This value must be between 128mA and 8.064A with a 128mA step resolution.
> +      The POR value is 0x1000h. This number is in mA (e.g. 8064).
> +      See the spec for more information about the InputCurrent (0x3fh) register.
> +
> +  ti,external-control:
> +    type: boolean
> +    description: |
> +      Indicates that the charger is configured externally and that the host should not
> +      attempt to enable/disable charging or set the charge voltage/current.
> +
> +  poll-interval:
> +    description: |
> +      If 'interrupts' is not specified, poll AC adapter presence with this interval (milliseconds).

Needs a type.