Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210311130328.2859337-1-oberpar@linux.ibm.com>
 <202103120329.VU4uJ0yZ-lkp@intel.com> <CAHk-=whmwEJ-4tGamqOCw4BDJ-yjYrLRYxaFq5YurVc-XXO+hg@mail.gmail.com>
 <db88186a-d6af-33c9-f1fb-10b673b8fdd6@intel.com> <CAHk-=wji=we4HQ2m6Z=fnUSM4UW8+X0eTnb9YPGYdcTqpVAL2Q@mail.gmail.com>
 <09373c3d-73e8-933a-24ad-5c4ba4fdc615@intel.com>
In-Reply-To: <09373c3d-73e8-933a-24ad-5c4ba4fdc615@intel.com>
From:   Linus Torvalds <torvalds@linux-foundation.org>
Date:   Mon, 15 Mar 2021 12:12:41 -0700
Message-ID: <CAHk-=wg0DY=cE-6Tjp_Dt32UC6XtMZBa0Rr2GqkK=Sh9HE=5kQ@mail.gmail.com>
Subject: Re: [kbuild-all] Re: [PATCH] gcov: fail build on gcov_info size mismatch
To:     Rong Chen <rong.a.chen@intel.com>
Cc:     kernel test robot <lkp@intel.com>,
        Peter Oberparleiter <oberpar@linux.ibm.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        kbuild-all@lists.01.org,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Sun, Mar 14, 2021 at 7:32 PM Rong Chen <rong.a.chen@intel.com> wrote:
>
> It can be reproduced with '-a' option in dash:

Oh, ok. That kind of explains it.

'dash' is trash. Please somebody make a bug report.

>      $ a="!"
>      $ [ "$a" = ".size" ]
>      $ [ "$a" = ".size" -a "$b" = ".LPBX0," ]
>      sh: 2: [: =: unexpected operator

This is 100% a dash bug. There is no question what-so-ever about it.
This is not some kind of "POSIX is ambiguous", or "the handling of
'-a' is complicated".

It's simply just that dash is buggy.

>  While dash supports most uses of the -a and -o options, they have
> very confusing semantics even in bash and are best avoided.

No, they have perfectly sane semantics in bash, and in POSIX.

See

     https://pubs.opengroup.org/onlinepubs/9699919799/utilities/test.html

and there is absolutely zero question that bash does this correctly,
and dash does not.

But yes, it seems to be easy to work around, but still - could some
Ubuntu person please open a bug report on dash?

               Linus