Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Himanshu Madhani <himanshu.madhani@oracle.com>
To:     Wang Qing <wangqing@vivo.com>
CC:     Nilesh Javali <njavali@marvell.com>,
        GR-QLogic-Storage-Upstream <GR-QLogic-Storage-Upstream@marvell.com>,
        "James E.J. Bottomley" <jejb@linux.ibm.com>,
        Martin Petersen <martin.petersen@oracle.com>,
        "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] scsi: qla2xxx: use dma_pool_zalloc instead
Thread-Topic: [PATCH] scsi: qla2xxx: use dma_pool_zalloc instead
Thread-Index: AQHXF7J0CTLvBa0mCk2OoB3Gtpj/WqqFeFQA
Date:   Mon, 15 Mar 2021 19:46:18 +0000
Message-ID: <5A7ADAED-6A7C-4855-A6AB-6786896BDE03@oracle.com>
References: <1615603275-14303-1-git-send-email-wangqing@vivo.com>
In-Reply-To: <1615603275-14303-1-git-send-email-wangqing@vivo.com>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-ID: <114A3A8218709749978BC343658B4E62@namprd10.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 2e9121c5-e891-4294-d642-08d8e7eb0065
X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Mar 2021 19:46:18.2190
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: PKQWvZLJrGpUUJQ86PjncO8RKWb9G3pKfYuOmcsjAprJRZFVc9LuK8ecCKOGpgRw+e+aKq0utt2BxMddrgNQ75LQcABPm7QjNjO0hk+du58=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR10MB4537
X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9924 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 spamscore=0 bulkscore=0
 malwarescore=0 adultscore=0 mlxscore=0 mlxlogscore=999 phishscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000
 definitions=main-2103150132
X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9924 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 impostorscore=0
 malwarescore=0 adultscore=0 mlxscore=0 clxscore=1011 mlxlogscore=999
 lowpriorityscore=0 phishscore=0 priorityscore=1501 spamscore=0 bulkscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000
 definitions=main-2103150132
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> On Mar 12, 2021, at 8:41 PM, Wang Qing <wangqing@vivo.com> wrote:
>=20
> use dma_pool_zalloc instead of dma_pool_alloc and memset
>=20
> Signed-off-by: Wang Qing <wangqing@vivo.com>
> ---
> drivers/scsi/qla2xxx/qla_os.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>=20
> diff --git a/drivers/scsi/qla2xxx/qla_os.c b/drivers/scsi/qla2xxx/qla_os.=
c
> index 0743925..ac5e954
> --- a/drivers/scsi/qla2xxx/qla_os.c
> +++ b/drivers/scsi/qla2xxx/qla_os.c
> @@ -4238,11 +4238,10 @@ qla2x00_mem_alloc(struct qla_hw_data *ha, uint16_=
t req_len, uint16_t rsp_len,
>=20
> 	/* Get consistent memory allocated for Special Features-CB. */
> 	if (IS_QLA27XX(ha) || IS_QLA28XX(ha)) {
> -		ha->sf_init_cb =3D dma_pool_alloc(ha->s_dma_pool, GFP_KERNEL,
> +		ha->sf_init_cb =3D dma_pool_zalloc(ha->s_dma_pool, GFP_KERNEL,
> 						&ha->sf_init_cb_dma);
> 		if (!ha->sf_init_cb)
> 			goto fail_sf_init_cb;
> -		memset(ha->sf_init_cb, 0, sizeof(struct init_sf_cb));
> 		ql_dbg_pci(ql_dbg_init, ha->pdev, 0x0199,
> 			   "sf_init_cb=3D%p.\n", ha->sf_init_cb);
> 	}
> --=20
> 2.7.4
>=20

Looks Good.

Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>

--
Himanshu Madhani	 Oracle Linux Engineering