Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp3644110pxf; Mon, 15 Mar 2021 14:49:10 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwu2JzdLCRmftlGqeibcYE21wm3bQ4BbgpKOXxEhbTOAhYlbOWN6Qk9LtPhPVTMQ1vKsL2k X-Received: by 2002:aa7:d347:: with SMTP id m7mr31643647edr.260.1615844950268; Mon, 15 Mar 2021 14:49:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1615844950; cv=none; d=google.com; s=arc-20160816; b=KwISElTS2xT6/h0bht+d9efqsrlfvD4OiBGzrrOofr2Rnkf5rfpakNiHEE7N2Nq+U0 d9iN8qDUM6zhP8JxpEpw4++S7GJW+1xxqH50aTaV5p6HfsxDeLQd8D+C+wyRQbTqaRyO WKEcWvuZ0v7TJ5x/XeiJwLjOjN+P1hu0rLJL+gPLb6sLfuC9YlU4NfnycfcynpTlAmxL IknGDH7LqzTwg5mgi+8lz2d8zAVkUyfpuLQcYqlBbsod/NOlebQ3fgDNZ7P2bz6K9QE3 Y/vAh8ojSYAMyMFNbel7yDO9xeQ+sIKuB6QTBM/kO3CAwo77PP8o02DeZsbTNPf+mOMj +EBg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=Dgs7psrYGQL+Unq74XNuKkHEyznQ/Y9spvfJtFMnHM0=; b=zENOGQQZ06NKzfFdsxNFpEzmTxIhoP6gFbwF4sxHzUkgQjBBfj5BuISOw144SsQ723 Ew7WaTB6+Zntuy2kJtICiIRQ5bgDMul1+++cBbWkdzSFEPLzqw53KFYIy6+pAG6Tz164 SIittlee57ndn6/h6720TDsTVWXX2u6HY9wsXiV9CErU9ER8oc5n4VFbeEfi00xZQ993 aQqS51Wj/n99wcJArqWufeyQxR9TRGdZ5MBneTsrVDMTDRiW0oBDUGHOYABPmpi/rs+J 1RShShopkXNTIXZ9udDBV0vfj26mzTg85KtYA9PorlzbyXQkMOP5b6wYD2FKwkuE+HpZ ruYw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=Xn91PDhQ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id eb10si11932844ejc.273.2021.03.15.14.48.48; Mon, 15 Mar 2021 14:49:10 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=Xn91PDhQ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233518AbhCOUNr (ORCPT + 99 others); Mon, 15 Mar 2021 16:13:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41498 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230476AbhCOUNn (ORCPT ); Mon, 15 Mar 2021 16:13:43 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E49E4C06174A; Mon, 15 Mar 2021 13:13:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=Dgs7psrYGQL+Unq74XNuKkHEyznQ/Y9spvfJtFMnHM0=; b=Xn91PDhQW1z2E6otmUZO98NrOc dGQuvQtdIFHzaK78AECvW89GDGCnqz6Mb73pf2FwpXStbziLATMEQqx18km8D8VXKb0WqFhCLtnbs yndGwM1A9yCPAxlBCJmppSBPqs5ZKtf4C1kJ14v3WuADUiyQpmhMXIiwWRJPhCxFZW7DtgRqNrAAS gZgjW01d8rJQrGiBCd4+sI8jZQoS2cStXvR6ydzfF3QLvVaHHXSuJUlMFmvT2is+nIzP2S6dG7hE5 3LKK7hU58dHCBZLIuyfQnyZ49coNSjOJyF/orHsg++HZoSg4bEYEaGF0aFSnv8YoH0AHSkyri1sh4 cRiwACuQ==; Received: from willy by casper.infradead.org with local (Exim 4.94 #2 (Red Hat Linux)) id 1lLtal-000i0L-8i; Mon, 15 Mar 2021 20:13:35 +0000 Date: Mon, 15 Mar 2021 20:13:31 +0000 From: Matthew Wilcox To: Matteo Croce Cc: linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Lennart Poettering , Luca Boccassi , Jens Axboe , Alexander Viro , Damien Le Moal , Tejun Heo , Javier =?iso-8859-1?Q?Gonz=E1lez?= , Niklas Cassel , Johannes Thumshirn , Hannes Reinecke , Ajay Joshi , Christoph Hellwig , Matias Bjorling , Hans Holmberg , Dmitry Fomichev , Keith Busch , "Dmitry V. Levin" Subject: Re: [PATCH -next 2/5] block: add ioctl to read the disk sequence number Message-ID: <20210315201331.GA2577561@casper.infradead.org> References: <20210315200242.67355-1-mcroce@linux.microsoft.com> <20210315200242.67355-3-mcroce@linux.microsoft.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210315200242.67355-3-mcroce@linux.microsoft.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 15, 2021 at 09:02:39PM +0100, Matteo Croce wrote: > +++ b/include/uapi/linux/fs.h > @@ -184,6 +184,7 @@ struct fsxattr { > #define BLKSECDISCARD _IO(0x12,125) > #define BLKROTATIONAL _IO(0x12,126) > #define BLKZEROOUT _IO(0x12,127) > +#define BLKGETDISKSEQ _IOR(0x12,128,__u64) > /* > * A jump here: 130-131 are reserved for zoned block devices > * (see uapi/linux/blkzoned.h) Not your bug, but this is now 130-136. +cc all the people who signed off on the commits that added those ioctl numbers without updating this comment. Perhaps one of them will figure out how to stop this happening in future.