Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: YrwvL1JGinb5aTqyBVHsmiIb3ozSXItBh2pDav71xnxNM3CRZO5SM33xE0cQQw3zxLADIPe4pl
 sAmIstFNE97FCbDOCwkwngPxzEis8LAWyO5oqV7GNPniviS3nOhR9VNSwgcmaG5Sp9ZdsaF/E4
 8GYwQMuTouF9n+cpVD5BD/d7urEAg4DbwFQIci5g2fb5R0cFtSLvL1dwbbENs3IsjqSWX3KK/V
 649kBb9djr9GYMLWCnKK8zBPojN5yGgPyhT3iRtVpu3TgNXYAm7MJ6Huko+PPrv4TV3ZxXOLA+
 4cA=
From:   Damien Le Moal <Damien.LeMoal@wdc.com>
To:     Matthew Wilcox <willy@infradead.org>,
        Matteo Croce <mcroce@linux.microsoft.com>
CC:     "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
        "linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Lennart Poettering <lennart@poettering.net>,
        Luca Boccassi <bluca@debian.org>, Jens Axboe <axboe@kernel.dk>,
        Alexander Viro <viro@zeniv.linux.org.uk>,
        Tejun Heo <tj@kernel.org>,
        =?iso-8859-1?Q?Javier_Gonz=E1lez?= <javier@javigon.com>,
        Niklas Cassel <Niklas.Cassel@wdc.com>,
        Johannes Thumshirn <Johannes.Thumshirn@wdc.com>,
        Hannes Reinecke <hare@suse.de>,
        Ajay Joshi <Ajay.Joshi@wdc.com>,
        Christoph Hellwig <hch@lst.de>,
        Matias Bjorling <Matias.Bjorling@wdc.com>,
        Hans Holmberg <Hans.Holmberg@wdc.com>,
        Dmitry Fomichev <Dmitry.Fomichev@wdc.com>,
        Keith Busch <kbusch@kernel.org>,
        "Dmitry V. Levin" <ldv@altlinux.org>
Subject: Re: [PATCH -next 2/5] block: add ioctl to read the disk sequence
 number
Thread-Topic: [PATCH -next 2/5] block: add ioctl to read the disk sequence
 number
Thread-Index: AQHXGdZHtEi8UCY5QU2YIkxHX6s5Yw==
Date:   Mon, 15 Mar 2021 20:17:43 +0000
Message-ID: <BL0PR04MB6514FC8F5D34120DFFF727BCE76C9@BL0PR04MB6514.namprd04.prod.outlook.com>
References: <20210315200242.67355-1-mcroce@linux.microsoft.com>
 <20210315200242.67355-3-mcroce@linux.microsoft.com>
 <20210315201331.GA2577561@casper.infradead.org>
Accept-Language: en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 4ee341a8-a551-4468-3169-08d8e7ef642b
X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Mar 2021 20:17:43.4447
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: oJqyGRH1BNI6BCrCB7T+39Y1T3509nnyqi/WSqGQjTAY2JeQGasZv8bbU575zu5FxHHs9dCCDoz+wcApyMzbQw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR04MB6991
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 2021/03/16 5:14, Matthew Wilcox wrote:=0A=
> On Mon, Mar 15, 2021 at 09:02:39PM +0100, Matteo Croce wrote:=0A=
>> +++ b/include/uapi/linux/fs.h=0A=
>> @@ -184,6 +184,7 @@ struct fsxattr {=0A=
>>  #define BLKSECDISCARD _IO(0x12,125)=0A=
>>  #define BLKROTATIONAL _IO(0x12,126)=0A=
>>  #define BLKZEROOUT _IO(0x12,127)=0A=
>> +#define BLKGETDISKSEQ _IOR(0x12,128,__u64)=0A=
>>  /*=0A=
>>   * A jump here: 130-131 are reserved for zoned block devices=0A=
>>   * (see uapi/linux/blkzoned.h)=0A=
> =0A=
> Not your bug, but this is now 130-136.=0A=
> =0A=
> +cc all the people who signed off on the commits that added those ioctl=
=0A=
> numbers without updating this comment.  Perhaps one of them will figure=
=0A=
> out how to stop this happening in future.=0A=
> =0A=
=0A=
Indeed. Will be more careful :)=0A=
And send a patch to fix this.=0A=
=0A=
Thanks !=0A=
=0A=
-- =0A=
Damien Le Moal=0A=
Western Digital Research=0A=