Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Jonathan Corbet <corbet@lwn.net>
To:     Gao Xiang <hsiangkao@redhat.com>, linux-doc@vger.kernel.org
Cc:     linux-kernel@vger.kernel.org, Gao Xiang <hsiangkao@redhat.com>,
        Matthias Kaehlcke <mka@chromium.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Zefan Li <lizefan.x@bytedance.com>
Subject: Re: [PATCH] Documentation: sysrq: update description about sysrq crash
In-Reply-To: <20210309191550.3955601-1-hsiangkao@redhat.com>
References: <20210309191550.3955601-1-hsiangkao@redhat.com>
Date:   Mon, 15 Mar 2021 14:23:39 -0600
Message-ID: <87zgz4yxmc.fsf@meer.lwn.net>
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk

Gao Xiang <hsiangkao@redhat.com> writes:

> After commit 8341f2f222d7 ("sysrq: Use panic() to force a crash"),
> a crash was not generated by dereferencing a NULL pointer anymore.
>
> Let's update documentation as well to make it less misleading.
>
> Cc: Matthias Kaehlcke <mka@chromium.org>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: Jonathan Corbet <corbet@lwn.net>
> Cc: Zefan Li <lizefan.x@bytedance.com>
> Signed-off-by: Gao Xiang <hsiangkao@redhat.com>
> ---
>  Documentation/admin-guide/sysrq.rst | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/admin-guide/sysrq.rst b/Documentation/admin-guide/sysrq.rst
> index 67dfa4c29093..60ce5f5ebab6 100644
> --- a/Documentation/admin-guide/sysrq.rst
> +++ b/Documentation/admin-guide/sysrq.rst
> @@ -90,8 +90,8 @@ Command	    Function
>  ``b``	    Will immediately reboot the system without syncing or unmounting
>              your disks.
>  
> -``c``	    Will perform a system crash by a NULL pointer dereference.
> -            A crashdump will be taken if configured.
> +``c``	    Will perform a system crash and a crashdump will be taken
> +            if configured.

Makes sense. Applied, thanks.

jon