Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp3650667pxf; Mon, 15 Mar 2021 15:02:08 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwdRVdisFRQWNSxEIo7F+KAzYgOm+PcsG7DMH4G5BeyKxj5d/+t4q1pDxp5Apnvbul3gSyf X-Received: by 2002:a05:6402:38f:: with SMTP id o15mr31923505edv.361.1615845728079; Mon, 15 Mar 2021 15:02:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1615845728; cv=none; d=google.com; s=arc-20160816; b=ymlHK8gK/LbGTi1wBTewha2r22G1et1ixQ92l7NMErMF+0EaTG7l6dPG6lsYJsnMAv T3LEln6Y9huHldZBIWsi0ZPR28179cPV81EsJNs2x2Nyvhmgh2o3kkR2AA5XxE8Fv0T+ 3AxlynrOjR0QleaECavWCCUlowK91Em/3c3g1Dd3KUop/BMdjMWXmADHVttb+IaZtuF8 HXHNgmRfclYn2B4uNMlGPHmI3+v+lou8AO9gNa59jJrXwNCGB9gwul3aoyMDHYUwifxC j3RpAF9dseWIhqjilFbbA2XU3WdOZfMpuM5ShBLhpaL9jP4Li3WbhJg6tRd4ubsZr9+9 QvBw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date :dkim-signature; bh=qkdqntrkesd0zsgt86ODqpue66pp2ATokoiM4RMTzrY=; b=DUNqAHmD2X4/LZ1aveDGVITzfUlomN7DpJiFg86J07L/Ary+rNMvSuxNzBBImcPQ/v TxfUAFiU0f9WDZJ6VsW/0AxbK2EYFxqyGbJ3iWzQ8rL3npw/XoEMvNGIZMZIKrVHFsRL 6ubB7DpMRahhiGxURMCfg6RarY/GEozqLTzlPAcwDckgbmjI59d8ShYB1b4dkRvuaWoB kobwi8vzWIs6/rLrlghp7rrXA6MYKdofDUbO9MGOTzWNdvsaohAcFSImo2rxW9Dn1I7/ R1r4qQxFzBMyn9Tp/piz4oEdSEAwcYilyL0MtT60KLkOfVZLyDLciUv3mOWGwqJYaowK rq+A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=NvgtQrDm; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id g23si11192503ejx.623.2021.03.15.15.01.44; Mon, 15 Mar 2021 15:02:08 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=NvgtQrDm; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233269AbhCOVju (ORCPT + 99 others); Mon, 15 Mar 2021 17:39:50 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:30829 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233131AbhCOVjn (ORCPT ); Mon, 15 Mar 2021 17:39:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1615844382; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qkdqntrkesd0zsgt86ODqpue66pp2ATokoiM4RMTzrY=; b=NvgtQrDmcJyfJMNU3KYSyE4hGsbmiCrw3ozf8fUO+lwYPc07y8i46qrYfwdUaxHJSNF3d3 pplk3G//HavPEP1+W491yo2nipqIJVocsZyoAetRhnp3vzwIcw93ZZ9lT83jOIO0kVvOoj 58K0z5i9zxdp0yzqkBz4zEor5HfPu2s= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-194-Sj3oSMX9MzyFVnnvkG8hOQ-1; Mon, 15 Mar 2021 17:39:39 -0400 X-MC-Unique: Sj3oSMX9MzyFVnnvkG8hOQ-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id C52CF87A83A; Mon, 15 Mar 2021 21:39:37 +0000 (UTC) Received: from localhost (unknown [10.10.110.28]) by smtp.corp.redhat.com (Postfix) with ESMTP id A83145C3E6; Mon, 15 Mar 2021 21:39:34 +0000 (UTC) Date: Mon, 15 Mar 2021 14:39:33 -0700 (PDT) Message-Id: <20210315.143933.939938434416308507.davem@redhat.com> To: cristian.ciocaltea@gmail.com Cc: andrew@lunn.ch, kuba@kernel.org, robh+dt@kernel.org, afaerber@suse.de, mani@kernel.org, p.zabel@pengutronix.de, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-actions@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 2/3] net: ethernet: actions: Add Actions Semi Owl Ethernet MAC driver From: David Miller In-Reply-To: References: Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Cristian Ciocaltea Date: Mon, 15 Mar 2021 13:29:17 +0200 > + > +#define DEFAULT_MSG_ENABLE (NETIF_MSG_DRV | NETIF_MSG_PROBE | NETIF_MSG_LINK) > +static int debug = -1; > +module_param(debug, int, 0); > +MODULE_PARM_DESC(debug, "Debug level (0=none,...,16=all)"); Module parameters are strongly discouraged in networking drivers, pplease delete this ad just pass the default to netif_mdg_init(), thanks!