Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp3706860pxf; Mon, 15 Mar 2021 16:50:57 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxqdh2QQJlESykHRT5ox/9NGsejRinEI9gDei0/k6CE4U8Sc5iohtrjN24MDnk1hTYsgVKo X-Received: by 2002:a17:906:bcc7:: with SMTP id lw7mr14953197ejb.209.1615852257451; Mon, 15 Mar 2021 16:50:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1615852257; cv=none; d=google.com; s=arc-20160816; b=ZqIYivyEJNI8ZU+IVjiRIyJ3Mdm8hM47+Wup6f0nQKfIBuStMvMJcaWCB6BJYP5n5q H8BpiujWPvGqaVkln2QdVBO8X6ybF1hEhICyHt6mgEzma6sB5g/6IQjYe1cuk+WxmkTj r8vP11gYtcSzaQzXWIDriHbMaD6dGG9FUeBDn0cQiN87TTntMDk1Yhu7qWx7Dl1KpPvs 3uOE9xgCN6beCf2Q/VisFfkg/pKLWWgGgN79pMYDYwLL7haOlsufdDiI3a0dXNB6oZyY cxAA7rcfv0PUp/w4ZayP2BGtr77VkkOZXd48p0dhl0Dxh1Q1/vcq/Uf6FtjKvemkFCCo gfKg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:organization:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :ironport-sdr:ironport-sdr; bh=EcC6j1ihte1G+2VSCqTWeOrNiL/Tml+pHlGJQEpJv8U=; b=nmhUhMwUPMg6iT3sctrTRE7MQMSLGimHmspkWDJxrQR/3Shv4IkaHygFIj/KZ33QMz CfDkrJMopTcRnHZAh5qyed4CuzPRAEOJ/NJ8171a0dqzOGV7SN9oAI3KDWCqGj0O8WLO ZuAAfksoT3zgE6A3t/q381oFgOvi9PmqwdziDrDr1KPYeSQ+FDDxAcWtroo0yeCN8opq 8KtL82WvA3JcSjFk5mYBFxzR3FQ0yItAybFeFJNdjA2GYEuewgXZJjly8oKsnS6qEG6V 3+C6YH/vuzWBEytEPxF18/cD0iSWDsgDrz2G0pDS7jzbFAwO1tMajMjBT41+mVQC6xbn wKnA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id f16si12173697eds.608.2021.03.15.16.50.34; Mon, 15 Mar 2021 16:50:57 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232714AbhCOSuJ (ORCPT + 99 others); Mon, 15 Mar 2021 14:50:09 -0400 Received: from mga09.intel.com ([134.134.136.24]:11157 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231956AbhCOSth (ORCPT ); Mon, 15 Mar 2021 14:49:37 -0400 IronPort-SDR: emUrZaC6HZp69aZ/YK4wCxOfrL0aCaQIxWDJlI6YP6OR3E4rerI54d3SX2O4bO4d/O7tSV7zue qFGQPwkWFBdA== X-IronPort-AV: E=McAfee;i="6000,8403,9924"; a="189229645" X-IronPort-AV: E=Sophos;i="5.81,251,1610438400"; d="scan'208";a="189229645" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Mar 2021 11:49:29 -0700 IronPort-SDR: smpqX6XBZLNQYi/uw+E1RhoCqVRlIQTe4xxlC7aKIhngCJU2UJgP2yevO+ubIdKUp6wShF5cHb MloBDap+/Rtw== X-IronPort-AV: E=Sophos;i="5.81,251,1610438400"; d="scan'208";a="511133334" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by fmsmga001-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Mar 2021 11:49:26 -0700 Received: from andy by smile with local (Exim 4.94) (envelope-from ) id 1lLsHK-00Ckak-Pu; Mon, 15 Mar 2021 20:49:22 +0200 Date: Mon, 15 Mar 2021 20:49:22 +0200 From: Andy Shevchenko To: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Linus Walleij , Bartosz Golaszewski Subject: Re: [PATCH v1 1/1] gpiolib: Assign fwnode to parent's if no primary one provided Message-ID: References: <20210315184430.17755-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210315184430.17755-1-andriy.shevchenko@linux.intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 15, 2021 at 08:44:30PM +0200, Andy Shevchenko wrote: > In case when the properties are supplied in the secondary fwnode > (for example, built-in device properties) the fwnode pointer left > unassigned. This makes unable to retrieve them. > > Assign fwnode to parent's if no primary one provided. Bart, I missed to add you as a Reporter, feel free to do that or tell me I'll send a v2. > Fixes: 7cba1a4d5e16 ("gpiolib: generalize devprop_gpiochip_set_names() for device properties") > Fixes: 2afa97e9868f ("gpiolib: Read "gpio-line-names" from a firmware node") > Signed-off-by: Andy Shevchenko Side note: The patch done in this way to avoid conflicts with the future (for-next) code once it will be in upstream (v5.12-rcX). -- With Best Regards, Andy Shevchenko