Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210312154357.1561730-1-sebastian.reichel@collabora.com>
In-Reply-To: <20210312154357.1561730-1-sebastian.reichel@collabora.com>
From:   Rob Herring <robh+dt@kernel.org>
Date:   Mon, 15 Mar 2021 13:44:02 -0600
Message-ID: <CAL_JsqKL9VojmrygoARW6jSzBiyJDqBDjv-z8R04yf4VGdhhBA@mail.gmail.com>
Subject: Re: [PATCH 00/38] Convert power-supply DT bindings to YAML
To:     Sebastian Reichel <sebastian.reichel@collabora.com>
Cc:     Sebastian Reichel <sre@kernel.org>,
        "open list:THERMAL" <linux-pm@vger.kernel.org>,
        devicetree@vger.kernel.org,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Collabora Kernel ML <kernel@collabora.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Fri, Mar 12, 2021 at 8:44 AM Sebastian Reichel
<sebastian.reichel@collabora.com> wrote:
>
> Hi,
>
> I keep getting patches for existing drivers, that modify DT behaviour
> without updating the binding file. Let's move everything to DT schema
> files, so that this can easily be cached automatically by dtbs_check.
>
> After this series only three bindings are left unconverted:
>
> 1. max8925_battery.txt
>    This describes a node below the PMIC, which does not have its own
>    compatible value. It needs to be described in the PMIC binding
>    file, which has not yet been converted.
>
> 2. stericsson,ab8500-battery.txt
>    This also describes a node below the PMIC, which does not have
>    its own compatible value. The same applies.
>
> 3. charger-manager.txt
>    This is far more complex to convert than the other files, due
>    to the 'cm-regulator-name' / "<>-supply" thing. I skipped it
>    for now.
>
> I tested the series using dt-validate 2021.3.dev6+g38efe3f and nothing
> is reported when running dtbs_check like this:
>
> make -s -j42 dtbs_check DT_SCHEMA_FILES="Documentation/devicetree/bindings/power/supply/*.yaml"
>
> Also nothing is reported when checking the power-supply binding files
> like this:
>
> for file in Documentation/devicetree/bindings/power/supply/*yaml ; do
>     make -s -j42 dt_binding_check DT_SCHEMA_FILES=$file ;
> done
>
> This is also available as 'psy-yaml-binding' branch from my repository:
>
> https://git.kernel.org/pub/scm/linux/kernel/git/sre/linux-power-supply.git
>
> Thanks for reviewing it,

Thanks for doing this. Other than the couple of things I pointed out,
looks good overall.

Rob