Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 15 Mar 2021 12:59:57 -0700
From:   Nicolin Chen <nicoleotsuka@gmail.com>
To:     Dmitry Osipenko <digetx@gmail.com>
Cc:     joro@8bytes.org, thierry.reding@gmail.com, will@kernel.org,
        vdumpa@nvidia.com, jonathanh@nvidia.com,
        linux-tegra@vger.kernel.org, iommu@lists.linux-foundation.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4] iommu/tegra-smmu: Add pagetable mappings to debugfs
Message-ID: <20210315195956.GA16172@Asurada-Nvidia>
References: <20210315033504.23937-1-nicoleotsuka@gmail.com>
 <c57a805a-cf14-1d78-ae2a-dfce4f643db1@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <c57a805a-cf14-1d78-ae2a-dfce4f643db1@gmail.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
Precedence: bulk

On Mon, Mar 15, 2021 at 09:53:09PM +0300, Dmitry Osipenko wrote:
> 15.03.2021 06:35, Nicolin Chen пишет:
> > This patch dumps all active mapping entries from pagetable
> > to a debugfs directory named "mappings".
> > 
> > Ataching an example:
> 
> Attaching
> 
> > 
> > SWGROUP: hc
> > ASID: 0
> > reg: 0x250
> > PTB_ASID: 0xe0080004
> > as->pd_dma: 0x80004000
> > {
> >         [1023] 0xf008000b (1)
> >         {
> >                 PTE RANGE      | ATTR | PHYS               | IOVA               | SIZE
> >                 [#1023, #1023] | 0x5  | 0x0000000111a8d000 | 0x00000000fffff000 | 0x1000
> >         }
> > }
> > Total PDE count: 1
> > Total PTE count: 1
> > 
> > Signed-off-by: Nicolin Chen <nicoleotsuka@gmail.com>
> > ---
> 
> Good to me, thanks.
> 
> Tested-by: Dmitry Osipenko <digetx@gmail.com>
> Reviewed-by: Dmitry Osipenko <digetx@gmail.com>
> 
> > +	for (pd_index = 0; pd_index < SMMU_NUM_PDE; pd_index++) {
> > +		struct page *pt_page;
> > +		u32 *addr;
> > +		unsigned int i;
> 
> Unimportant nit: I'd keep lines arranged by length for consistency with
> the rest of the code.
> 
> ...
> > +	group_debug = devm_kcalloc(dev, soc->num_swgroups, sizeof(*group_debug), GFP_KERNEL);
> 
> Another nit: this is a long line, I'd split it into two lines to keep
> coding style consistent and to improve readability for those who have a
> side-by-side code viewing setup.

Sending v5. Will add your Tested-by and Reviewed-by since there'd
be no functional changes. Thanks!