Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 15 Mar 2021 16:37:25 -0700
From:   Sean Christopherson <seanjc@google.com>
To:     Maxim Levitsky <mlevitsk@redhat.com>
Cc:     kvm@vger.kernel.org, Vitaly Kuznetsov <vkuznets@redhat.com>,
        linux-kernel@vger.kernel.org, Thomas Gleixner <tglx@linutronix.de>,
        Wanpeng Li <wanpengli@tencent.com>,
        Kieran Bingham <kbingham@kernel.org>,
        Jessica Yu <jeyu@kernel.org>,
        Jan Kiszka <jan.kiszka@siemens.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        "maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)" <x86@kernel.org>,
        Joerg Roedel <joro@8bytes.org>,
        Jim Mattson <jmattson@google.com>,
        Borislav Petkov <bp@alien8.de>,
        Stefano Garzarella <sgarzare@redhat.com>,
        "H. Peter Anvin" <hpa@zytor.com>,
        Paolo Bonzini <pbonzini@redhat.com>,
        Ingo Molnar <mingo@redhat.com>
Subject: Re: [PATCH 2/3] KVM: x86: guest debug: don't inject interrupts while
 single stepping
Message-ID: <YE/vtYYwMakERzTS@google.com>
References: <20210315221020.661693-1-mlevitsk@redhat.com>
 <20210315221020.661693-3-mlevitsk@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210315221020.661693-3-mlevitsk@redhat.com>
Precedence: bulk

On Tue, Mar 16, 2021, Maxim Levitsky wrote:
> This change greatly helps with two issues:
> 
> * Resuming from a breakpoint is much more reliable.
> 
>   When resuming execution from a breakpoint, with interrupts enabled, more often
>   than not, KVM would inject an interrupt and make the CPU jump immediately to
>   the interrupt handler and eventually return to the breakpoint, to trigger it
>   again.
> 
>   From the user point of view it looks like the CPU never executed a
>   single instruction and in some cases that can even prevent forward progress,
>   for example, when the breakpoint is placed by an automated script
>   (e.g lx-symbols), which does something in response to the breakpoint and then
>   continues the guest automatically.
>   If the script execution takes enough time for another interrupt to arrive,
>   the guest will be stuck on the same breakpoint RIP forever.
> 
> * Normal single stepping is much more predictable, since it won't land the
>   debugger into an interrupt handler, so it is much more usable.
> 
>   (If entry to an interrupt handler is desired, the user can still place a
>   breakpoint at it and resume the guest, which won't activate this workaround
>   and let the gdb still stop at the interrupt handler)
> 
> Since this change is only active when guest is debugged, it won't affect
> KVM running normal 'production' VMs.
> 
> 
> Signed-off-by: Maxim Levitsky <mlevitsk@redhat.com>
> Tested-by: Stefano Garzarella <sgarzare@redhat.com>
> ---
>  arch/x86/kvm/x86.c | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c
> index a9d95f90a0487..b75d990fcf12b 100644
> --- a/arch/x86/kvm/x86.c
> +++ b/arch/x86/kvm/x86.c
> @@ -8458,6 +8458,12 @@ static void inject_pending_event(struct kvm_vcpu *vcpu, bool *req_immediate_exit
>  		can_inject = false;
>  	}
>  
> +	/*
> +	 * Don't inject interrupts while single stepping to make guest debug easier
> +	 */
> +	if (vcpu->guest_debug & KVM_GUESTDBG_SINGLESTEP)
> +		return;

Is this something userspace can deal with?  E.g. disable IRQs and/or set NMI
blocking at the start of single-stepping, unwind at the end?  Deviating this far
from architectural behavior will end in tears at some point.

> +
>  	/*
>  	 * Finally, inject interrupt events.  If an event cannot be injected
>  	 * due to architectural conditions (e.g. IF=0) a window-open exit
> -- 
> 2.26.2
>