Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Rahul Tanwar <rtanwar@maxlinear.com>
To:     Arnd Bergmann <arnd@kernel.org>, Pavel Machek <pavel@ucw.cz>
CC:     Dan Murphy <dmurphy@ti.com>,
        "linux-leds@vger.kernel.org" <linux-leds@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Cheol Yong Kim <ckim@maxlinear.com>,
        Qiming Wu <qwu@maxlinear.com>
Subject: Re: [PATCH] leds: lgm: fix gpiolib dependency
Thread-Topic: [PATCH] leds: lgm: fix gpiolib dependency
Thread-Index: AQHXGX/MNzC5XhZ7M0WJOlGvthYGUg==
Date:   Tue, 16 Mar 2021 08:56:53 +0000
Message-ID: <MN2PR19MB3693DDA96346488BF0A422D3B16B9@MN2PR19MB3693.namprd19.prod.outlook.com>
References: <MN2PR19MB36933AFDC4531D0F7A984608B16C9@MN2PR19MB3693.namprd19.prod.outlook.com>
Accept-Language: en-US
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 44589e63-9e4e-4122-1bef-08d8e8597257
X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Mar 2021 08:56:53.9510
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: dac28005-13e0-41b8-8280-7663835f2b1d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: clRJZqQ/cO71mFAY44MbDo2FFvSOZrasvVvvg2vR+hkTj1Ero4afzLIazp//0Rri9vNEPdT5OBk9+R7YxjHbuA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR19MB3726
Authentication-Results: relay.mimecast.com;
        auth=pass smtp.auth=CUSA115A51 smtp.mailfrom=rtanwar@maxlinear.com
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: maxlinear.com
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 15/3/2021 5:44 pm, Rahul Tanwar wrote:=0A> From: Arnd Bergmann<arnd@kern=
el.org>=0A> To: Pavel Machek<pavel@ucw.cz>,=0A> =09Amireddy Mallikarjuna re=
ddy=0A> =09<mallikarjunax.reddy@linux.intel.com>=0A> Cc: Arnd Bergmann<arnd=
@arndb.de>, Dan Murphy<dmurphy@ti.com>,=0A> =09linux-leds@vger.kernel.org,l=
inux-kernel@vger.kernel.org=0A> Subject:[PATCH] leds: lgm: fix gpiolib depe=
ndency  <https://lore.kernel.org/lkml/20210308153052.2353885-1-arnd@kernel.=
org/#r>=0A> Date: Mon,  8 Mar 2021 16:30:46 +0100=0A> Message-ID:<202103081=
53052.2353885-1-arnd@kernel.org>  (raw  <https://lore.kernel.org/lkml/20210=
308153052.2353885-1-arnd@kernel.org/raw>)=0A>=20=0A> From: Arnd Bergmann<ar=
nd@arndb.de>=0A>=20=0A> Without gpiolib, the driver fails to build:=0A>=20=
=0A>      drivers/leds/blink/leds-lgm-sso.c:123:19: error: field has incomp=
lete type 'struct gpio_chip'=0A>              struct gpio_chip chip;=0A>   =
                            ^=0A>      include/linux/gpio.h:107:8: note: fo=
rward declaration of 'struct gpio_chip'=0A>      struct gpio_chip;=0A>     =
        ^=0A>      drivers/leds/blink/leds-lgm-sso.c:263:3: error: implicit=
 declaration of function 'gpiod_set_value' [-Werror,-Wimplicit-function-dec=
laration]=0A>                      gpiod_set_value(led->gpiod, val);=0A>   =
                   ^=0A>      drivers/leds/blink/leds-lgm-sso.c:263:3: note=
: did you mean 'gpio_set_value'?=0A>      include/linux/gpio.h:168:20: note=
: 'gpio_set_value' declared here=0A>      static inline void gpio_set_value=
(unsigned gpio, int value)=0A>                         ^=0A>      drivers/l=
eds/blink/leds-lgm-sso.c:345:3: error: implicit declaration of function 'gp=
iod_set_value' [-Werror,-Wimplicit-function-declaration]=0A>               =
       gpiod_set_value(led->gpiod, 1);=0A>                      ^=0A>=20=0A=
> Add the dependency in Kconfig.=0A>=20=0A> Fixes: c3987cd2bca3 ("leds: lgm=
: Add LED controller driver for LGM SoC")=0A> Signed-off-by: Arnd Bergmann<=
arnd@arndb.de>=0A> ---=0A>   drivers/leds/blink/Kconfig  <https://lore.kern=
el.org/lkml/20210308153052.2353885-1-arnd@kernel.org/#Z30drivers:leds:blink=
:Kconfig>  | 1 +=0A>   1 file changed, 1 insertion(+)=0A>=20=0A> diff=20=0A=
> <https://lore.kernel.org/lkml/20210308153052.2353885-1-arnd@kernel.org/#i=
Z30drivers:leds:blink:Kconfig>=20=0A> --git a/drivers/leds/blink/Kconfig b/=
drivers/leds/blink/Kconfig index=20=0A> 265b53476a80..6dedc58c47b3 100644 -=
-- a/drivers/leds/blink/Kconfig +++=20=0A> b/drivers/leds/blink/Kconfig @@ =
-9,6 +9,7 @@ if LEDS_BLINK  =20=0A>   config LEDS_BLINK_LGM=0A>   =09trista=
te "LED support for Intel LGM SoC series"=0A> + depends on GPIOLIB   =09dep=
ends on LEDS_CLASS=0A>   =09depends on MFD_SYSCON=0A>   =09depends on OF=0A=
> --=20=0A> 2.29.2=0A>=20=0A=0AAcked-by: Rahul Tanwar <rtanwar@maxlinear.co=
m>=0A=0A=0A