Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Kuldeep Singh <kuldeep.singh@nxp.com>
To:     Pratyush Yadav <p.yadav@ti.com>
CC:     "linux-spi@vger.kernel.org" <linux-spi@vger.kernel.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Mark Brown <broonie@kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        Vladimir Oltean <olteanv@gmail.com>,
        "linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>
Subject: RE: [EXT] Re: [PATCH] dt-bindings: spi: Convert Freescale DSPI to
 json schema
Thread-Topic: [EXT] Re: [PATCH] dt-bindings: spi: Convert Freescale DSPI to
 json schema
Thread-Index: AQHXGZTp77oN99ywtki2W2/Bm/x6J6qFX34AgAAK43A=
Date:   Tue, 16 Mar 2021 05:56:02 +0000
Message-ID: <DB6PR0402MB27581D0E1BB152AEF6DA2BF2E06B9@DB6PR0402MB2758.eurprd04.prod.outlook.com>
References: <20210315121518.3710171-1-kuldeep.singh@nxp.com>
 <20210315183051.ugvmz4zqrvuo6iqq@ti.com>
In-Reply-To: <20210315183051.ugvmz4zqrvuo6iqq@ti.com>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 76a88ad7-1f97-4549-e8ba-08d8e8402e38
X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Mar 2021 05:56:02.2758
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: lSU60ktRDeDatG1LHNTf/97DCKqO4CYS7n4IkYQ36zhFYB98gWRuy08n1uoveIXs7ij+ywx5HRwSU4Uz4ah4sA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0401MB2534
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> -----Original Message-----
> From: Pratyush Yadav <p.yadav@ti.com>
> Sent: Tuesday, March 16, 2021 12:01 AM
> To: Kuldeep Singh <kuldeep.singh@nxp.com>
> Cc: linux-spi@vger.kernel.org; devicetree@vger.kernel.org; linux-
> kernel@vger.kernel.org; Mark Brown <broonie@kernel.org>; Rob Herring
> <robh+dt@kernel.org>; Vladimir Oltean <olteanv@gmail.com>; linux-
> mtd@lists.infradead.org
> Subject: [EXT] Re: [PATCH] dt-bindings: spi: Convert Freescale DSPI to js=
on schema
>=20
> Caution: EXT Email
>=20
> +Cc mtd list
>=20
> Hi,
>=20
> On 15/03/21 05:45PM, Kuldeep Singh wrote:
> > Convert the Freescale DSPI binding to DT schema format using json-schem=
a.
> >
> > Signed-off-by: Kuldeep Singh <kuldeep.singh@nxp.com>
> > ---
> > Hi Rob,
> > This patch is checked with following commands with no warnings observed=
.
> > make distclean; make allmodconfig;
> > make dt_binding_check
> > DT_SCHEMA_FILES=3DDocumentation/devicetree/bindings/spi/fsl,spi-fsl-dsp=
i
> > .yaml; make dtbs_check
> > DT_SCHEMA_FILES=3DDocumentation/devicetree/bindings/spi/fsl,spi-fsl-dsp=
i
> > .yaml
>=20
> When I add the "fsl,spi-cs-sck-delay" property under the flash@0 node in =
the
> example and run dt_binding_check, I see the below error:
>=20
>   /home/pratyush/src/linux/Documentation/devicetree/bindings/spi/fsl,spi-=
fsl-
> dspi.example.dt.yaml: flash@0: 'fsl,spi-cs-sck-delay' does not match any =
of the
> regexes: '^partition@', 'pinctrl-[0-9]+'
>      From schema:
> /home/pratyush/src/lin/Documentation/devicetree/bindings/mtd/jedec,spi-
> nor.yaml

Hi Pratyush,

Thanks for mentioning, I just noticed the same error after adding fsl,spi-c=
s-sck-delay property.
Since my example is not using the property, the error went unnoticed.

Taking example of nvidia qspi bindings i.e=20
https://lore.kernel.org/linux-devicetree/1608585459-17250-3-git-send-email-=
skomatineni@nvidia.com/

I constructed other properties in similar fashion and later noticed that
example in nvidia bindings uses compatibes as "spi-nor" instead of "jedec,s=
pi-nor"
and therefore passes "make dt_binding_check".

> I am trying to solve a similar problem for the Cadence QSPI controller bi=
nding and
> I wonder what the best solution for this is. The obvious one would be to =
add
> these properties to jedec,spi-nor.yaml. I haven't managed to come up with=
 any
> other solution to this problem.

I agree with the solution to add properties in jedec,spi-nor.yaml and addin=
g properties
particular to specific controllers for flashes in generic jedec,spi-nor.yam=
l may not be
a good solution though. Please let me know your views.

Other approach is to add these properties in same binding itself (if possib=
le) so as=20
to limit the scope of these properties. Looking forward for more suggestion=
s.

Regards
Kuldeep