Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp4107730pxf; Tue, 16 Mar 2021 06:05:26 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyiPpLmld61p94PIv9ZB0iMOCwLLsi9sUjAgPoP2OXKAsu+RvsLWu0xi1HCLsL46abTxX+a X-Received: by 2002:a05:6402:6cb:: with SMTP id n11mr36508845edy.198.1615899926630; Tue, 16 Mar 2021 06:05:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1615899926; cv=none; d=google.com; s=arc-20160816; b=ZCQrzQHTm5yXDh5pjhwnyab9ljlOTfqfkGqAjcxkvl+/aqX8gVqRgwoNITsCy9ncEl QhQDy6E4Sk3YgMUJ0Pejl5pJj1dCGBDcfjuYGXCFWbLG/p/aWji68+ux8AI8lRxp+wNe npEw6i2j6xb6NxMheb2tZT0ilfsFC7xBh0nP0TVeN/51VTn/uZ6xkCGcYT3wzXnMK9hh L1Qjj6ABCnwQUf5xLOZAdYe/qOnKRVw9zeJrkiEBIWQ0aYb6rtZ51tffabQjX4fZ19NP dNq9NRLtkQugdfVrmEoJAFJCJ2NcBMXORgtNrrbiUMv0p1KiA7R3tVhY2yYmE2ev4nSM +9eQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=7NE5qRppEh+vuD5w5V/nMu/zyhNN/XrhmdRPI+9wiC0=; b=KG70ZkTaFlkv08Q3OwHsR8g+cMIWWTnyq8Cw2mRdoQZr7oh5nmvI3UuggG3RB2zxI+ yW1xgHBPGF/yv5CemmS9CqlozIvkgeXl0sjmkmByRpVEUjGoaAKNEIAFzvKUHbXVBxDo XTBYiM1XwBOXPieK+c1X8fudmfyg6y8Yx4RupMIdyzTWLw/oqHEJV69nDXOhLpSvkEGf yQC0YVDaJblyXWaNu8BX1GzpSGiWEIDfk7YFSgos628IHmca9bwX6/W/FNIWy9XXrvio 3aF7J5jcAMYzFW63sJ9keVWP4o0aBjKC1uzzxVK7Zz0Uk+MTqxlPXZFZUCc7TVr0Ox+Y e57w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Td1jxmn3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id bs23si13929921edb.75.2021.03.16.06.05.03; Tue, 16 Mar 2021 06:05:26 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Td1jxmn3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232550AbhCPGGf (ORCPT + 99 others); Tue, 16 Mar 2021 02:06:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56080 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232040AbhCPGGb (ORCPT ); Tue, 16 Mar 2021 02:06:31 -0400 Received: from mail-pl1-x636.google.com (mail-pl1-x636.google.com [IPv6:2607:f8b0:4864:20::636]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1AF18C061756 for ; Mon, 15 Mar 2021 23:06:31 -0700 (PDT) Received: by mail-pl1-x636.google.com with SMTP id a8so9927862plp.13 for ; Mon, 15 Mar 2021 23:06:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=7NE5qRppEh+vuD5w5V/nMu/zyhNN/XrhmdRPI+9wiC0=; b=Td1jxmn39AwTl8uHORTeIBbhli4+n/1Z5mTPDDLP21XZQmZT8Em/DG2qNT3FUiAm+g 1PDVpPS+6EYvIv76fFaVl1ty48R411f0/lOgRZodXGdizu1UmBGXJTHzDhr6M3mnmXeT 9TJUHu34Rly/4NRUrdhSaycEvwr7K3y97y647AreHd79haF2L90gt3BoUCKagQ3Am+i7 CxHvZY7o4+jCElrW/J2/6UouO12SgITh/kvskSd3NQd8xcRmh/z8NCZ8MODWYVD8wuul NZrD1sk0GW3UyvrQV5Je53FmLPhfMoId34tJ50DARsMWBtfozrZ9Bz2bd3vMDrp3+oDv 2jKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=7NE5qRppEh+vuD5w5V/nMu/zyhNN/XrhmdRPI+9wiC0=; b=t2nkU7kqQn1Lp4XqrYeROktR5Ebd112arPye3GbI11I02cqSGGHtRCfKSvDqT33Gqs us46DpYgfq5J7A6kirmVOibt06SBPy9LYoSXqdkdvvp4YxDJ3PJC/NtCYpFAh5nZOgQL YkaPlnjastw9Wgu4eHE5OlnU6974Fst4Em99xQuPSg4rtz7+81XSLLDn5MMCb0SYikjk pgAZUdFn0jhkK2UInxnBLYDCAk7VTHhGORMRCXkBoekuMpVlWgct4XmsPBoNpD84u0Lx dL/svjh7o9FncGVSILGY1WBKhe+cRefRKt5gxbmbspm/4UkSajoN1kK1vp6/jwrfKd35 ahmA== X-Gm-Message-State: AOAM532OQWFfkM9edRyOkCS+5QEhQBaHTBgrtAjT6QnW5ZpCzJtd+tib 6Nj94HpCd7gHH6VXjvJafLdaQrRfiPLuyYE= X-Received: by 2002:a17:902:82c7:b029:e4:74ad:9450 with SMTP id u7-20020a17090282c7b02900e474ad9450mr15278280plz.58.1615874789908; Mon, 15 Mar 2021 23:06:29 -0700 (PDT) Received: from thinkpad ([103.66.79.72]) by smtp.gmail.com with ESMTPSA id i1sm14484826pfo.160.2021.03.15.23.06.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Mar 2021 23:06:29 -0700 (PDT) Date: Tue, 16 Mar 2021 11:36:24 +0530 From: Manivannan Sadhasivam To: Jeffrey Hugo Cc: hemantk@codeaurora.org, bbhatt@codeaurora.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Fan Wu Subject: Re: [PATCH v3 RESEND] bus: mhi: core: Return EAGAIN if MHI ring is full Message-ID: <20210316060624.GF1798@thinkpad> References: <1615408803-7016-1-git-send-email-jhugo@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1615408803-7016-1-git-send-email-jhugo@codeaurora.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 10, 2021 at 01:40:03PM -0700, Jeffrey Hugo wrote: > From: Fan Wu > > Currently ENOMEM is returned when MHI ring is full. This error code is > very misleading. Change to EAGAIN instead. > > Signed-off-by: Fan Wu > Signed-off-by: Jeffrey Hugo > Reviewed-by: Hemant Kumar > Reviewed-by: Manivannan Sadhasivam Applied to mhi-next! Thanks, Mani > --- > drivers/bus/mhi/core/main.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/bus/mhi/core/main.c b/drivers/bus/mhi/core/main.c > index 2c61dfd..a7811fb 100644 > --- a/drivers/bus/mhi/core/main.c > +++ b/drivers/bus/mhi/core/main.c > @@ -1020,7 +1020,7 @@ static int mhi_queue(struct mhi_device *mhi_dev, struct mhi_buf_info *buf_info, > > ret = mhi_is_ring_full(mhi_cntrl, tre_ring); > if (unlikely(ret)) { > - ret = -ENOMEM; > + ret = -EAGAIN; > goto exit_unlock; > } > > -- > Qualcomm Technologies, Inc. is a member of the > Code Aurora Forum, a Linux Foundation Collaborative Project. >