Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Kuldeep Singh <kuldeep.singh@nxp.com>
To:     Vladimir Oltean <olteanv@gmail.com>
CC:     "linux-spi@vger.kernel.org" <linux-spi@vger.kernel.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Mark Brown <broonie@kernel.org>,
        Rob Herring <robh+dt@kernel.org>
Subject: RE: [EXT] Re: [PATCH] dt-bindings: spi: Convert Freescale DSPI to
 json schema
Thread-Topic: [EXT] Re: [PATCH] dt-bindings: spi: Convert Freescale DSPI to
 json schema
Thread-Index: AQHXGZTp77oN99ywtki2W2/Bm/x6J6qFh6sAgACXclA=
Date:   Tue, 16 Mar 2021 06:08:17 +0000
Message-ID: <DB6PR0402MB27580AF77ED738B995616EB5E06B9@DB6PR0402MB2758.eurprd04.prod.outlook.com>
References: <20210315121518.3710171-1-kuldeep.singh@nxp.com>
 <20210315205440.lb6hcrvzxtqxdb5x@skbuf>
In-Reply-To: <20210315205440.lb6hcrvzxtqxdb5x@skbuf>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 01b4920a-357c-4729-d56f-08d8e841e462
X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Mar 2021 06:08:17.4776
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: JQ5ANNMa0B1yt9IXdF0srTkPq3zbbCNLmWvAthnzxCsglC6gokWmaE0GVW9w9obBTYO/tU5ARdghTlV0HbNITg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR04MB6857
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Vladimir,

> -----Original Message-----
> From: Vladimir Oltean <olteanv@gmail.com>
> Sent: Tuesday, March 16, 2021 2:25 AM
> To: Kuldeep Singh <kuldeep.singh@nxp.com>
> Cc: linux-spi@vger.kernel.org; devicetree@vger.kernel.org; linux-
> kernel@vger.kernel.org; Mark Brown <broonie@kernel.org>; Rob Herring
> <robh+dt@kernel.org>
> Subject: [EXT] Re: [PATCH] dt-bindings: spi: Convert Freescale DSPI to js=
on schema
>=20
> Caution: EXT Email
>=20
> Hi Kuldeep,
>=20
> On Mon, Mar 15, 2021 at 05:45:18PM +0530, Kuldeep Singh wrote:
> > Convert the Freescale DSPI binding to DT schema format using json-schem=
a.
> >
> > Signed-off-by: Kuldeep Singh <kuldeep.singh@nxp.com>
> > ---
[...]
> > +
> > +allOf:
> > +  - $ref: "spi-controller.yaml#"
> > +
> > +properties:
> > +  compatible:
> > +    oneOf:
> > +      - enum:
> > +          - fsl,vf610-dspi
> > +          - fsl,ls1021a-v1.0-dspi
> > +          - fsl,ls1028a-dspi
> > +          - fsl,ls2085a-dspi
> > +          - fsl,lx2160a-dspi
> > +      - items:
> > +          - enum:
> > +              - fsl,ls1012a-dspi
> > +              - fsl,ls1028a-dspi
> > +              - fsl,ls1043a-dspi
> > +              - fsl,ls1046a-dspi
> > +              - fsl,ls1088a-dspi
> > +          - const: fsl,ls1021a-v1.0-dspi
> > +      - items:
> > +          - enum:
> > +              - fsl,ls2080a-dspi
> > +              - fsl,lx2160a-dspi
> > +          - const: fsl,ls2085a-dspi
>=20
> Can this simply be:
>   compatible:
>     oneOf:
>       - enum:
>           - fsl,vf610-dspi
>           - fsl,ls1021a-v1.0-dspi
>           - fsl,ls1012a-dspi
>           - fsl,ls1028a-dspi
>           - fsl,ls1043a-dspi
>           - fsl,ls1046a-dspi
>           - fsl,ls1088a-dspi
>           - fsl,ls2080a-dspi
>           - fsl,ls2085a-dspi
>           - fsl,lx2160a-dspi
> ?

Compatible entries in conjugation require enum and const pair.
For example, ls1012a.dtsi uses compatible =3D "fsl,ls1012a-dspi","fsl,ls102=
1a-v1.0-dspi";
Same goes for LS1028 as well.

Therefore, can't mention the compatible entry as single entity otherwise
it may fail "make dt_binding_check" and "make dtbs_check".

>=20
> > +examples:
> > +  - |
> > +    #include <dt-bindings/clock/fsl,qoriq-clockgen.h>
> > +    #include <dt-bindings/interrupt-controller/arm-gic.h>
> > +
> > +    soc {
> > +        #address-cells =3D <2>;
> > +        #size-cells =3D <2>;
> > +
> > +        spi@2100000 {
> > +            compatible =3D "fsl,ls1028a-dspi", "fsl,ls1021a-v1.0-dspi"=
;
>=20
> This doesn't need the "fsl,ls1021a-v1.0-dspi" compatible, can you please =
remove
> it?

I have taken this example from LS1028a.dtsi and it uses these compatibles i=
n conjugation.
If "fsl,ls1021a-v1.0-dspi" is not required, then it should also be removed =
from device-tree
As well as from bindings both.

>=20
> > +            #address-cells =3D <1>;
> > +            #size-cells =3D <0>;
> > +            reg =3D <0x0 0x2100000 0x0 0x10000>;
> > +            interrupts =3D <GIC_SPI 26 IRQ_TYPE_LEVEL_HIGH>;
> > +            clock-names =3D "dspi";
> > +            clocks =3D <&clockgen QORIQ_CLK_PLATFORM_PLL
> QORIQ_CLK_PLL_DIV(2)>;
> > +            dmas =3D <&edma0 0 62>, <&edma0 0 60>;
> > +            dma-names =3D "tx", "rx";
> > +            spi-num-chipselects =3D <4>;
> > +            little-endian;
> > +
> > +            flash@0 {
> > +                compatible =3D "jedec,spi-nor";
> > +                spi-max-frequency =3D <10000000>;
> > +                reg =3D <0>;
> > +            };
> > +        };
> > +    };
>=20
> (...)
>=20
> > -Optional property:
> > -- big-endian: If present the dspi device's registers are implemented
> > -  in big endian mode.
>=20
> I don't see "big-endian" being covered in any common yaml, could you plea=
se not
> delete it? The driver calls of_device_is_big_endian.

Thanks for mentioning.
Will consider this in next version after receiving feedback on other thread=
.

Regards
Kuldeep