Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp4216644pxf; Tue, 16 Mar 2021 08:14:58 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwpYcjLExOAiZ2JspjR1ETkiS180Vz0xvYZ+zCudItIQ4mtxSNifX25f2140hJO0stk4+EV X-Received: by 2002:a17:906:4107:: with SMTP id j7mr14106624ejk.185.1615907698406; Tue, 16 Mar 2021 08:14:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1615907698; cv=none; d=google.com; s=arc-20160816; b=AXK9eJUgogulJt/fUMf4Oy3bd4U+o53eak/hl9hqjRvket/rv/P6pUy8MmCFWqQS4E 3s6KCiTakupnVRaRU9P8xqZ53UXMecC8nCmwx7HOCngUCK5Fh/72UmO8LQFlCB75QRsd nJiXtbRyoWxpEOU34xZVfA8rHw8RWf1kFcw4BsHSCN9GBkiXx8oJ602KDYxLY/cf0c8p R0P3cHXiZds1idDDMuv1CnOWy2+uycsIk8BQJs/ULloDX/9TkmGfStR/w8Apexfp7M3l KiSczdR5f+rkPb23G+tUBZGPtBTx/vKpovt0rTVfawM5z2UekVkjCqWxhveCHIwzEAC0 bF9w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=5TLHkLBDBKTf3TbiINQ/jIkhmWOjyNZl5tYcEOCZJhM=; b=s8OyBMnYxxRrTBDfuDxkY+9GfXIf8D4Of/cSgSRhphqLf+4SNsZbDCRbRPCvAvk9Tj A2GcaJ3LMsyOgoDQn8DeYzo0U7oiJjy9D8yaqNjB7N/1d5aN2ZXNlhzc21EZuTqujweo LKiOABge49ZETLvLqQwIDmgG9cn/JPNL0guz6i2KpdWRGsz6sjEVhYjYQLtS1OvDsPyq OPFgFrSSJPLeuq6qozETkwb4EzWCsJxbt4Gkjm6XnNRDT+GcK/qAMwmlWpPg4bue21as 4TjVrWF9gUyU6CagMotO5148mT9lfGrvqG3cc4jLaI5Fi+ECm1kHaG+OAKbW3mp37Pb9 faxw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=WpYrW87p; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id s18si14464006ejd.15.2021.03.16.08.14.35; Tue, 16 Mar 2021 08:14:58 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=WpYrW87p; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235451AbhCPJtH (ORCPT + 99 others); Tue, 16 Mar 2021 05:49:07 -0400 Received: from mail.kernel.org ([198.145.29.99]:48394 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232335AbhCPJtA (ORCPT ); Tue, 16 Mar 2021 05:49:00 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 990CD64F6D; Tue, 16 Mar 2021 09:48:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1615888140; bh=2V+lNZksGULsy/lblGLLF1K+PMqySH5u+6uef63fvDU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=WpYrW87pN81De28KP8oYmI+UG3Ga44pGvZbOmRXFDvjKvid9eGfidTYrSnIpNdn7a EhYpD34MsZ9YjfJ71kQa79ty/N7ugMD8LsYJvZT0VqxWtifjFazJJiTuzx4L/HtGjm TMVvtZkT0+jMj0/6XqU6u/ksIMNRZ7d/rlDhR2Ko= Date: Tue, 16 Mar 2021 10:48:56 +0100 From: Greg KH To: Pavel Machek Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, Eric Dumazet , "David S. Miller" Subject: Re: [PATCH 4.19 011/120] tcp: annotate tp->copied_seq lockless reads Message-ID: References: <20210315135720.002213995@linuxfoundation.org> <20210315135720.384809636@linuxfoundation.org> <20210316094137.GA12946@amd> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210316094137.GA12946@amd> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 16, 2021 at 10:41:37AM +0100, Pavel Machek wrote: > Hi! > > > From: Greg Kroah-Hartman > > > > From: Eric Dumazet > > Two From: fields here. This is a side-affect of me using git-send-email to talk to the remote smtp server directly instead of using my local email server. This was done to increase the speed of sending these patches out as git-send-email can pipeline messages instead of having msmtp do a setup/send/teardown on every individual message sent. These are not in the patches themselves and I will work to figure out if this can be fixed. Gotta be a setting somewhere... > > > [ Upstream commit 7db48e983930285b765743ebd665aecf9850582b ] > > > > There are few places where we fetch tp->copied_seq while > > this field can change from IRQ or other cpu. > > And there are few such places even after the patch is applied; I > quoted them below. > > Doing addition to variable without locking... is kind of > interesting. Are you sure it is okay? Why isn't it? thanks, greg k-h