Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 16 Mar 2021 10:48:56 +0100
From:   Greg KH <gregkh@linuxfoundation.org>
To:     Pavel Machek <pavel@denx.de>
Cc:     linux-kernel@vger.kernel.org, stable@vger.kernel.org,
        Eric Dumazet <edumazet@google.com>,
        "David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH 4.19 011/120] tcp: annotate tp->copied_seq lockless reads
Message-ID: <YFB/CBeDBiolOxDD@kroah.com>
References: <20210315135720.002213995@linuxfoundation.org>
 <20210315135720.384809636@linuxfoundation.org>
 <20210316094137.GA12946@amd>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210316094137.GA12946@amd>
Precedence: bulk

On Tue, Mar 16, 2021 at 10:41:37AM +0100, Pavel Machek wrote:
> Hi!
> 
> > From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > 
> > From: Eric Dumazet <edumazet@google.com>
> 
> Two From: fields here.

This is a side-affect of me using git-send-email to talk to the remote
smtp server directly instead of using my local email server.  This was
done to increase the speed of sending these patches out as
git-send-email can pipeline messages instead of having msmtp do a
setup/send/teardown on every individual message sent.

These are not in the patches themselves and I will work to figure out
if this can be fixed.  Gotta be a setting somewhere...

> 
> > [ Upstream commit 7db48e983930285b765743ebd665aecf9850582b ]
> > 
> > There are few places where we fetch tp->copied_seq while
> > this field can change from IRQ or other cpu.
> 
> And there are few such places even after the patch is applied; I
> quoted them below.
> 
> Doing addition to variable without locking... is kind of
> interesting. Are you sure it is okay?

Why isn't it?

thanks,

greg k-h