Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 16 Mar 2021 21:16:43 +0900
From:   taehyun cho <taehyun.cho@samsung.com>
To:     Alan Stern <stern@rowland.harvard.edu>
Cc:     balbi@kernel.org, Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb: dwc3: remove 'pm_runtime_set_active' in resume
 callback
Message-ID: <20210316121643.GA138912@rack03>
MIME-Version: 1.0
In-Reply-To: <20210315141335.GA402778@rowland.harvard.edu>
User-Agent: Mutt/1.5.24 (2015-08-30)
Content-Type: multipart/mixed;
        boundary="----VQObM9Pl3j-Am1LaCn7xN8sri-O7OboG09SNkG7pZ6-k7KuL=_22549a_"
CMS-TYPE: 102P
DLP-Filter: Pass
References: <CGME20210315074223epcas2p11ddf190ec730f8629c1310117135f813@epcas2p1.samsung.com>
        <20210315074317.7736-1-taehyun.cho@samsung.com>
        <20210315141335.GA402778@rowland.harvard.edu>
Precedence: bulk

------VQObM9Pl3j-Am1LaCn7xN8sri-O7OboG09SNkG7pZ6-k7KuL=_22549a_
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline

On Mon, Mar 15, 2021 at 10:13:35AM -0400, Alan Stern wrote:
> On Mon, Mar 15, 2021 at 04:43:17PM +0900, taehyun cho wrote:
> > 'pm_runtime_set_active' sets a flag to describe rumtime status.
> > This flag is automatically set in pm_runtime_get_sync/put_sync API.
> > 'pm_runtime_set_active' checks the runtime status of parent device.
> > As a result, the below error message is printed.
> > dwc3 11110000.dwc3: runtime PM trying to activate child device
> > 11110000.dwc3 but parent (11110000.usb) is not active.
> 
> This is very suspicious.  That error message indicates a real error is 
> present; removing these pm_runtime_set_active calls won't fix the error.
> 
> You need to determine why the parent platform device 11110000.usb isn't 
> active when the dwc3 probe and resume routines are called.  It seems 
> likely that there is a bug in the platform device's driver.
> 
> Alan Stern
>

I thought the issue happened because 'pm_runtime_set_active' set a flag again.
I will check again if there is a problem in our platform device driver and
get back.

Taehyun Cho

> > Signed-off-by: taehyun cho <taehyun.cho@samsung.com>
> > ---
> >  drivers/usb/dwc3/core.c | 2 --
> >  1 file changed, 2 deletions(-)
> > 
> > diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c
> > index 94fdbe502ce9..e7c0e390f885 100644
> > --- a/drivers/usb/dwc3/core.c
> > +++ b/drivers/usb/dwc3/core.c
> > @@ -1553,7 +1553,6 @@ static int dwc3_probe(struct platform_device *pdev)
> >  
> >  	spin_lock_init(&dwc->lock);
> >  
> > -	pm_runtime_set_active(dev);
> >  	pm_runtime_use_autosuspend(dev);
> >  	pm_runtime_set_autosuspend_delay(dev, DWC3_DEFAULT_AUTOSUSPEND_DELAY);
> >  	pm_runtime_enable(dev);
> > @@ -1920,7 +1919,6 @@ static int dwc3_resume(struct device *dev)
> >  		return ret;
> >  
> >  	pm_runtime_disable(dev);
> > -	pm_runtime_set_active(dev);
> >  	pm_runtime_enable(dev);
> >  
> >  	return 0;
> > -- 
> > 2.26.0
> 

------VQObM9Pl3j-Am1LaCn7xN8sri-O7OboG09SNkG7pZ6-k7KuL=_22549a_
Content-Type: text/plain; charset="utf-8"


------VQObM9Pl3j-Am1LaCn7xN8sri-O7OboG09SNkG7pZ6-k7KuL=_22549a_--