Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 16 Mar 2021 15:04:07 +0100
From:   Jiri Olsa <jolsa@redhat.com>
To:     "Jin, Yao" <yao.jin@linux.intel.com>
Cc:     acme@kernel.org, jolsa@kernel.org, peterz@infradead.org,
        mingo@redhat.com, alexander.shishkin@linux.intel.com,
        Linux-kernel@vger.kernel.org, ak@linux.intel.com,
        kan.liang@intel.com, yao.jin@intel.com
Subject: Re: [PATCH v2 11/27] perf parse-events: Support hardware events
 inside PMU
Message-ID: <YFC615nTdUR/aLw5@krava>
References: <20210311070742.9318-1-yao.jin@linux.intel.com>
 <20210311070742.9318-12-yao.jin@linux.intel.com>
 <YEu9usdFl6VSnOQ7@krava>
 <c40d6187-9391-40de-aea8-7389bb369555@linux.intel.com>
 <YE+balbLkG5RL7Lu@krava>
 <fd88f214-f0a4-87bc-ef52-ee750ca13a8d@linux.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <fd88f214-f0a4-87bc-ef52-ee750ca13a8d@linux.intel.com>
Precedence: bulk

On Tue, Mar 16, 2021 at 09:49:42AM +0800, Jin, Yao wrote:

SNIP

> 
>  Performance counter stats for 'system wide':
> 
>        136,655,302      cpu_core/branch-instructions/
> 
>        1.003171561 seconds time elapsed
> 
> So we need special rules for both cycles and branches.
> 
> The worse thing is, we also need to process the hardware cache events.
> 
> # ./perf stat -e cpu_core/LLC-loads/
> event syntax error: 'cpu_core/LLC-loads/'
>                               \___ unknown term 'LLC-loads' for pmu 'cpu_core'
> 
> valid terms: event,pc,edge,offcore_rsp,ldlat,inv,umask,frontend,cmask,config,config1,config2,name,period,percore
> 
> Initial error:
> event syntax error: 'cpu_core/LLC-loads/'
>                               \___ unknown term 'LLC-loads' for pmu 'cpu_core'
> 
> If we use special rules for establishing all event mapping, that looks too much. :(

hmmm but wait, currently we do not support events like this:

  'cpu/cycles/'
  'cpu/branches/'

the pmu style accepts only 'events' or 'format' terms within //

we made hw events like 'cycles','instructions','branches' special
to be used without the pmu

so why do we need to support cpu_code/cycles/ ?

jirka