Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] drm/omap: dsi: fix unsigned expression compared with zero
To:     Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
        angkery <angkery@163.com>
Cc:     airlied@linux.ie, daniel@ffwll.ch, sebastian.reichel@collabora.com,
        dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
        Junlin Yang <yangjunlin@yulong.com>
References: <20210312071445.1721-1-angkery@163.com>
 <YE1xsg0gm0nNR8hy@pendragon.ideasonboard.com>
From:   Tomi Valkeinen <tomba@kernel.org>
Message-ID: <dd0578a1-9726-4be2-f8a1-b164675b1b02@kernel.org>
Date:   Tue, 16 Mar 2021 16:03:51 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.7.1
MIME-Version: 1.0
In-Reply-To: <YE1xsg0gm0nNR8hy@pendragon.ideasonboard.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 14/03/2021 04:15, Laurent Pinchart wrote:
> Hi Junlin,
> 
> Thank you for the patch.
> 
> On Fri, Mar 12, 2021 at 03:14:45PM +0800, angkery wrote:
>> From: Junlin Yang <yangjunlin@yulong.com>
>>
>> r is "u32" always >= 0,mipi_dsi_create_packet may return little than zero.
>> so r < 0 condition is never accessible.
>>
>> Fixes coccicheck warnings:
>> ./drivers/gpu/drm/omapdrm/dss/dsi.c:2155:5-6:
>> WARNING: Unsigned expression compared with zero: r < 0
>>
>> Signed-off-by: Junlin Yang <yangjunlin@yulong.com>
> 
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> 
> Tomi, will you take this in your tree ?

Thanks. Yes, I'll pick this up.

  Tomi