Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <00000000000069802205bda22b7f@google.com> <CACT4Y+Yaq-zDh5FAzHt4g-5jXrXC3rSLw6CM=kjcfR6oxJ1+CA@mail.gmail.com>
 <CAK8P3a1qtHVBY47FfCa6R9+sObzMCwxkREii+O2g8PPopw87eQ@mail.gmail.com>
 <CACT4Y+aC0YWU6gM32S3NoT+-wR7B1-_rhPyh4w542h21UCRRGw@mail.gmail.com>
 <CAK8P3a0zA9pv005d_P_e64j4EwXDh75yC6gNGRVdyy-VzO+7Fw@mail.gmail.com> <20210316155102.GP1463@shell.armlinux.org.uk>
In-Reply-To: <20210316155102.GP1463@shell.armlinux.org.uk>
From:   Dmitry Vyukov <dvyukov@google.com>
Date:   Tue, 16 Mar 2021 17:03:16 +0100
Message-ID: <CACT4Y+bzBa6+2XFD0=_VVV-XFHgiP2BAnHHGKB=i0qyvP+HXWA@mail.gmail.com>
Subject: Re: [syzbot] kernel panic: corrupted stack end in openat
To:     Russell King - ARM Linux admin <linux@armlinux.org.uk>
Cc:     Arnd Bergmann <arnd@arndb.de>,
        syzbot <syzbot+0b06ef9b44d00d600183@syzkaller.appspotmail.com>,
        Linus Walleij <linus.walleij@linaro.org>,
        Linux ARM <linux-arm-kernel@lists.infradead.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        LKML <linux-kernel@vger.kernel.org>,
        Linux-MM <linux-mm@kvack.org>,
        syzkaller-bugs <syzkaller-bugs@googlegroups.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Tue, Mar 16, 2021 at 4:51 PM Russell King - ARM Linux admin
<linux@armlinux.org.uk> wrote:
>
> On Tue, Mar 16, 2021 at 04:44:45PM +0100, Arnd Bergmann wrote:
> > On Tue, Mar 16, 2021 at 11:17 AM Dmitry Vyukov <dvyukov@google.com> wro=
te:
> > > On Tue, Mar 16, 2021 at 11:02 AM Arnd Bergmann <arnd@arndb.de> wrote:
> > > > > On Tue, Mar 16, 2021 at 8:18 AM syzbot
> > >
> > > > > > [<8073772c>] (integrity_kernel_read) from [<8073a904>] (ima_cal=
c_file_hash_tfm+0x178/0x228 security/integrity/ima/ima_crypto.c:484)
> > > > > > [<8073a78c>] (ima_calc_file_hash_tfm) from [<8073ae2c>] (ima_ca=
lc_file_shash security/integrity/ima/ima_crypto.c:515 [inline])
> > > > > > [<8073a78c>] (ima_calc_file_hash_tfm) from [<8073ae2c>] (ima_ca=
lc_file_hash+0x124/0x8b8 security/integrity/ima/ima_crypto.c:572)
> > > >
> > > > ima_calc_file_hash_tfm() has a SHASH_DESC_ON_STACK(), which by itse=
lf can
> > > > use up 512 bytes, but KASAN sometimes triples this number. However,=
 I see
> > > > you do not actually have KASAN enabled, so there is probably more t=
o it.
> > >
> > > The compiler is gcc version 10.2.1 20210110 (Debian 10.2.1-6)
> >
> > Ok, building with Ubuntu 10.2.1-1ubuntu1 20201207 locally, that's
> > the closest I have installed, and I think the Debian and Ubuntu version=
s
> > are generally quite close in case of gcc since they are maintained by
> > the same packagers.
> >
> > I see ima_calc_field_array_hash_tfm() shows up as one of the larger
> > stack users, but not alarmingly high:
> > ../security/integrity/ima/ima_crypto.c: In function
> > =E2=80=98ima_calc_field_array_hash_tfm=E2=80=99:
> > ../security/integrity/ima/ima_crypto.c:624:1: warning: the frame size
> > of 664 bytes is larger than 600 bytes [-Wframe-larger-than=3D]
> > none of the other functions from the call chain have more than 600 byte=
s
> > in this combination of config/compiler/sourcetree.
> >
> > In combination, I don't get to more than ~2300 bytes:
>
> ... which shouldn't be a problem - that's just over 1/4 of the stack
> space. Could it be the syzbot's gcc is doing something weird and
> inflating the stack frames?

It's just a stock Debian-provided gcc. Which I would assume also just
a plain gcc.