Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 16 Mar 2021 18:32:40 +0200
From:   Cristian Ciocaltea <cristian.ciocaltea@gmail.com>
To:     David Miller <davem@redhat.com>
Cc:     andrew@lunn.ch, kuba@kernel.org, robh+dt@kernel.org,
        afaerber@suse.de, mani@kernel.org, p.zabel@pengutronix.de,
        netdev@vger.kernel.org, devicetree@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org,
        linux-actions@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/3] net: ethernet: actions: Add Actions Semi Owl
 Ethernet MAC driver
Message-ID: <20210316163240.GA1111731@BV030612LT>
References: <cover.1615807292.git.cristian.ciocaltea@gmail.com>
 <a93430bc30d7e733184a2fa3ab5c66180a76d379.1615807292.git.cristian.ciocaltea@gmail.com>
 <20210315.143933.939938434416308507.davem@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210315.143933.939938434416308507.davem@redhat.com>
Precedence: bulk

On Mon, Mar 15, 2021 at 02:39:33PM -0700, David Miller wrote:
> From: Cristian Ciocaltea <cristian.ciocaltea@gmail.com>
> Date: Mon, 15 Mar 2021 13:29:17 +0200
> 
> > +
> > +#define DEFAULT_MSG_ENABLE (NETIF_MSG_DRV | NETIF_MSG_PROBE | NETIF_MSG_LINK)
> > +static int debug = -1;
> > +module_param(debug, int, 0);
> > +MODULE_PARM_DESC(debug, "Debug level (0=none,...,16=all)");
> 
> Module parameters are strongly discouraged in networking drivers, pplease delete this
> ad just pass the default to netif_mdg_init(), thanks!

Ups, I was not aware of this since I've seen it in quite a lot of drivers.

Thanks for pointing this out, I will take care of it in the next
revision.

Kind regards,
Cristi