Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 16 Mar 2021 18:29:09 +0100
From:   Greg KH <gregkh@linuxfoundation.org>
To:     Mihai Carabas <mihai.carabas@oracle.com>
Cc:     linux-kernel@vger.kernel.org, arnd@arndb.de,
        bobo.shaobowang@huawei.com, rdunlap@infradead.org
Subject: Re: [PATCH v5 3/3] misc/pvpanic: add PCI driver
Message-ID: <YFDq5Wj4AQOm/Bm4@kroah.com>
References: <1615897229-4055-1-git-send-email-mihai.carabas@oracle.com>
 <1615897229-4055-4-git-send-email-mihai.carabas@oracle.com>
 <YFDhZbRYE5szZ4l/@kroah.com>
 <b3d33f82-21ab-2244-13b0-700fc54b2093@oracle.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <b3d33f82-21ab-2244-13b0-700fc54b2093@oracle.com>
Precedence: bulk

On Tue, Mar 16, 2021 at 07:08:38PM +0200, Mihai Carabas wrote:
> ..snip..
> > > +};
> > > +static unsigned int capability = PVPANIC_PANICKED | PVPANIC_CRASH_LOADED;
> > > +static unsigned int events;
> > > +
> > > +static ssize_t capability_show(struct device *dev,
> > > +			       struct device_attribute *attr, char *buf)
> > > +{
> > > +	return sysfs_emit(buf, "%x\n", capability);
> > A global capability for all devices?  No, this needs to be a per-device
> > attttribute as you are showing it to userspace as such.
> 
> We can only have a pvpanic-pci device. This is necessary in that case?

Why would it not be?  Why constrain yourself to something that someone
will only have to fix sometime in the future?

> ...snip..
> > > +static struct attribute *pvpanic_pci_dev_attrs[] = {
> > > +	&dev_attr_capability.attr,
> > > +	&dev_attr_events.attr,
> > > +	NULL
> > > +};
> > > +ATTRIBUTE_GROUPS(pvpanici_pci_dev);
> > You did not document these new sysfs files in Documentation/ABI/ so it's
> > hard to judge what they do.  Please do so next version.
> 
> This appeared after 5.12 rebase on pvpanic-mmio. I did this changes to
> pvpanic-pci to be on the same page as pvpanic-mmio which is described here:
> Documentation/ABI/testing/sysfs-bus-pci-devices-pvpanic.

Ah, missed that, my fault, sorry.  But you also now do this for the
other device type right?  So does the documentation need to reflect that
too?

thanks,

greg k-h