Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp4363587pxf; Tue, 16 Mar 2021 11:32:55 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwQS1PCfq7vOVVIHRmSvj0grxjAYqjZ6BSrRkA5DoCiCBQ+uyuy8cYyaUf+B9RRoCwWDFcH X-Received: by 2002:aa7:d656:: with SMTP id v22mr37224216edr.119.1615919575038; Tue, 16 Mar 2021 11:32:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1615919575; cv=none; d=google.com; s=arc-20160816; b=tEq24YaGQrGX9ZnM7wJkAS6/ctPtCPWiHR576f52BSNFdskSNV0Kw4F4jKphLjPFUf qLTi21hpdPUsv/KweaDEh1WDMu6vc86/MQE+37+osVNTErujFnUcqiLdTzIkER5oC9EW JKkMHTMpJXzIhBhZHnvqTd5irUAXhUE/m3cjz270opuq10o0XS5IK7gCDCvCilkc233A 0fr2NCcKx4ZW5uHNI2fdgWFT6oFUQMQROBYXnI7U6BFYbNtRYhZcJnhmjb6LWwWAQ3sS vuVjzA6O6L8weA4H/6LIZEIOiu6UiiPHwZcNn1VzC4owAdHhew1aTikQ/FAOXk8zLR2U i6Tw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject; bh=OFtX+PIKrPWVjHh7uzVfH7+KsCwnQmpBgFHLcwaMAvs=; b=t7+3KmNcTc6QVtb3qFfa3EL83Eq7C0fboJom1bfmyjv2CyPNxT+vvRn3AdJwUEatPa gbNvRaCj3TXR+yHJaV1/xijCJTR+zWUSwTdQNojTS7Iv3WsPIgZnGnloO7UOZauwT347 KZNnBTU35OkJyp6u5F1wly2bADj7ocDRsQVvpYHM9QSWUDBBSBKhVCxtOyn+StAKAMdn 82IczuNB1CSDnEet1Kj0p72XnPwx2ydK3QeSGFYvbBmrop3rQFQl0zTYrvjrx5oB+AUF P4YLOE6f2QlUD1rTFa79Rh6UjFdM88aEPrVKu+2MBbaTJUni1KnvVZuZ0DAGjkzf6c5K ky9A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id mm13si14208387ejb.160.2021.03.16.11.32.31; Tue, 16 Mar 2021 11:32:55 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233190AbhCPLJa (ORCPT + 99 others); Tue, 16 Mar 2021 07:09:30 -0400 Received: from szxga05-in.huawei.com ([45.249.212.191]:13961 "EHLO szxga05-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233480AbhCPLJI (ORCPT ); Tue, 16 Mar 2021 07:09:08 -0400 Received: from DGGEMS408-HUB.china.huawei.com (unknown [172.30.72.59]) by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4F09V56rSBzrXBF; Tue, 16 Mar 2021 19:07:09 +0800 (CST) Received: from [10.136.110.154] (10.136.110.154) by smtp.huawei.com (10.3.19.208) with Microsoft SMTP Server (TLS) id 14.3.498.0; Tue, 16 Mar 2021 19:08:58 +0800 Subject: Re: [PATCH v3] f2fs: allow to change discard policy based on cached discard cmds To: Sahitya Tummala , Jaegeuk Kim , CC: References: <1615886958-717-1-git-send-email-stummala@codeaurora.org> From: Chao Yu Message-ID: <3c453b72-892f-7044-2edd-224b82202608@huawei.com> Date: Tue, 16 Mar 2021 19:08:58 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <1615886958-717-1-git-send-email-stummala@codeaurora.org> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.136.110.154] X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2021/3/16 17:29, Sahitya Tummala wrote: > With the default DPOLICY_BG discard thread is ioaware, which prevents > the discard thread from issuing the discard commands. On low RAM setups, > it is observed that these discard commands in the cache are consuming > high memory. This patch aims to relax the memory pressure on the system > due to f2fs pending discard cmds by changing the policy to DPOLICY_FORCE > based on the nm_i->ram_thresh configured. > > Signed-off-by: Sahitya Tummala Reviewed-by: Chao Yu Thanks,