Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Mihai Carabas <mihai.carabas@oracle.com>
To:     linux-kernel@vger.kernel.org
Cc:     gregkh@linuxfoundation.org, arnd@arndb.de,
        bobo.shaobowang@huawei.com, rdunlap@infradead.org,
        Mihai Carabas <mihai.carabas@oracle.com>
Subject: [PATCH v5 2/3] misc/pvpanic: probe multiple instances
Date:   Tue, 16 Mar 2021 14:20:28 +0200
Message-Id: <1615897229-4055-3-git-send-email-mihai.carabas@oracle.com>
In-Reply-To: <1615897229-4055-1-git-send-email-mihai.carabas@oracle.com>
References: <1615897229-4055-1-git-send-email-mihai.carabas@oracle.com>
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from mihai.localdomain (138.3.200.25) by BYAPR11CA0045.namprd11.prod.outlook.com (2603:10b6:a03:80::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3955.18 via Frontend Transport; Tue, 16 Mar 2021 13:08:26 +0000
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 8c1730f5-798b-407e-aa74-08d8e87c969a
X-MS-TrafficTypeDiagnostic: CO1PR10MB4435:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <CO1PR10MB4435E3636A6BE904B9C7F33E886B9@CO1PR10MB4435.namprd10.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:2582;
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 4+8IHUKFwy6J6qmzzJmNh5y4nEggb5gWe04qfRxKXtaa0QUYsItjVKbhX4brH97JBeeuXdN9iq24XlM1DRrutNSiAPWFlU5vL9PtkL4Y9cHGYA3NGKcW02oku0XsMccX1tmy9zIRYvsQ+6Vbs4m5AEWY6Ni1BqXsRFXcgTufpzHhytomqrrxroaP5vBCsLdSIw11dYCEW+QvarA3U7XSf4Y//bhL9aGtFCR8kldMVraqMNPW0+qiPdUkIkpsZdNU051zPLKnLdmHRoqpwTe0pgC9s/IfrMeob4itCXfEP6FjJTcl/27+whR1Pkb3w2XvMcgO65jkDFxrQDXjLjJ+nO8zJ8m7fcxIFTvC/2XpWjzBHKvIvUP/PEOgolwMnjCvf2SdZay8K4bDLdneObJbWuHaRqihgGVElFSN4x/vE0IeH4folQL+uff0ZkL+9ZhqTygK8qvsHLJMWE15tyY9DJybmt//05XsgbKmDqp/uhcWvRo8UXdoV0+b6/XiBfO5EVNZ+k3mt0EGNRPhoAcClIN/Ouaop7/+2s/LvLDEORWpogiohEwRI34r8M77r8f3
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR1001MB2285.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(376002)(39860400002)(346002)(396003)(366004)(136003)(36756003)(2616005)(956004)(44832011)(8936002)(6916009)(107886003)(83380400001)(52116002)(6486002)(186003)(16526019)(6506007)(66556008)(66946007)(66476007)(478600001)(86362001)(4326008)(8676002)(26005)(5660300002)(316002)(6512007)(2906002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData: =?us-ascii?Q?nkpr4AVqZz6uj7uDKsT9j4QTiZB454PMUl3h0ylYSxD1vNkRZFswVIMg7IFy?=
 =?us-ascii?Q?MoTxcEB5xViTihq6JfNTkNG50P4NTr+Aa2uLE2VvZ6cdHFAleRUcuOeP6jlG?=
 =?us-ascii?Q?c5zIBzpRWy+LpAXKaRHP6GlX6PmsioUk5X6naR9UvYUFlAW5JJF2PH10uL8n?=
 =?us-ascii?Q?C5sqNJ8HX3MKbiMgyR619P7/NcGadVF6E0mp3eGrydfk7Y+dnZZ9jELjFXbZ?=
 =?us-ascii?Q?NP3ciSAlEcP/efIJexyIDtRH/uXab7wrDUrvEqzOUFP5kpHvTE6vuAU4I22G?=
 =?us-ascii?Q?05DcaUxOvZsPvqpk1o1QkVAEPVoxmiVwz3sPFYgTHlVGgDQgM2/Oc5Id2ahG?=
 =?us-ascii?Q?gDOPPkrIX0FhZUqnLIjjbbsL9MmVDst91efs34eS1uYY4smxDwPk4TzvpSkp?=
 =?us-ascii?Q?BBM+vRP8GQTWAEg2qwqadrPMZscEddkx2KotGv2WKAHzjwV4e0qpXyLqB8qP?=
 =?us-ascii?Q?9QeKFJvHOURPAJ499R/GQtzlRma1AW8fL3slmHfLg7hA3jkkD4RZtQZloa65?=
 =?us-ascii?Q?hciCau9S4J+g4uV0QRqlrKJeRPPlGAfS60kMDkAaWW5XCp0nR+EfATJ4VZbD?=
 =?us-ascii?Q?g9Q45FB9oX3Kz3FdzcVEV0pdRpTkNAyQMpU8GKZQKtt8IJ6hGry9QneBENIO?=
 =?us-ascii?Q?/60SvlvI3CYv42+MMcSgjyorg0dKyroOPeRgexMCvcDqcXeDkCxSLgDJNhhS?=
 =?us-ascii?Q?R4FEUvzNUWdaJE8Key2BwIr3Lq834R6Nm55FLORd9yE5t65IB78lSWP+KWNf?=
 =?us-ascii?Q?Mx/4rR1dPUAdi9IOfHadMP/xJ0uzaex9jJpVARe90q/dxbGsNbhvd6DeVg9e?=
 =?us-ascii?Q?nOICxuLXEFq39w+D06f8RrdzdjZil0eLYSjp2HCl4WUyyHN/q33YdtwTct8j?=
 =?us-ascii?Q?WBaObQZDy/Y/AyS9ZtoAuJCE6MjnXf4RZZhOhfb6wpKMwxLZAZucEWc2YYJH?=
 =?us-ascii?Q?jTC2pEIdPROmNitVdOZ5Mq0q5QKYYwEy58nXnfbUQPqeWrxEkQJlHc79P483?=
 =?us-ascii?Q?iVXu6SOBBdJW0oK+w6EckpCiaK3xJxjtk/B3+9PXNQXyztUJdZzD45WCBXDP?=
 =?us-ascii?Q?9lMjuZkqYySEjdy+rKOGrOnh7/tkcLdItkhgvrqoYj6OT/whylxbYZIHlCZD?=
 =?us-ascii?Q?rWyPtWPvBT/f3s+m+3OTU1F8M9Yh/fHuH/lNkG34RJoxOrbGrZdLrTW8Vpve?=
 =?us-ascii?Q?nWvww2PuIGCBCe+MvSPDnsBgTeQ4H352Jmw/JCerY/ltiDFPvntxBJoHJAZF?=
 =?us-ascii?Q?O5Hg2xPpkJi3U9ho4Fpx1GMn8PY35kjK6ECU8f1NH4v79lP7U1jZ28tWwm04?=
 =?us-ascii?Q?dTf0nZv0EkIFVQ7A8DBHOgak?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8c1730f5-798b-407e-aa74-08d8e87c969a
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2285.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Mar 2021 13:08:27.4551
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: lLHR1Ym74otWLY4D7ErVP64NBcnwekB+GAHnA9+sX4Z8O9hp7hpZ/ulNS1GKh+6UsJdWf9HpNbYFyjAQnET3h5+lYJJK/XeRpzIj0QR513I=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR10MB4435
X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9924 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 spamscore=0 bulkscore=0
 malwarescore=0 adultscore=0 mlxscore=0 mlxlogscore=999 phishscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000
 definitions=main-2103160089
X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9924 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 mlxlogscore=999
 spamscore=0 mlxscore=0 bulkscore=0 suspectscore=0 priorityscore=1501
 lowpriorityscore=0 clxscore=1015 adultscore=0 phishscore=0 impostorscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000
 definitions=main-2103160089
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Create the mecahism that allows multiple pvpanic instances to call
pvpanic_probe and receive panic events. A global list will retain all the
mapped addresses where to write panic events.

Signed-off-by: Mihai Carabas <mihai.carabas@oracle.com>
---
 drivers/misc/pvpanic/pvpanic-mmio.c |  11 ++--
 drivers/misc/pvpanic/pvpanic.c      | 105 +++++++++++++++++++++++++++++-------
 drivers/misc/pvpanic/pvpanic.h      |   6 +--
 3 files changed, 92 insertions(+), 30 deletions(-)

diff --git a/drivers/misc/pvpanic/pvpanic-mmio.c b/drivers/misc/pvpanic/pvpanic-mmio.c
index 801d892..62ab8d7 100644
--- a/drivers/misc/pvpanic/pvpanic-mmio.c
+++ b/drivers/misc/pvpanic/pvpanic-mmio.c
@@ -54,7 +54,7 @@ static ssize_t events_store(struct device *dev,  struct device_attribute *attr,
 
 	events = tmp;
 
-	pvpanic_set_events(events);
+	pvpanic_set_events(base, events);
 
 	return count;
 
@@ -72,7 +72,6 @@ static int pvpanic_mmio_probe(struct platform_device *pdev)
 {
 	struct device *dev = &pdev->dev;
 	struct resource *res;
-	void __iomem *base;
 
 	res = platform_get_mem_or_io(pdev, 0);
 	if (!res)
@@ -97,17 +96,13 @@ static int pvpanic_mmio_probe(struct platform_device *pdev)
 	capability &= ioread8(base);
 	events = capability;
 
-	pvpanic_probe(base, capability);
-
-	return 0;
+	return pvpanic_probe(base, capability);
 }
 
 static int pvpanic_mmio_remove(struct platform_device *pdev)
 {
 
-	pvpanic_remove();
-
-	return 0;
+	return pvpanic_remove(base);
 }
 
 static const struct of_device_id pvpanic_mmio_match[] = {
diff --git a/drivers/misc/pvpanic/pvpanic.c b/drivers/misc/pvpanic/pvpanic.c
index 11d029c..73a82d9 100644
--- a/drivers/misc/pvpanic/pvpanic.c
+++ b/drivers/misc/pvpanic/pvpanic.c
@@ -14,20 +14,35 @@
 #include <linux/module.h>
 #include <linux/platform_device.h>
 #include <linux/types.h>
+#include <linux/cdev.h>
+#include <linux/list.h>
+#include <linux/slab.h>
 
 #include <uapi/misc/pvpanic.h>
 
 #include "pvpanic.h"
 
-static void __iomem *base;
-static unsigned int capability;
-static unsigned int events;
+struct pvpanic_instance {
+	void __iomem *base;
+	unsigned int capability;
+	unsigned int events;
+	struct list_head list;
+};
+
+struct list_head pvpanic_list;
+spinlock_t pvpanic_lock;
 
 static void
 pvpanic_send_event(unsigned int event)
 {
-	if (event & capability & events)
-		iowrite8(event, base);
+	struct pvpanic_instance *pi_cur;
+
+	spin_lock(&pvpanic_lock);
+	list_for_each_entry(pi_cur, &pvpanic_list, list) {
+		if (event & pi_cur->capability & pi_cur->events)
+			iowrite8(event, pi_cur->base);
+	}
+	spin_unlock(&pvpanic_lock);
 }
 
 static int
@@ -49,29 +64,81 @@
 	.priority = 1, /* let this called before broken drm_fb_helper */
 };
 
-void pvpanic_probe(void __iomem *pbase, unsigned int dev_cap)
+int pvpanic_probe(void __iomem *pbase, unsigned int dev_cap)
 {
-	base = pbase;
-	capability = dev_cap;
-	events = capability;
+	struct pvpanic_instance *pi;
+
+	if (!pbase)
+		return -EINVAL;
+
+	pi = kmalloc(sizeof(*pi), GFP_ATOMIC);
+	if (!pi)
+		return -ENOMEM;
+
+	pi->base = pbase;
+	pi->capability = dev_cap;
+	pi->events = dev_cap;
+	spin_lock(&pvpanic_lock);
+	list_add(&pi->list, &pvpanic_list);
+	spin_unlock(&pvpanic_lock);
 
-	if (capability)
-		atomic_notifier_chain_register(&panic_notifier_list,
-					       &pvpanic_panic_nb);
+	return 0;
 }
 EXPORT_SYMBOL_GPL(pvpanic_probe);
 
-void pvpanic_remove(void)
+int pvpanic_remove(void __iomem *pbase)
 {
-	if (capability)
-		atomic_notifier_chain_unregister(&panic_notifier_list,
-						 &pvpanic_panic_nb);
-	base = NULL;
+	struct pvpanic_instance *pi_cur, *pi_next;
+
+	if (!pbase)
+		return -EINVAL;
+
+	spin_lock(&pvpanic_lock);
+	list_for_each_entry_safe(pi_cur, pi_next, &pvpanic_list, list) {
+		if (pi_cur->base == pbase) {
+			list_del(&pi_cur->list);
+			kfree(pi_cur);
+			break;
+		}
+	}
+	spin_unlock(&pvpanic_lock);
+
+	return 0;
 }
 EXPORT_SYMBOL_GPL(pvpanic_remove);
 
-void pvpanic_set_events(unsigned int dev_events)
+
+void pvpanic_set_events(void __iomem *pbase, unsigned int dev_events)
 {
-	events = dev_events;
+	struct pvpanic_instance *pi_cur;
+
+	spin_lock(&pvpanic_lock);
+	list_for_each_entry(pi_cur, &pvpanic_list, list) {
+		if (pi_cur->base == pbase)
+			pi_cur->events = dev_events;
+	}
+	spin_unlock(&pvpanic_lock);
+
 }
 EXPORT_SYMBOL_GPL(pvpanic_set_events);
+
+static int pvpanic_init(void)
+{
+	INIT_LIST_HEAD(&pvpanic_list);
+	spin_lock_init(&pvpanic_lock);
+
+	atomic_notifier_chain_register(&panic_notifier_list,
+				       &pvpanic_panic_nb);
+
+	return 0;
+}
+
+static void pvpanic_exit(void)
+{
+	atomic_notifier_chain_unregister(&panic_notifier_list,
+					 &pvpanic_panic_nb);
+
+}
+
+module_init(pvpanic_init);
+module_exit(pvpanic_exit);
diff --git a/drivers/misc/pvpanic/pvpanic.h b/drivers/misc/pvpanic/pvpanic.h
index 0e90f4a..e1d15fd 100644
--- a/drivers/misc/pvpanic/pvpanic.h
+++ b/drivers/misc/pvpanic/pvpanic.h
@@ -14,8 +14,8 @@
 
 #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
 
-void pvpanic_probe(void __iomem *base, unsigned int dev_cap);
-void pvpanic_remove(void);
-void pvpanic_set_events(unsigned int dev_events);
+int pvpanic_probe(void __iomem *base, unsigned int dev_cap);
+int pvpanic_remove(void __iomem *base);
+void pvpanic_set_events(void __iomem *base, unsigned int dev_events);
 
 #endif /* PVPANIC_H_ */
-- 
1.8.3.1