Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp4436240pxf; Tue, 16 Mar 2021 13:28:14 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxj8j58lpIMfAO8r8eT2BtX9ll4n8f1z7Ur3X4NnGREhilvRFgKHum6kAWkybK3saOZuYRy X-Received: by 2002:aa7:dc4e:: with SMTP id g14mr38744909edu.114.1615926494530; Tue, 16 Mar 2021 13:28:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1615926494; cv=none; d=google.com; s=arc-20160816; b=LCy4TCqQiAFCMrkP++LLaXNYNmL25zRoUGnQxvN7iuUwmQ1EYFo8fTI8d2U1jhhlZh BwQoS3Vy8eYtU5tWjFQOSS4DOT+yRy5Wfxk+r/McsxJO/K4/fCALXlYggnJWemsqbi1F WzWUAoj/cCTKcGMlw8DKJfFMzcVGVtvhgmly7+oDHCFCA/lkvqjRxSI/G6V5TYxagAG3 GFwPzjgqYB8F83FxEwH+4l3KSA/gJYh70NQgVVxCWxVWxMtBu5VEXhBWH4xu7Vh24mxC 0Fj7jOkxE+lySp/GK2fg7/W2+Zsmc+t38K3yQBizHRlB4O+D0ks9GR7etDQu7dYjNkRv lCzQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=v0MQftmjchfDyMC/gsPtVSaYN1KMEK0Xi5b0nN0zZoY=; b=PAGnvN2XekJ8j1S6FTXioVWbDJjKq5+qmVP4x38r3xCGGvp+M/cJ/60sq+arGvCl0n yVARXADpueH3NacqnpOkf+a2GMQQiSJ4TKTGihhvtin0WuucxHNx3XZ/CQnS7Zz6n+Tf NHQpUlrJ6zyeDfapavkFQha/jsCC/0m6LYEoLWJ99vlJGXv9LwqHXWEExazz/SBEIUYC 9ZFCOqG84aX1ziFXi8OKnAGm91HCk5UrkVMj7Fu+fATpouJFAd4jE/2rjIxS2hcky/nm eBdTY6+wX5VGOCGUbZAHyE94bDTWLlkVECbQF1tGIOJVkJCzpx5KM6akepjX+zI/Yl5Q zcmQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=d2iQ8AfM; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id u5si13925182ejg.130.2021.03.16.13.27.52; Tue, 16 Mar 2021 13:28:14 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=d2iQ8AfM; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235097AbhCPNvD (ORCPT + 99 others); Tue, 16 Mar 2021 09:51:03 -0400 Received: from mail.kernel.org ([198.145.29.99]:55742 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229598AbhCPNud (ORCPT ); Tue, 16 Mar 2021 09:50:33 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 118C165053; Tue, 16 Mar 2021 13:50:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1615902632; bh=v0MQftmjchfDyMC/gsPtVSaYN1KMEK0Xi5b0nN0zZoY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=d2iQ8AfMIkcRJMiwCyMDrEYQ+fm2BuhcqJBrRDiqtLgZgbWR6A2s9flaTfKez135q fdSRDHEXaqaWbIV5WoEHS3ARyh4Y+xL3xUNi+zW+teWI8G+pe/bpgpB0d/TPgyrk6V 2b9m5gDUqiCoIqZ8pj5Z10mELK7htU7kbHpvYxm+T3euNlvollP5cYdBCrg5C58Sex 0Zj6ic7R1OD5C9FtTyl+m4G1jnOaHtZqmbQgBxRQbWgCljhiYenYXdhL9g1ancsbm/ mhS9jEwKaQr+8wwBBQPfjhRhVSFyl0ruRGkoOxu3DHt0qNO+TMQcwsp0w81WV5q+rL s3pH4/TS+Yk8Q== Date: Tue, 16 Mar 2021 13:49:15 +0000 From: Mark Brown To: Viorel Suman Cc: "S.j. Wang" , "alsa-devel@alsa-project.org" , "timur@kernel.org" , "Xiubo.Lee@gmail.com" , "linuxppc-dev@lists.ozlabs.org" , "tiwai@suse.com" , "lgirdwood@gmail.com" , "nicoleotsuka@gmail.com" , "festevam@gmail.com" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] ASoC: fsl_sai: remove reset code from dai_probe Message-ID: <20210316134915.GB4309@sirena.org.uk> References: <1615886826-30844-1-git-send-email-shengjiu.wang@nxp.com> <20210316125839.GA4309@sirena.org.uk> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="7iMSBzlTiPOCCT2k" Content-Disposition: inline In-Reply-To: X-Cookie: Results vary by individual. User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --7iMSBzlTiPOCCT2k Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Mar 16, 2021 at 01:42:40PM +0000, Viorel Suman wrote: > To me it makes sense to manage the clocks and reset from the same place. > Currently we have the clocks management moved completely into runtime PM > fsl_sai_runtime_resume and fsl_sai_runtime_suspend callbacks.=20 Usually the pattern is to have probe() leave everything powered up then let runtime PM power things down if it's enabled, you can often do the power up by having an open coded call to the resume callback in probe(). --7iMSBzlTiPOCCT2k Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmBQt1oACgkQJNaLcl1U h9BD2gf8CYq0baSLf4YPI5H7xjw4JepkHBJKPXid4yN7feW5rEKKZIlNzYx5AYT5 jh10YF8ND602x/tBHwlqL2tNdjBFzSi4dT/1QapmOaS4NqEXPAWU97VUPECfxWLm 29HZ7+Kw4LfDE2PI/2sKnBYd0wE8w0l2prCM0Ms8JT4hVal8O53kgzjJ6+dzHfpe jisKXgGv8qtNVlK+6AMK3H+vs8ROYnTfiYTsFNR4XF1nrvGSxwwvM8KuJb+rYb5+ VNB58e4KMaolnwOyxf7QAQQpAAQ7gFl/GkRyXquIpeOlV2WER5v9N6rVV1DMpwII 0zlVO4v7O5Cts1nqzxxdfsUHu1yNjg== =3CXS -----END PGP SIGNATURE----- --7iMSBzlTiPOCCT2k--