Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp4437628pxf; Tue, 16 Mar 2021 13:30:43 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxlqL+/OBQKxtSCiqlh/jnZhURCN9vS7UZIkMpNZ0Oc9Wmqpt4BHYhF4PSwfyUXDktoh8OG X-Received: by 2002:a17:906:4055:: with SMTP id y21mr26539726ejj.507.1615926643204; Tue, 16 Mar 2021 13:30:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1615926643; cv=none; d=google.com; s=arc-20160816; b=zRoN6ME5j4pk1eiGxk77yrCxpXT5oUgDO5usVfYBNVuCVZLa6Zq7xXznBFWwcYGMY5 oKGd8djMoJjzAOewgbw4DrVFk/NXpzn/8vsJm6aTkZ7RprEDRtrzBjsZeUV45OBc7E6g 6Z/aBj2zEKgEzONlLUIBWV+GCGzuUevEcrMS3DVuGw0yZWY8JxYWt22uqik3ua645+Cw A2T3x7+lbma4Z8QgvpcP+qG2lwU242Oc8FQBve7BE/r6c14Qj1vT31cukxMnpiUGlO8G FoMouth0FeJ8NYQ7bmLDbYeup27DkoeH/f4P3EVHyzuauwOTENCYFxG14fSeVLyZ7EP4 RnCA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:robot-unsubscribe :robot-id:message-id:mime-version:references:in-reply-to:cc:subject :to:reply-to:sender:from:dkim-signature:dkim-signature:date; bh=00vj/oGI9J6csZrOK5auiX4d5Ugy0cCdUyH8sVEbrEc=; b=bmyD7sIkkf6FC/ZWbbHXmFJSbkfW6NzBOWwUY0cD602tT0qX6GxGiW2D+C5W6vG6wb 3EzkFSigpNaChWlJj7DQikLe8M7ZE7uAYTMOavObPOcaBZgWavsmqG0m9sSv6pz4LnLH JYsf+AU+q+eqvThcPfLakmQKDowbTOULPO+koapv89el9fG/nZxuIVLnwlf1MisDb+vc dbr8TZhjWkDhTixlva0ExBdiTuxRPCJ4KgOP9mA62aYgWkVBKuTvoGlgazRfOfBE4ojs DxLhBJgv7syZYBqSCwjaqYn72rVIsk5QdeFzsqp/peUv3e/bzoVpN44l2Gsew1Z8PJSg PsRA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=TrGt+b8R; dkim=neutral (no key) header.i=@linutronix.de header.s=2020e; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id s1si14213643ejf.199.2021.03.16.13.30.20; Tue, 16 Mar 2021 13:30:43 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=TrGt+b8R; dkim=neutral (no key) header.i=@linutronix.de header.s=2020e; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236051AbhCPOLB (ORCPT + 99 others); Tue, 16 Mar 2021 10:11:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47338 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236010AbhCPOKw (ORCPT ); Tue, 16 Mar 2021 10:10:52 -0400 Received: from galois.linutronix.de (Galois.linutronix.de [IPv6:2a0a:51c0:0:12e:550::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CCD0EC06174A; Tue, 16 Mar 2021 07:10:51 -0700 (PDT) Date: Tue, 16 Mar 2021 14:10:44 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1615903844; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=00vj/oGI9J6csZrOK5auiX4d5Ugy0cCdUyH8sVEbrEc=; b=TrGt+b8RLkK3rTCfs94yBGMCdsD1XiJGHweLzvmSpzpHN0ou56YwEG35kWL6VizgqPm6H2 S0FAAZJd3h6iQsx7eJj15INltVQADiNFVIJJMx5W7yRmYM6kg5yEudy5tohcZCnsmyQeGD L2hll0nnosOcx/ui/9U2Gt3eC7WmIkR0QarMRpihxcgoKV4nZK8I3fogENlOGOC63+us9Q 9eHIMSijw+4kD4fZZ2CVJICkVkwpAftVlbT+tUdPXONk/WNVHLMIOVRCsJHTzMhtjvx7M4 JGb2QVZPl55EE6vY8+JObMXIpWlOIkX+gPwHapOKpXfH8Duj3Y0h8nDdtc8+6Q== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1615903844; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=00vj/oGI9J6csZrOK5auiX4d5Ugy0cCdUyH8sVEbrEc=; b=4jDaNsY+m1PXT/CxGN38TEpsOT2QnjEg4RhKTVFwLqykDGVnNoBhUJA6cK8YDrqM4NSwCX zIu+yEI//aBbKyBQ== From: "tip-bot2 for Davidlohr Bueso" Sender: tip-bot2@linutronix.de Reply-to: linux-kernel@vger.kernel.org To: linux-tip-commits@vger.kernel.org Subject: [tip: irq/core] tasklet: Remove tasklet_kill_immediate Cc: Davidlohr Bueso , Thomas Gleixner , "Paul E. McKenney" , x86@kernel.org, linux-kernel@vger.kernel.org, maz@kernel.org In-Reply-To: <20210306213658.12862-1-dave@stgolabs.net> References: <20210306213658.12862-1-dave@stgolabs.net> MIME-Version: 1.0 Message-ID: <161590384415.398.14627173979951504972.tip-bot2@tip-bot2> Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The following commit has been merged into the irq/core branch of tip: Commit-ID: 3a0ade0c521a542f8a25e96ce8ea0dfaa532ac75 Gitweb: https://git.kernel.org/tip/3a0ade0c521a542f8a25e96ce8ea0dfaa532ac75 Author: Davidlohr Bueso AuthorDate: Sat, 06 Mar 2021 13:36:58 -08:00 Committer: Thomas Gleixner CommitterDate: Tue, 16 Mar 2021 15:06:31 +01:00 tasklet: Remove tasklet_kill_immediate Ever since RCU was converted to softirq, it has no users. Signed-off-by: Davidlohr Bueso Signed-off-by: Thomas Gleixner Acked-by: Paul E. McKenney Link: https://lore.kernel.org/r/20210306213658.12862-1-dave@stgolabs.net --- include/linux/interrupt.h | 1 - kernel/softirq.c | 32 -------------------------------- 2 files changed, 33 deletions(-) diff --git a/include/linux/interrupt.h b/include/linux/interrupt.h index 76f1161..2b98156 100644 --- a/include/linux/interrupt.h +++ b/include/linux/interrupt.h @@ -716,7 +716,6 @@ static inline void tasklet_enable(struct tasklet_struct *t) } extern void tasklet_kill(struct tasklet_struct *t); -extern void tasklet_kill_immediate(struct tasklet_struct *t, unsigned int cpu); extern void tasklet_init(struct tasklet_struct *t, void (*func)(unsigned long), unsigned long data); extern void tasklet_setup(struct tasklet_struct *t, diff --git a/kernel/softirq.c b/kernel/softirq.c index 9908ec4..8b44ab9 100644 --- a/kernel/softirq.c +++ b/kernel/softirq.c @@ -658,38 +658,6 @@ static void run_ksoftirqd(unsigned int cpu) } #ifdef CONFIG_HOTPLUG_CPU -/* - * tasklet_kill_immediate is called to remove a tasklet which can already be - * scheduled for execution on @cpu. - * - * Unlike tasklet_kill, this function removes the tasklet - * _immediately_, even if the tasklet is in TASKLET_STATE_SCHED state. - * - * When this function is called, @cpu must be in the CPU_DEAD state. - */ -void tasklet_kill_immediate(struct tasklet_struct *t, unsigned int cpu) -{ - struct tasklet_struct **i; - - BUG_ON(cpu_online(cpu)); - BUG_ON(test_bit(TASKLET_STATE_RUN, &t->state)); - - if (!test_bit(TASKLET_STATE_SCHED, &t->state)) - return; - - /* CPU is dead, so no lock needed. */ - for (i = &per_cpu(tasklet_vec, cpu).head; *i; i = &(*i)->next) { - if (*i == t) { - *i = t->next; - /* If this was the tail element, move the tail ptr */ - if (*i == NULL) - per_cpu(tasklet_vec, cpu).tail = i; - return; - } - } - BUG(); -} - static int takeover_tasklets(unsigned int cpu) { /* CPU is dead, so no lock needed. */