Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
Date:   Tue, 16 Mar 2021 14:46:36 +0100
From:   =?UTF-8?Q?Rafa=C5=82_Mi=C5=82ecki?= <rafal@milecki.pl>
To:     Geert Uytterhoeven <geert+renesas@glider.be>
Cc:     "David S . Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        Florian Fainelli <f.fainelli@gmail.com>,
        bcm-kernel-feedback-list@broadcom.com, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: broadcom: BCM4908_ENET should not default to y,
 unconditionally
In-Reply-To: <20210316133853.2376863-1-geert+renesas@glider.be>
References: <20210316133853.2376863-1-geert+renesas@glider.be>
User-Agent: Roundcube Webmail/1.4.10
Message-ID: <789a2fb70742de1cc0435f82a85d23c9@milecki.pl>
Content-Type: text/plain; charset=US-ASCII;
 format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 2021-03-16 14:38, Geert Uytterhoeven wrote:
> Merely enabling CONFIG_COMPILE_TEST should not enable additional code.
> To fix this, drop the automatic enabling of BCM4908_ENET.
> 
> Fixes: 4feffeadbcb2e5b1 ("net: broadcom: bcm4908enet: add BCM4908
> controller driver")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> Feel free to change to "default y if ARCH_BCM4908" and
> 
>     To fix this, restrict the automatic enabling of BCM4908_ENET to
>     ARCH_BCM4908.
> 
> if you think BCM4908 SoCs cannot be used without enabling this.

Yes, please make it
default y if ARCH_BCM4908
instead.