Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 16 Mar 2021 17:44:57 +0100
From:   Greg KH <gregkh@linuxfoundation.org>
To:     Mihai Carabas <mihai.carabas@oracle.com>
Cc:     linux-kernel@vger.kernel.org, arnd@arndb.de,
        bobo.shaobowang@huawei.com, rdunlap@infradead.org
Subject: Re: [PATCH v5 1/3] misc/pvpanic: split-up generic and platform
 dependent code
Message-ID: <YFDgictc4oFuJYc2@kroah.com>
References: <1615897229-4055-1-git-send-email-mihai.carabas@oracle.com>
 <1615897229-4055-2-git-send-email-mihai.carabas@oracle.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1615897229-4055-2-git-send-email-mihai.carabas@oracle.com>
Precedence: bulk

On Tue, Mar 16, 2021 at 02:20:27PM +0200, Mihai Carabas wrote:
> +#ifdef pr_fmt
> +#undef pr_fmt
> +#endif
> +
> +#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt

This isn't even needed given you do not have any pr_* calls in this
code.  As you shouldn't this is driver stuff, you should always use the
dev_* calls instead.

But you can delete that later, this is fine for now.  However generally
you do not set this value in a .h file, but rather in the individual .c
files if you really need it.

thanks,

greg k-h