Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp4460458pxf; Tue, 16 Mar 2021 14:12:45 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy1am857OgeFIVRdgZokBSBdvFqFlXH1B0JoBPIJN+3y09wDW3C/YslT566B7vSJz3pBGG0 X-Received: by 2002:aa7:de11:: with SMTP id h17mr5398209edv.83.1615929165689; Tue, 16 Mar 2021 14:12:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1615929165; cv=none; d=google.com; s=arc-20160816; b=ReJr4sWmMn3PT0OvpSZwWxFadiRXql78Us38F3z+Lps1FmDxs5rpOF5C95d0WSj4m8 aTyF6uz2hxn1TTjyzQ/iawgexzqyVyhzpLF5tJcYY3LwTG1eByzGfizREt+TwIMPse/3 lguCyuY6OM7F85jMg+OARuyxbERIZDl6S4i0lkfH4EgC/8irScw2IGRBsCyzAqFNErpu aK1bKYjG8CQDouP6eeR3BIkP9utARwXRq0nrMVJ/0Qk64VGbfErlk6aDdvwNQQEzputs lBNg7bYRpXwCgotczanKbxByhUlI0G0Pv5YAtsk2UqMhQd1XFYq1uxClhK7zyTnk7pMH 1GCA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:references:cc :to:from:subject; bh=IomRA/M/4PuWkhAtyL8zHSLWhs8JTfY1Xtp0kqSJkiw=; b=JBUk3UB+FWKNrrpmcW/tUlZnBfxwacIiOWlQOb6mA9lCtC8oCKz8cGvL9D6giz9Z9J nChEovh7DKWAZP4L3ZLL+LbgVQ0czhehzTp6GEhr06C4cK0S5leM7x1PlmNmp9zo3sk2 cCamvjVBG+J5dwe5pBLev7gURJfKvbo9OFDjrWRMs2Mi1/YmhyKdIpC6X/6x7LuRCnlG u0fC+hN5le6A72PouPkpADw5EFJTFR4HGx7OZ9pEEC6m07vHEknlRIRulFsQKo8sQ7p3 Fm1cE4MevLE8HfarbgCUNC6DUi+1SQesAQyoUn85bSEVWziZg0Eig0771vvgYIVEVaxG uSkw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id z18si14471977edx.124.2021.03.16.14.12.23; Tue, 16 Mar 2021 14:12:45 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239388AbhCPRrv (ORCPT + 99 others); Tue, 16 Mar 2021 13:47:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38420 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239341AbhCPRrU (ORCPT ); Tue, 16 Mar 2021 13:47:20 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F0CCFC061756 for ; Tue, 16 Mar 2021 10:47:19 -0700 (PDT) Received: from gallifrey.ext.pengutronix.de ([2001:67c:670:201:5054:ff:fe8d:eefb] helo=[IPv6:::1]) by metis.ext.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1lMDmo-0006fa-Dw; Tue, 16 Mar 2021 18:47:18 +0100 Subject: Re: [PATCH v3 0/3] watchdog: f71808e_wdt: migrate to new kernel API From: Ahmad Fatoum To: Wim Van Sebroeck , Guenter Roeck , linux-kernel@vger.kernel.org Cc: linux-watchdog@vger.kernel.org, kernel@pengutronix.de References: Message-ID: Date: Tue, 16 Mar 2021 18:47:17 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 2001:67c:670:201:5054:ff:fe8d:eefb X-SA-Exim-Mail-From: a.fatoum@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, On 04.02.21 18:00, Ahmad Fatoum wrote: > This series migrates the driver to the new kernel watchdog API and > then to the driver model. > > Main feedback from Guenther on v2 was that I need to split it up to > enable review. I have done so by removing the extra refactoring for > now and focused on the functional changes described above. The diff > is now much better readable. > > I tested it on a f81866. Gentle ping. > > v2 -> v3: > https://lore.kernel.org/linux-watchdog/20201020062112.6762-1-a.fatoum@pengutronix.de/ > - factored out identifier renaming again for easier review > - reordered commits > - removed refactoring that can go in later. Focusing now on kernel watchdog > API and platform device/driver migration > - removed platform_device_id and changed code to match by name > > v1 -> v2: > https://lore.kernel.org/linux-watchdog/20200611191750.28096-1-a.fatoum@pengutronix.de/ > - reworked to platform device/driver pair (Guenther) > - squashed identifier renaming into the patches that touch > the respective lines anyway > - fixed checkpatch.pl nitpicks (Guenther) > - fixed locally used variable declared without static (0-day) > - fixed unneded line break due to old line limit (Guenther) > - renamed struct fintek_wdog_data to struct fintek_wdt > > Ahmad Fatoum (3): > watchdog: f71808e_wdt: rename variant-independent identifiers appropriately > watchdog: f71808e_wdt: migrate to new kernel watchdog API > watchdog: f71808e_wdt: refactor to platform device/driver pair > > drivers/watchdog/Kconfig | 1 +- > drivers/watchdog/f71808e_wdt.c | 450 +++++++--------------------------- > 2 files changed, 100 insertions(+), 351 deletions(-) > > base-commit: 1048ba83fb1c00cd24172e23e8263972f6b5d9ac > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |