Message-ID: <4524106C.8010807@garzik.org>
Date: Wed, 04 Oct 2006 15:50:04 -0400
From: Jeff Garzik <jeff@garzik.org>
User-Agent: Thunderbird 1.5.0.7 (X11/20060913)
MIME-Version: 1.0
To: Frederik Deweerdt <deweerdt@free.fr>
CC: linux-kernel@vger.kernel.org, arjan@infradead.org, matthew@wil.cx,
       alan@lxorguk.ukuu.org.uk, akpm@osdl.org, rdunlap@xenotime.net,
       gregkh@suse.de
Subject: Re: [RFC PATCH] add pci_{request,free}_irq take #3
References: <20061004193229.GA352@slug>
In-Reply-To: <20061004193229.GA352@slug>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 815
Lines: 29

Frederik Deweerdt wrote:
> --- 2.6.18-mm3.orig/include/linux/interrupt.h
> +++ 2.6.18-mm3/include/linux/interrupt.h
> @@ -75,6 +75,13 @@ struct irqaction {
>  	struct proc_dir_entry *dir;
>  };
>  
> +#ifndef ARCH_VALIDATE_IRQ
> +static inline int is_irq_valid(unsigned int irq)
> +{
> +	return irq ? 1 : 0;
> +}
> +#endif /* ARCH_VALIDATE_IRQ */


I ACK everything except the above snippet.  I just don't think it's 
linux/interrupt.h material, sorry.

If a consensus of arch maintainers (i.e. not just willy) think it's 
fine, then I'm overruled, otherwise...

	Jeff


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/