Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
To:     "Gustavo A. R. Silva" <gustavoars@kernel.org>
Cc:     Sathya Prakash <sathya.prakash@broadcom.com>,
        Sreekanth Reddy <sreekanth.reddy@broadcom.com>,
        Suganath Prabu Subramani 
        <suganath-prabu.subramani@broadcom.com>,
        "James E.J. Bottomley" <jejb@linux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@oracle.com>,
        MPT-FusionLinux.pdl@broadcom.com, linux-scsi@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org
Subject: Re: [PATCH][next] scsi: mpt3sas: Replace unnecessary dynamic
 allocation with a static one
From:   "Martin K. Petersen" <martin.petersen@oracle.com>
Organization: Oracle Corporation
Message-ID: <yq1eege1mlt.fsf@ca-mkp.ca.oracle.com>
References: <20210310235951.GA108661@embeddedor>
Date:   Tue, 16 Mar 2021 23:32:41 -0400
In-Reply-To: <20210310235951.GA108661@embeddedor> (Gustavo A. R. Silva's
        message of "Wed, 10 Mar 2021 17:59:51 -0600")
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from ca-mkp.ca.oracle.com (138.3.200.58) by CH2PR12CA0020.namprd12.prod.outlook.com (2603:10b6:610:57::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3933.32 via Frontend Transport; Wed, 17 Mar 2021 03:32:45 +0000
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 7aacd207-01e9-4533-56ca-08d8e8f554cd
X-MS-TrafficTypeDiagnostic: PH0PR10MB4726:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <PH0PR10MB4726EA53DED7F66061B95B7C8E6A9@PH0PR10MB4726.namprd10.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:4941;
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: /4ZI6HsXegd0Mrqs8e+QHvA9KUyQ8o7JsFu2uRKvWINM62TABXf2sJbqbAVgaOcwcbe+VgGTnZSBsop2QrKQ2BM1PH1JZuEg1USOCptIdjyLEOtM2pB0rL7idqJnfGRl05Cu70JMe6PG/e9/FgKpTX5WNDXSXCvm3i2L56xoOTzkLzeqQnQ9qyNwLWrDa5AqBw9GgQf4rxlUu4xHJsDy1UP4DX5Ex+E9tQI3h4FJPAoDQ+qbO1KF8sAMwtNIDL8H1oO28B2Welne3hG9wXuWz+0+OREYIfG5Ia3rheqWVUahB6iClc6kjK2rGMvPzKkhiSGUmkG0ygcCc9XLqq8rXmAPx7+LCUD8NltdVeaCN5FWsXDWhJw/XaMVd30WNLodySWr/xT/ehfPGSWQTem+ivj/d4J0m87BLAE0iMxRn5JcwVv/AHQ+3JH+dj+TH9kqM3QsMHxZ+SUyI++2QBGd//y08HFtseI1cEgNer5x+jndI0A6Jy/QXVbZrdm1J9RzTV+YEuvaS9O3S6KhDihkk3p/abWTdyF9hwml3khmWFLHoIIWPkn3oYvABrQs+8cPI0APR5LNbwE8KciLCRzGMSqyG3uLHZqbALPy1X4X/0o=
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR10MB4759.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(346002)(136003)(39860400002)(396003)(376002)(366004)(316002)(6666004)(54906003)(5660300002)(478600001)(66946007)(4326008)(66556008)(66476007)(26005)(2906002)(7696005)(6916009)(8936002)(558084003)(52116002)(956004)(186003)(16526019)(55016002)(86362001)(8676002)(36916002)(32563001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData: =?us-ascii?Q?2MR2BQBzjBe3PvpSX8Vqj8GneHDNlEzPS+5r3EQDHwgqV1FG0/y3AaOJT+lv?=
 =?us-ascii?Q?bp/X5vXM76mzeNnk4fIDQ03NlAEMrCFTza2qtHaO6hbvXIIpWOQZR+0xhlPr?=
 =?us-ascii?Q?awJxs5jVOjWnft2cIqVrISpRTn5mIuzs0vqFp51xZj57hUcLwgYAzkNNbAXd?=
 =?us-ascii?Q?lrBJCalZhG0t2EzqG1kMhpRf8DLwnc49M0Rdm3MicsWh7vxscbzG2DsJ/AtV?=
 =?us-ascii?Q?m6LJ/rwRT2yC8tt6f88/+jP/TdOzFOwFL82wpkc3DNUmMqGvGmZbbcepltiZ?=
 =?us-ascii?Q?LUDAO7/1nlilqpXO1R8CS8If9e3zWpvdXW1AmLEa+lceyFTq5CvDyUgZqS7v?=
 =?us-ascii?Q?t9PRo+YO5tC8s20V+IsZWxrkLYIMRQNneb5rVBrLRegfdRyBJjHBLf7HVJOS?=
 =?us-ascii?Q?7Li5Cp2j8VRWFY8bNCY0IYz3whSx9J0KzFZ+AS//U5Vpu3/LGJmYlpg1UlH/?=
 =?us-ascii?Q?iXeiagqSdUXxFDnNYRRivFuyEXAWhKWZhip6Pbq6h+WnGyty+WtGjmQbaivd?=
 =?us-ascii?Q?H4MPyzFuQRtPmhdwrQ5nS1xNCmhZgoGCrtxDOL5Iv6FlBB01/ci4GlFTTAq0?=
 =?us-ascii?Q?PnIvhx/iIHjuylvVBqSh+fQ99NHwbpT8t1mv2JDOiGIWcF7884KOkWLdJjjb?=
 =?us-ascii?Q?cL7JsjTHESmdPd40E81CkHA5KZ9gxP0AJABntmcCC8v+MqecLNkGlYq6u03E?=
 =?us-ascii?Q?0fQC8e9Gy3SEWYOe2Z5MjNtCdVxJbI6smmAyQ7s0A2GSk7IWwpZOaH0XI515?=
 =?us-ascii?Q?V5q7S/09s73FLksUMN5K9Kf2ZKLGbd2IA5u7AsWQFe8HXQITLi4weIyM1u6P?=
 =?us-ascii?Q?1QsIRk+m27U21Xknos0s3pMHEZ1yMfWNIEPN91Oj+tf+CauaTSLbB6kRb7j9?=
 =?us-ascii?Q?0lTvRZsqITWpWV8ZSQgSmdpCdQgNA7/KF+N20PeH4yBvBnniFqaltZ3ImF/v?=
 =?us-ascii?Q?PgsyPrSyBMszzHst03DIg+goTT9EbxjVMglAbFFHjgrLsjWxfNjxAT7BhcDG?=
 =?us-ascii?Q?YP/94bOI0xB6g2OJjapHNt2sC8UVJU+zBtdvAHejJfRhdabQbkl+AqDasr24?=
 =?us-ascii?Q?CAThhdAsHOqzVwLSH1RRk3Wv4d8RYHCr+HXeg1svU0XY3HfBtgGTpFLmxAAx?=
 =?us-ascii?Q?6ejfPn/6tOIfWMHPBwt/JRHEbM13a+Eennq0G/jBmk5dPDWKPj4OnYwhnBPO?=
 =?us-ascii?Q?hH+yrb59/caqzZJ4zDJ3qCY6Yb9uDoO8wdCwCPXHt975e7n8oUx2P+OTMB+P?=
 =?us-ascii?Q?I4kEUpCxBXU+hVFpcT32URzg7SEKV5v3gUmAnboIw+yrcCYYOkFuCKPabaBI?=
 =?us-ascii?Q?vyGtgIgc3585L3hGkcSrQg/9?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7aacd207-01e9-4533-56ca-08d8e8f554cd
X-MS-Exchange-CrossTenant-AuthSource: PH0PR10MB4759.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Mar 2021 03:32:46.1444
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: aiSJYLuXwytUjFo4P6vOsi+zonzJl43l6WBfIdJwkSxGBpXs9mTNmnppvbcFpfE1+dVa8AEAekgcJZkf/kpcPQEtXKRmOxDM46rWX0rYb40=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR10MB4726
X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9925 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 spamscore=0 bulkscore=0
 malwarescore=0 adultscore=0 mlxscore=0 mlxlogscore=999 phishscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000
 definitions=main-2103170025
X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9925 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 suspectscore=0 adultscore=0
 spamscore=0 clxscore=1011 phishscore=0 malwarescore=0 priorityscore=1501
 bulkscore=0 mlxlogscore=999 lowpriorityscore=0 impostorscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000
 definitions=main-2103170025
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


Gustavo,

> Dynamic memory allocation isn't actually needed and it can be replaced
> by statically allocating memory for struct object io_unit_pg3 with 36
> hardcoded entries for its GPIOVal array.

Applied to 5.13/scsi-staging, thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering