Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 16 Mar 2021 20:36:04 -0700 (PDT)
Subject:     Re: [PATCH] riscv: fix bugon.cocci warnings
In-Reply-To: <alpine.DEB.2.22.394.2102281209040.2892@hadrien>
CC:     guoren@linux.alibaba.com, me@packi.ch, penberg@kernel.org,
        linux-kernel@vger.kernel.org, kbuild-all@lists.01.org
From:   Palmer Dabbelt <palmerdabbelt@google.com>
To:     julia.lawall@inria.fr
Message-ID: <mhng-7289c316-8cd4-4088-b899-f6d7347c7408@palmerdabbelt-glaptop>
Mime-Version: 1.0 (MHng)
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

On Sun, 28 Feb 2021 03:10:22 PST (-0800), julia.lawall@inria.fr wrote:
> From: kernel test robot <lkp@intel.com>
>
> Use BUG_ON instead of a if condition followed by BUG.
>
> Generated by: scripts/coccinelle/misc/bugon.cocci
>
> Fixes: c22b0bcb1dd0 ("riscv: Add kprobes supported")
> CC: Guo Ren <guoren@linux.alibaba.com>
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Julia Lawall <julia.lawall@inria.fr>
> ---
>
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> head:   5695e51619745d4fe3ec2506a2f0cd982c5e27a4
> commit: c22b0bcb1dd024cb9caad9230e3a387d8b061df5 riscv: Add kprobes supported
> :::::: branch date: 3 hours ago
> :::::: commit date: 6 weeks ago
>
>  kprobes.c |    3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> --- a/arch/riscv/kernel/probes/kprobes.c
> +++ b/arch/riscv/kernel/probes/kprobes.c
> @@ -256,8 +256,7 @@ int __kprobes kprobe_fault_handler(struc
>  		 * normal page fault.
>  		 */
>  		regs->epc = (unsigned long) cur->addr;
> -		if (!instruction_pointer(regs))
> -			BUG();
> +		BUG_ON(!instruction_pointer(regs));
>
>  		if (kcb->kprobe_status == KPROBE_REENTER)
>  			restore_previous_kprobe(kcb);

Thanks, this is on fixes.