Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <59cb30f5e5ac6d65427ceaadf1012b2ba8dbf66c.1615606143.git.sathyanarayanan.kuppuswamy@linux.intel.com>
 <20210317041342.GA19198@wunner.de>
In-Reply-To: <20210317041342.GA19198@wunner.de>
From:   Dan Williams <dan.j.williams@intel.com>
Date:   Tue, 16 Mar 2021 22:08:31 -0700
Message-ID: <CAPcyv4jxTcUEgcfPRckHqrUPy8gR7ZJsxDaeU__pSq6PqJERAQ@mail.gmail.com>
Subject: Re: [PATCH v2 1/1] PCI: pciehp: Skip DLLSC handling if DPC is triggered
To:     Lukas Wunner <lukas@wunner.de>
Cc:     Kuppuswamy Sathyanarayanan 
        <sathyanarayanan.kuppuswamy@linux.intel.com>,
        Bjorn Helgaas <bhelgaas@google.com>,
        Linux PCI <linux-pci@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        "Raj, Ashok" <ashok.raj@intel.com>,
        Keith Busch <kbusch@kernel.org>, knsathya@kernel.org,
        Sinan Kaya <okaya@kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Tue, Mar 16, 2021 at 9:14 PM Lukas Wunner <lukas@wunner.de> wrote:
>
> On Fri, Mar 12, 2021 at 07:32:08PM -0800, sathyanarayanan.kuppuswamy@linux.intel.com wrote:
> > +     if ((events == PCI_EXP_SLTSTA_DLLSC) && is_dpc_reset_active(pdev)) {
> > +             ctrl_info(ctrl, "Slot(%s): DLLSC event(DPC), skipped\n",
> > +                       slot_name(ctrl));
> > +             ret = IRQ_HANDLED;
> > +             goto out;
> > +     }
>
> Two problems here:
>
> (1) If recovery fails, the link will *remain* down, so there'll be
>     no Link Up event.  You've filtered the Link Down event, thus the
>     slot will remain in ON_STATE even though the device in the slot is
>     no longer accessible.  That's not good, the slot should be brought
>     down in this case.

Can you elaborate on why that is "not good" from the end user
perspective? From a driver perspective the device driver context is
lost and the card needs servicing. The service event starts a new
cycle of slot-attention being triggered and that syncs the slot-down
state at that time.

>
> (2) If recovery succeeds, there's a race where pciehp may call
>     is_dpc_reset_active() *after* dpc_reset_link() has finished.
>     So both the DPC Trigger Status bit as well as pdev->dpc_reset_active
>     will be cleared.  Thus, the Link Up event is not filtered by pciehp
>     and the slot is brought down and back up even though DPC recovery
>     was succesful, which seems undesirable.

The hotplug driver never saw the Link Down, so what does it do when
the slot transitions from Link Up to Link Up? Do you mean the Link
Down might fire after the dpc recovery has completed if the hotplug
notification was delayed?