Received: by 2002:a05:6520:3645:b029:c0:f950:43e0 with SMTP id l5csp178257lki; Tue, 16 Mar 2021 22:17:10 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz6C+nMhkVsMpk0kCHAF6t/dFvOEqadW3NG7sWXt1Z81pXdpkq62KTuMC4mg3XG+HtIpIJc X-Received: by 2002:a17:906:400b:: with SMTP id v11mr33156969ejj.194.1615958230401; Tue, 16 Mar 2021 22:17:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1615958230; cv=none; d=google.com; s=arc-20160816; b=gy7ZUJjo2tBrof2J5YN/kwrHPiKnCP4M3RqfRAp+l/7XsJtWBh3pY7yL0EyQbto3nV Wgq0fsbJS0likrNR42fmztGld+tt5orNt1BXkoJMryeazWDSxCfUa88E5+SM2/HaoeWU t5ZYIZ+LixfrvDIUooD4y88Dl+P0zCTS1ozAFg+pSrEyPqV/7xTZc6BNrUNf6lBEt4K/ oRnS8zXOLVOlMqU0NjUfNaVLppF5DxjCVQUEXPp7s3ZEcCl5O2CA9dSeYJVpwFmGM5SZ Yl7bnyL1eO5e2Pjwe5wWBrZvINIJ9MWa2iv6Ge+Ku4QgTQygpor5mpLQMiR87TZ0SlsF m/dQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=5rBSFsuz9Ootk2SK7oMUt2810Ur6oS46b7vpQlumXqQ=; b=RKBN2LFQkAEO1M5BDRnUUQF5o8MC3L+RaxpwxOfD3vhVvK9L2pGbmG5XpOjDgYwEus BiX4qTU+OHh5HQFobWw4FKFCyepFVo1jSh58qPpF28gZrx476j+VTCkDdtRAhmuc1Tcn GGW6IIg0m62yblKETTkKWJavLAfthUwZ2BI16AgQifn5QJQM7EhNoBhBV/bjiuSHKd0Z O8/unWk0qQGvwVzem+POG7Yh7rGhGDIjAUoAbSNz/Baxx0vVerRjijSqspKTKd3IKjPz i+ilXlC1CMZxBatTO4y/qJrhfDXRF5gzaL+23jpjLyNgiycjAIqDMpY53kHDVyXBiZnJ ZpRA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2020-01-29 header.b=JRW2PjKt; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id s15si15171431edd.547.2021.03.16.22.16.48; Tue, 16 Mar 2021 22:17:10 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2020-01-29 header.b=JRW2PjKt; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229492AbhCQFPK (ORCPT + 99 others); Wed, 17 Mar 2021 01:15:10 -0400 Received: from userp2120.oracle.com ([156.151.31.85]:38132 "EHLO userp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229707AbhCQFO6 (ORCPT ); Wed, 17 Mar 2021 01:14:58 -0400 Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 12H5DbO8152207; Wed, 17 Mar 2021 05:14:49 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=corp-2020-01-29; bh=5rBSFsuz9Ootk2SK7oMUt2810Ur6oS46b7vpQlumXqQ=; b=JRW2PjKtgmw+q9aPEs/2zQ3aU5io0C+id0bx8BYRlRaJiwhQjCgvbhX8jN7yktUYjZri Jmt7PaQHb3i7kJgXhZ0EI+SBmyrmHv7ulbPaA0disNYV/DZZP69NCHSBdDuaa1WYxLve BKxoNlPflkCZna5CrgESEWn+bMRXkt/8X37w61buhFHKbSg4vKXGaouzr3v9xi7Ran/D JTzGDCBSPIkK2zG2qfpBMkMIl3GhE5W+7sJiCpqaiLZj2NERq//z1MTVfkgdEmpAbFcr Yzso8SwtVj0nnlbKjFXM+A4WAS8r9csbRxGFKZWkwR9LrRBKzZnAuGu+l4jSRFI77ge7 Tw== Received: from aserp3020.oracle.com (aserp3020.oracle.com [141.146.126.70]) by userp2120.oracle.com with ESMTP id 378p1ntrva-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 17 Mar 2021 05:14:49 +0000 Received: from pps.filterd (aserp3020.oracle.com [127.0.0.1]) by aserp3020.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 12H59niG011400; Wed, 17 Mar 2021 05:14:47 GMT Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by aserp3020.oracle.com with ESMTP id 3797a24p0x-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 17 Mar 2021 05:14:47 +0000 Received: from abhmp0005.oracle.com (abhmp0005.oracle.com [141.146.116.11]) by userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id 12H5EYtv014394; Wed, 17 Mar 2021 05:14:36 GMT Received: from kadam (/102.36.221.92) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Tue, 16 Mar 2021 22:14:33 -0700 Date: Wed, 17 Mar 2021 08:14:26 +0300 From: Dan Carpenter To: Tong Zhang Cc: Ian Abbott , H Hartley Sweeten , Greg Kroah-Hartman , "Alexander A. Klimov" , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: comedi: das800: fix request_irq() warn Message-ID: <20210317051426.GX2087@kadam> References: <92b7c57b-b645-9965-8157-4ca76a803cba@mev.co.uk> <20210316224227.348310-1-ztong0001@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210316224227.348310-1-ztong0001@gmail.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-Proofpoint-IMR: 1 X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9925 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 adultscore=0 spamscore=0 mlxlogscore=999 bulkscore=0 malwarescore=0 phishscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2103170040 X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9925 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 suspectscore=0 adultscore=0 spamscore=0 clxscore=1011 phishscore=0 malwarescore=0 priorityscore=1501 bulkscore=0 mlxlogscore=999 lowpriorityscore=0 impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2103170040 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 16, 2021 at 06:42:26PM -0400, Tong Zhang wrote: > request_irq() wont accept a name which contains slash so we need to > repalce it with something else -- otherwise it will trigger a warning ^^^^^^^ I don't normally comment on spelling mistakes in the commit message but you're copy and pasting "repalce" over and over... > and the entry in /proc/irq/ will not be created > since the .name might be used by userspace and we don't want to break > userspace, so we are changing the parameters passed to request_irq() regards, dan carpenter