Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp99522pxf; Tue, 16 Mar 2021 23:50:11 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyssvsLZTkIJ2USv2tcdFbKdN/WPiaGln/2WbuGW0Qs6iZrYm+UrMIvE3zRnUxJc5oCtN9+ X-Received: by 2002:a17:906:2710:: with SMTP id z16mr34095744ejc.176.1615963811134; Tue, 16 Mar 2021 23:50:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1615963811; cv=none; d=google.com; s=arc-20160816; b=x7vSt2tmPz0w05teCTQWQYYxblpQH31nAnlWtH8BNwzlERFMH0Zux6LH+ld3jtagPi QiFrc1IZXhs0VG3zmStNoj7E9vYjR9dL4/PkpAl8+/iFghHPMmFyo4DPNah2olL5h7Np 0ITW87AoBn1W1rRyA8w9yN1TYZ90tzvDKAdJxLdd2ty0hTydLJv6W3yRZsH4Nv1HzZrg lr2BfgE8DtAJTfbvkXpW2/2kkuFW/8ZktjrZDtPS10GnoubbwuCR9JUrwUNv0CFD1t5z UleBgqO6mpCJ+NoPe9WM9p9CyerlLDecgdvlNWHVaGtGG7SOMeGlvXsc3pSSfT4kRUvJ A/LA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject; bh=9vg4Daq4jLgMybeym/3e1YQqCyVD5meNjnn/lzoRmng=; b=FqZE8GZ+024D8AVF3aD1pBay1Wk93y2UKN6Zxb2BzKrwiRdX6jKdFjSU2/Gd4uTCG0 X8lzCVccF8WDnlCHb2KB/8AW4VhSBsmUM77v/J/1+0vjrxLKtGVkFgv6kdrri5fCkPjy vN/roRt60ibuPJz5O13k6KQJds83G0T3dneWyF+46QwVB12PaFtrrhWfc6YWQ6GN4qZg OOL4L3jGy3nChl6YifAsCHVOJSxmL3w3RS8aqTi9MPN3y43RXK45XrUo9BOX7pbrt2Zl E2swIpNtvY9JLbUojYh37Yo1o902OzfqDa30AdQyipjzjUdpvlTzxvYjSZdlXAzIThOz Osfw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id u12si17796959eda.121.2021.03.16.23.49.48; Tue, 16 Mar 2021 23:50:11 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229712AbhCQGqC (ORCPT + 99 others); Wed, 17 Mar 2021 02:46:02 -0400 Received: from szxga06-in.huawei.com ([45.249.212.32]:13949 "EHLO szxga06-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230164AbhCQGp6 (ORCPT ); Wed, 17 Mar 2021 02:45:58 -0400 Received: from DGGEMS401-HUB.china.huawei.com (unknown [172.30.72.59]) by szxga06-in.huawei.com (SkyGuard) with ESMTP id 4F0gcS6v2fzkb8C; Wed, 17 Mar 2021 14:44:24 +0800 (CST) Received: from [10.136.110.154] (10.136.110.154) by smtp.huawei.com (10.3.19.201) with Microsoft SMTP Server (TLS) id 14.3.498.0; Wed, 17 Mar 2021 14:45:53 +0800 Subject: Re: [PATCH 2/2] erofs: use sync decompression for atomic contexts only To: Huang Jianan , CC: , , References: <20210317035448.13921-1-huangjianan@oppo.com> <20210317035448.13921-3-huangjianan@oppo.com> From: Chao Yu Message-ID: <62153424-198c-807e-cced-33dd90279174@huawei.com> Date: Wed, 17 Mar 2021 14:45:52 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20210317035448.13921-3-huangjianan@oppo.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.136.110.154] X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2021/3/17 11:54, Huang Jianan via Linux-erofs wrote: > Sync decompression was introduced to get rid of additional kworker > scheduling overhead. But there is no such overhead in non-atomic > contexts. Therefore, it should be better to turn off sync decompression > to avoid the current thread waiting in z_erofs_runqueue. > > Signed-off-by: Huang Jianan > Signed-off-by: Guo Weichao > Reviewed-by: Gao Xiang Reviewed-by: Chao Yu Thanks,