Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp133980pxf; Wed, 17 Mar 2021 01:00:04 -0700 (PDT) X-Google-Smtp-Source: ABdhPJycL6yGl7LwgLanmJ4vZrzNzuEtA9iWYQVTBmAGTrU1QWTX4dlrOs7qr9fVXehT6RvFc6+m X-Received: by 2002:a05:6402:1855:: with SMTP id v21mr40642618edy.310.1615968004281; Wed, 17 Mar 2021 01:00:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1615968004; cv=none; d=google.com; s=arc-20160816; b=KPWAC/XN7iQ8tFNugcTWAv9i0VOWwXoFWfIOMtdN2qOvQPes6ZmBjtYnqF+LyfUeqV w5te5EA5T8IqtcVzh4iy1sO7YkKxW/QJwOIawuRNU38AriZT8fdYNhHdDyxaKT+E66Oj KRo9M4WtQvXJV3ksAxvoROVmzVNhIXxK7C5PD6GX5OCvStoaKjeDiMtnHxW+gDpBLotH VYRL9WmzsQawzEVJYDQ0D+uofKnXii2eTk8AvazCl3xyiteEr1tUbF+zj4M+uhlOh8fb kHwyp0nM78rrYBDy785Fwz6uwB7TF8vYOAaS5Hnsn+LxvAvlkV5BLLGodQu/v0a2ZJjt 04xg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:references:in-reply-to:subject:cc:to:from :dkim-signature; bh=I20ao//jp0K+ljf1zyYRmUDybDGX4o2ZQ8hxDCPtACs=; b=oYVv4MgBfBEKjBXdJ8QQLunVYMGwCBwFe9JxdUUiGFwmadc3tgW376vyRFkA1suB/I oZItD5BSawm/B36at1xK+Va2yNlKNtZRIFDMn3Ae/rI0iJe08KRb3lonXEWy9oXZwuWL gdw55ZJVr7w5iXgiaowhE5FUExfnWjHfl6A4yoHQrImUgtFVgz/L9WrUd/15x3VjMflw VpEGqVs2nBdiCg7IRWFSLte7e+mQOZlrjWtPWryVPweKVlfR/YVqG1z4A8inLWMAC1ol WMomFlEYBAhuNtu2nIB1x0VyX8gvhPSOSlHELJn8reg3tFJlUCgWJme2P3gFoJY/6P/j XgiQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@axtens.net header.s=google header.b=grlmjP9c; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id g20si16593866edq.32.2021.03.17.00.59.42; Wed, 17 Mar 2021 01:00:04 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@axtens.net header.s=google header.b=grlmjP9c; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229707AbhCQH6k (ORCPT + 99 others); Wed, 17 Mar 2021 03:58:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53998 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229944AbhCQH6S (ORCPT ); Wed, 17 Mar 2021 03:58:18 -0400 Received: from mail-pj1-x1032.google.com (mail-pj1-x1032.google.com [IPv6:2607:f8b0:4864:20::1032]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A20DDC06174A for ; Wed, 17 Mar 2021 00:58:18 -0700 (PDT) Received: by mail-pj1-x1032.google.com with SMTP id t18so652933pjs.3 for ; Wed, 17 Mar 2021 00:58:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=axtens.net; s=google; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version:content-transfer-encoding; bh=I20ao//jp0K+ljf1zyYRmUDybDGX4o2ZQ8hxDCPtACs=; b=grlmjP9cLtgbJiOVVtTbtM9/sum9yzN6kUjg+qj2AT2HHoCwMg/hZ+ajTEmXhLd4Go 8IUt/u2OhcF0Lg0BI2M4P2BRFgLjpNL/Uf1kuek5vH0u5J1q6gEKYQWGCymwOT/Mg3W4 AXckl48lO3Q2vWc0mSuVaGOKfDPvABPsJIDaU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version:content-transfer-encoding; bh=I20ao//jp0K+ljf1zyYRmUDybDGX4o2ZQ8hxDCPtACs=; b=KNcuxgm/OrEiywOkp/PdGoVNT7/GJVs3gq3b3Ta+1HCSgRGKiyVRAbbD47pNul9G26 yzE/zD9Gzb/FNbkAEHSXwe95MHz1Ig9BMrU3cfwXR4YQ+whbqiR8pTlWpMrkM3bcZZBS TKUFa7AS8+L5Qz+wa9E4TYq4dKce8Jehs/6MVost+ajo4fbFzCINmH0QzWDoeDdombm2 uBXKMaPYD3+NJQt+NrwL1hoqV6mbwrxDcgBa3kKte6JmLH9a7XKVxfgY+diDj9p1UTyB 0zon9XgIrK7e1A5r2s86p5jgoZVpk+oLp+UpB7kXqj2MUB2N/W9XPuArjSgx7g4PT/d9 G9sw== X-Gm-Message-State: AOAM531DbGek/YdlhjuIIHYrry9fCwkg44IZtxlek8gf8PgEzFsoiYRs r7V9s/uVpKhnAGg4Td+h246DtA== X-Received: by 2002:a17:90a:ce0d:: with SMTP id f13mr3249699pju.85.1615967898257; Wed, 17 Mar 2021 00:58:18 -0700 (PDT) Received: from localhost (2001-44b8-1113-6700-13b2-19b2-2ae0-4d54.static.ipv6.internode.on.net. [2001:44b8:1113:6700:13b2:19b2:2ae0:4d54]) by smtp.gmail.com with ESMTPSA id nk3sm1717212pjb.17.2021.03.17.00.58.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Mar 2021 00:58:17 -0700 (PDT) From: Daniel Axtens To: "heying \(H\)" , mpe@ellerman.id.au, benh@kernel.crashing.org, paulus@samba.org, npiggin@gmail.com, akpm@linux-foundation.org, aneesh.kumar@linux.ibm.com, rppt@kernel.org, ardb@kernel.org, clg@kaod.org, christophe.leroy@csgroup.eu Cc: johnny.chenyi@huawei.com, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] powerpc: arch/powerpc/kernel/setup_64.c - cleanup warnings In-Reply-To: References: <20210316041148.29694-1-heying24@huawei.com> <87wnu6bhvi.fsf@dja-thinkpad.axtens.net> Date: Wed, 17 Mar 2021 18:58:14 +1100 Message-ID: <87tupab4a1.fsf@dja-thinkpad.axtens.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org "heying (H)" writes: > Thank you for your reply. > > > =E5=9C=A8 2021/3/17 11:04, Daniel Axtens =E5=86=99=E9=81=93: >> Hi He Ying, >> >> Thank you for this patch. >> >> I'm not sure what the precise rules for Fixes are, but I wonder if this >> should have: >> >> Fixes: 9a32a7e78bd0 ("powerpc/64s: flush L1D after user accesses") >> Fixes: f79643787e0a ("powerpc/64s: flush L1D on kernel entry") > > Is that necessary for warning cleanups? I thought 'Fixes' tags are=20 > needed only for > > bugfix patches. Can someone tell me whether I am right? Yeah, I'm not sure either. Hopefully mpe will let us know. Kind regards, Daniel > >> >> Those are the commits that added the entry_flush and uaccess_flush >> symbols. Perhaps one for rfi_flush too but I'm not sure what commit >> introduced that. >> >> Kind regards, >> Daniel >> >>> warning: symbol 'rfi_flush' was not declared. >>> warning: symbol 'entry_flush' was not declared. >>> warning: symbol 'uaccess_flush' was not declared. >>> We found warnings above in arch/powerpc/kernel/setup_64.c by using >>> sparse tool. >>> >>> Define 'entry_flush' and 'uaccess_flush' as static because they are not >>> referenced outside the file. Include asm/security_features.h in which >>> 'rfi_flush' is declared. >>> >>> Reported-by: Hulk Robot >>> Signed-off-by: He Ying >>> --- >>> arch/powerpc/kernel/setup_64.c | 5 +++-- >>> 1 file changed, 3 insertions(+), 2 deletions(-) >>> >>> diff --git a/arch/powerpc/kernel/setup_64.c b/arch/powerpc/kernel/setup= _64.c >>> index 560ed8b975e7..f92d72a7e7ce 100644 >>> --- a/arch/powerpc/kernel/setup_64.c >>> +++ b/arch/powerpc/kernel/setup_64.c >>> @@ -68,6 +68,7 @@ >>> #include >>> #include >>> #include >>> +#include >>>=20=20=20 >>> #include "setup.h" >>>=20=20=20 >>> @@ -949,8 +950,8 @@ static bool no_rfi_flush; >>> static bool no_entry_flush; >>> static bool no_uaccess_flush; >>> bool rfi_flush; >>> -bool entry_flush; >>> -bool uaccess_flush; >>> +static bool entry_flush; >>> +static bool uaccess_flush; >>> DEFINE_STATIC_KEY_FALSE(uaccess_flush_key); >>> EXPORT_SYMBOL(uaccess_flush_key); >>>=20=20=20 >>> --=20 >>> 2.17.1 >> .