Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   LI Qingwu <qing-wu.li@leica-geosystems.com.cn>
To:     Sebastian Reichel <sre@kernel.org>
CC:     "robh+dt@kernel.org" <robh+dt@kernel.org>,
        "pali@kernel.org" <pali@kernel.org>,
        "krzk@kernel.org" <krzk@kernel.org>, "afd@ti.com" <afd@ti.com>,
        "linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        TERTYCHNYI Grygorii <grygorii.tertychnyi@leica-geosystems.com>,
        ZHIZHIKIN Andrey <andrey.zhizhikin@leica-geosystems.com>
Subject: RE: [PATCH V5 0/2] power: bq27xxx: add bq78z100
Thread-Topic: [PATCH V5 0/2] power: bq27xxx: add bq78z100
Thread-Index: AQHXEYvBE1Tk4NaU40mHgN1zwl9D2aqENCwAgAOpFuA=
Date:   Wed, 17 Mar 2021 09:47:21 +0000
Message-ID: <DB7PR06MB45716430341BB83DAD60B01AD76A9@DB7PR06MB4571.eurprd06.prod.outlook.com>
References: <20210305064949.2680-1-Qing-wu.Li@leica-geosystems.com.cn>
 <20210314234202.xijndjgltdcyuggh@earth.universe>
In-Reply-To: <20210314234202.xijndjgltdcyuggh@earth.universe>
Accept-Language: zh-CN, en-US
Content-Language: zh-CN
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 0ca88166-a908-4b68-7b36-08d8e929a953
X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Mar 2021 09:47:21.5017
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 1b16ab3e-b8f6-4fe3-9f3e-2db7fe549f6a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: e79epFi2DVK29164+70UqaRhTxDBdc3l/AfUUeviC4wr6L5b3PdaxyqQ4qrOO1oDkxFt0dM/2ZllAow+bnpG0abhdcodyE26moCG4qaaNC/43JG0/5wXyVAbmij8OQ0N
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0601MB2408
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Sebastian,

Here is the dump of the "uevent", I tested two cases, discharging current >=
0 and discharging current =3D0.
If discharging current=3D0:
    POWER_SUPPLY_TIME_TO_EMPTY_NOW and POWER_SUPPLY_TIME_TO_FULL_NOW are di=
sappear,=20
    the value is "-ENODATA"
If discharging current>0:
    POWER_SUPPLY_TIME_TO_FULL_NOW is disappear,=20
    the value is "-ENODATA"
Since I can't test charging on our hardware, I think "POWER_SUPPLY_TIME_TO_=
FULL_NOW" will show up during charging, since the value is given by registe=
r 0x18 with index "BQ27XXX_REG_TTF".

TEST CASE I:  discharging current >0:
    POWER_SUPPLY_NAME=3Dbq78z100-0
    POWER_SUPPLY_STATUS=3DDischarging
    POWER_SUPPLY_PRESENT=3D1
    POWER_SUPPLY_VOLTAGE_NOW=3D3405000
    POWER_SUPPLY_CURRENT_NOW=3D4000
    POWER_SUPPLY_CAPACITY=3D28
    POWER_SUPPLY_CAPACITY_LEVEL=3DNormal
    POWER_SUPPLY_TEMP=3D259
    POWER_SUPPLY_TIME_TO_EMPTY_NOW=3D1611000
    POWER_SUPPLY_TECHNOLOGY=3DLi-ion
    POWER_SUPPLY_CHARGE_FULL=3D6494000
    POWER_SUPPLY_CHARGE_FULL_DESIGN=3D6000000
    POWER_SUPPLY_CYCLE_COUNT=3D1
    POWER_SUPPLY_ENERGY_NOW=3D0
    POWER_SUPPLY_POWER_AVG=3D65535
    POWER_SUPPLY_HEALTH=3DGood
    POWER_SUPPLY_MANUFACTURER=3DTexas Instruments

TEST CASE II : discharging current =3D0:
    POWER_SUPPLY_NAME=3Dbq78z100-0
    POWER_SUPPLY_STATUS=3DDischarging
    POWER_SUPPLY_PRESENT=3D1
    POWER_SUPPLY_VOLTAGE_NOW=3D3405000
    POWER_SUPPLY_CURRENT_NOW=3D0
    POWER_SUPPLY_CAPACITY=3D28
    POWER_SUPPLY_CAPACITY_LEVEL=3DNormal
    POWER_SUPPLY_TEMP=3D260
    POWER_SUPPLY_TECHNOLOGY=3DLi-ion
    POWER_SUPPLY_CHARGE_FULL=3D6494000
    POWER_SUPPLY_CHARGE_FULL_DESIGN=3D6000000
    POWER_SUPPLY_CYCLE_COUNT=3D1
    POWER_SUPPLY_ENERGY_NOW=3D0
    POWER_SUPPLY_POWER_AVG=3D0
    POWER_SUPPLY_HEALTH=3DGood
    POWER_SUPPLY_MANUFACTURER=3DTexas Instruments


Best Regards

Li Qingwu (Terry)


Best Regards

Li Qingwu (Terry)


-----Original Message-----
From: Sebastian Reichel <sre@kernel.org>=20
Sent: Monday, March 15, 2021 7:42 AM
To: LI Qingwu <qing-wu.li@leica-geosystems.com.cn>
Cc: robh+dt@kernel.org; pali@kernel.org; krzk@kernel.org; afd@ti.com; linux=
-pm@vger.kernel.org; devicetree@vger.kernel.org; linux-kernel@vger.kernel.o=
rg; TERTYCHNYI Grygorii <grygorii.tertychnyi@leica-geosystems.com>; ZHIZHIK=
IN Andrey <andrey.zhizhikin@leica-geosystems.com>
Subject: Re: [PATCH V5 0/2] power: bq27xxx: add bq78z100

Hi,

On Fri, Mar 05, 2021 at 06:49:47AM +0000, LI Qingwu wrote:
> Changes in V5:
>=20
> 1. Change [BQ27XXX_REG_TTES] from INVALID_REG_ADDR to 0x1c, the=20
> StandbyTimeToEmpty command of bq78z100.
> 2. Add [BQ27XXX_REG_RC] =3D 0x10. the RemainingCapacity command of=20
> bq78z100.
> 3. Set [BQ27XXX_REG_AE] to INVALID_REG_ADDR, support by bq78z100.
> 4. Delete property POWER_SUPPLY_PROP_TIME_TO_EMPTY_AVG, not support by=20
> bq78z100

I also asked to check other exposed properties and to provide a dump of the=
 power-supply uevent in commit message or cover letter to verify chip works=
 as expected. I cannot see the dump and you are exposing at least one prope=
rty that always reports -ENODATA. I intentionally will not point out the ex=
act property, so that you have to properly test your patch before submittin=
g.

Thanks,

-- Sebastian

> LI Qingwu (2):
>   dt-bindings: power: bq27xxx: add bq78z100
>   power: supply: bq27xxx: Add support for BQ78Z100
>=20
>  .../bindings/power/supply/bq27xxx.yaml        |  1 +
>  drivers/power/supply/bq27xxx_battery.c        | 44 +++++++++++++++++++
>  drivers/power/supply/bq27xxx_battery_i2c.c    |  2 +
>  include/linux/power/bq27xxx_battery.h         |  1 +
>  4 files changed, 48 insertions(+)
>=20
> --
> 2.17.1
>=20