Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Sender: mkshah=codeaurora.org@mg.codeaurora.org
DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 310BFC433C6
Subject: Re: [PATCH 1/3] arm64: dts: qcom: sm8350: Remove second reg from pdc
To:     Marc Zyngier <maz@kernel.org>
Cc:     swboyd@chromium.org, bjorn.andersson@linaro.org,
        linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
        robh+dt@kernel.org, dianders@chromium.org, rnayak@codeaurora.org,
        lsrao@codeaurora.org, devicetree@vger.kernel.org
References: <1615958996-31807-1-git-send-email-mkshah@codeaurora.org>
 <87k0q6i1g5.wl-maz@kernel.org>
From:   Maulik Shah <mkshah@codeaurora.org>
Message-ID: <bce03166-e65b-198c-8b93-39e0c218aaed@codeaurora.org>
Date:   Wed, 17 Mar 2021 15:18:09 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.8.1
MIME-Version: 1.0
In-Reply-To: <87k0q6i1g5.wl-maz@kernel.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-GB
Precedence: bulk

Hi Marc,

On 3/17/2021 2:47 PM, Marc Zyngier wrote:
> On Wed, 17 Mar 2021 05:29:54 +0000,
> Maulik Shah <mkshah@codeaurora.org> wrote:
>> PDC interrupt controller driver do not use second reg. Remove it.
> This is a DT file, not a driver. What the driver does is irrelevant.
>
> The real question is: what does this range do?
>
> Thanks,
>
> 	M.

This is to set interrupt type in SPI config for which there was a change 
[1] but has not gone in for upstream PDC driver.

The second reg is not used in upstream PDC driver, probably when posting 
downstream DT changes for sm8350/sm8250 it was carried in device node as is.

As its not mentioned in bindigs as well, dtbs_check reports it as 
additional reg when converted to yaml.

[1] 
https://patchwork.kernel.org/project/linux-arm-msm/patch/1568411962-1022-8-git-send-email-ilina@codeaurora.org/

Thanks,
Maulik
>
-- 
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation