Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp196636pxf; Wed, 17 Mar 2021 03:03:49 -0700 (PDT) X-Google-Smtp-Source: ABdhPJymwmfMwWz+Baz+aSgoFW56sXMBpzySbwj+RVveNTBDm3lPNloqBtq3DnNKW3MryGZKzeg/ X-Received: by 2002:aa7:da04:: with SMTP id r4mr41134915eds.343.1615975429461; Wed, 17 Mar 2021 03:03:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1615975429; cv=none; d=google.com; s=arc-20160816; b=GjNShnt0HFe37iWhNIGGvvd/+G2xzfXgcwETEnV1iLUOMSK2iGrmPUlRTgzydM6+Xb 9LrtHNTxjpov1o4OasVnVNDQGxlbigGDc9dB8D5OisV7Ae6Y04DUwc8xlM93eu8Upivh JxBBoYToc1vTTg9aZGjY2pViylJM+dfB9ILUlLDTwhAK0PQTn3RsKaZd4pE3/KfBVPWu 5/ibzS6bZAJVlLowfxwbs43qyviN5NGx5IOIfELp4Kx15hwIe5vKyk+Noigy/RW/FsW+ psLOpyQrflLzIzgyQZEpJ+pa4QP4hMrGMNIMrQxXWHjZCv4BF3GVkFytXTf2CEMmQM/g G1Kw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=fwM4adl1zLTMbGwku8hEsL8GInBP1dQ7HGaXmFSDFM8=; b=D7HldHIBDk9tN9cZtDjOu1Z4JURS9UhWI1wfp3A3RZWaWAsX8NUbj5c72YN85kxiOB +gZ0dxo87s7S5mzLTwbR0FVwW5uI8plTMjJtx3O4sbUNeiBmBxKfgsIzWB/0i3rbj9Ic 8L/eOHtrADRIWByPZs6wZ4HtxgJ9Mv94MobB7zKF3wsx2JNFfZSdvKkkVHsz+33Zffkl k251gX2NIx5Xczyebr7Mr7/6rtaM5IASwD+AAeUolF/npARlUPEj045C6n3DE3sjBtiJ m2sXNmWi3jOo1YXpbv1sDB384IyiOpYFz29WpZK003dhRVWH5b5+dJGgNlAEtGnLqD1q 3nXQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=MDvYWw5j; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id d3si16509191eds.83.2021.03.17.03.03.26; Wed, 17 Mar 2021 03:03:49 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=MDvYWw5j; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229585AbhCQKCX (ORCPT + 99 others); Wed, 17 Mar 2021 06:02:23 -0400 Received: from mail.kernel.org ([198.145.29.99]:59446 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229658AbhCQKCS (ORCPT ); Wed, 17 Mar 2021 06:02:18 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 2A7F164F6C; Wed, 17 Mar 2021 10:02:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1615975337; bh=rnFPxkpXYUq+oUBeFeUJ54dHBeYSHquuWQJDH+00gro=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=MDvYWw5juOdHu/wa5T8Bwx+L1fnA+U6JjUgp/+b2vv1ijzgnMzzJzFm896oT6rhbI HJWOavZZ1aePmX2iqLDyHFWxznQ6rFgV6iK8nEXWqs01h7NF2J5RsO/1AJO3UUI2Jd M+pcnrYGarWK8IuWbyn/c1lxZ6zITX+9iRQTxBBA= Date: Wed, 17 Mar 2021 11:02:13 +0100 From: Greg KH To: Fabio Aiuto Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: staging: rtl8723bs: remove unused code blocks completed? Message-ID: References: <20210317095932.GA2308@agape.jhs> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210317095932.GA2308@agape.jhs> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 17, 2021 at 10:59:32AM +0100, Fabio Aiuto wrote: > Hi, > > I'm trying to search other unused code blocks: > > grep -r '^\(#ifdef \|#if defined(\|#ifndef \)CONFIG_' drivers/staging/rtl8723bs/ > > drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c:#if defined(CONFIG_PM) > drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c:#if defined(CONFIG_PM) > drivers/staging/rtl8723bs/os_dep/ioctl_linux.c:#if defined(CONFIG_WEXT_PRIV) > drivers/staging/rtl8723bs/include/drv_conf.h:#ifndef CONFIG_RTW_HIQ_FILTER > drivers/staging/rtl8723bs/include/autoconf.h:#ifndef CONFIG_WIRELESS_EXT > > all blocks left are checked by existing defines. > Could we apply this? Sure, looks good, submit this as a real patch with this information in the changelog and I"ll be glad to take it. thanks, greg k-h