Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210311192746.7362-1-heiko.thiery@gmail.com> <20210317080249.GT11246@dragon>
 <CAEyMn7b3qGupUh28rgf3THW7+8aNwCVnxtmOyS8MJXgJ3UuE7A@mail.gmail.com>
In-Reply-To: <CAEyMn7b3qGupUh28rgf3THW7+8aNwCVnxtmOyS8MJXgJ3UuE7A@mail.gmail.com>
From:   Heiko Thiery <heiko.thiery@gmail.com>
Date:   Wed, 17 Mar 2021 12:56:56 +0100
Message-ID: <CAEyMn7akxwP8kXpdDttBBp1Hos3tXtAVS7=Ti7T6JAxmLf5zGg@mail.gmail.com>
Subject: Re: [PATCH v2] arm64: configs: Enable PCIe support for imx8mq boards
To:     Shawn Guo <shawnguo@kernel.org>
Cc:     linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        Catalin Marinas <catalin.marinas@arm.com>,
        Will Deacon <will@kernel.org>,
        Michael Walle <michael@walle.cc>,
        Lucas Stach <l.stach@pengutronix.de>,
        Baruch Siach <baruch@tkos.co.il>,
        Fabio Estevam <festevam@gmail.com>,
        Andrey Smirnov <andrew.smirnov@gmail.com>,
        Chris Healy <cphealy@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi Shawn,

Am Mi., 17. M=C3=A4rz 2021 um 12:52 Uhr schrieb Heiko Thiery
<heiko.thiery@gmail.com>:
>
> Hi Shawn,
>
> Am Mi., 17. M=C3=A4rz 2021 um 09:02 Uhr schrieb Shawn Guo <shawnguo@kerne=
l.org>:
> >
> > On Thu, Mar 11, 2021 at 08:27:47PM +0100, Heiko Thiery wrote:
> > > Enable PCI_IMX6 to get PCI support for imx8mq boards like imx8mq-evk,
> > > imx8mq-kontron-pitx-imx8m and imx8mq-zii-ultra.
> > >
> > > Signed-off-by: Heiko Thiery <heiko.thiery@gmail.com>
> > > ---
> > > v2:
> > >  - slightly modified the commit message (Fabio Estevam)
> > >
> > >  arch/arm64/configs/defconfig | 1 +
> > >  1 file changed, 1 insertion(+)
> > >
> > > diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defcon=
fig
> > > index 1f673b00c5f5..522bae6a8f21 100644
> > > --- a/arch/arm64/configs/defconfig
> > > +++ b/arch/arm64/configs/defconfig
> > > @@ -225,6 +225,7 @@ CONFIG_PCI_HOST_THUNDER_PEM=3Dy
> > >  CONFIG_PCI_HOST_THUNDER_ECAM=3Dy
> > >  CONFIG_PCIE_ROCKCHIP_HOST=3Dm
> > >  CONFIG_PCIE_BRCMSTB=3Dm
> > > +CONFIG_PCI_IMX6=3Dy
> >
> > Do we really want it to be built-in?  If so, it would be nice to have s=
ome
> > comments about that in commit log.

Or do you mean why it cannot be enabled as a module? The PCI_IMX6
driver is only a bool option in the Kconfig and cannot be built as a
module. So it is required to have it built-in.

>
> Why would you not want it? I see other SOC PCI controllers are also
> enabled. I would like to have it because we have an Intel e1000 on our
> pitx-imx8m board and the seconds PCI slot is for a m.2 card. So we
> would have the PCI support with the default defconfig. On the NXP
> imx8mq EVK a m.2 is connected to the PCI interface.
>
> Is this the kind of comments you want?
>
> > Shawn
> >
> > >  CONFIG_PCI_LAYERSCAPE=3Dy
> > >  CONFIG_PCIE_LAYERSCAPE_GEN4=3Dy
> > >  CONFIG_PCI_HISI=3Dy
> > > --
> > > 2.30.0
> > >
>
> BR
> --
> Heiko
> --
> Heiko